Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp205308ybl; Tue, 20 Aug 2019 18:24:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAR3k0RE6Erp7iVSJteOEs7E9Xd4ICqKl9S6xrh0NgqDHWZn7PEQrIfQEDHwYxudfNKkuE X-Received: by 2002:a65:684a:: with SMTP id q10mr27441739pgt.417.1566350675287; Tue, 20 Aug 2019 18:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566350675; cv=none; d=google.com; s=arc-20160816; b=c0WIflPc2MOqazDodwMEcwtMppsl3aZ/i3z9+uL8FrikIW+DY2y5UrsK0rhZYpGid1 rbXWPA1flkg/Z1Am/B0vAQqKf1+bZIdj5s7NLa+s3oTIl476eoeKy/bqiWCPDQ+dt88n rbkefViHTc/QJAJL7x8eIpTYjilYFl3JxNWpnyLTUI78XedhIX3q3/4f7z6MrJCotq82 kymUfmvG5YJ9v0A9uiLcFJF+7yQ8OjFuSpKrHgN7ZbzzpPmW4MESIYoiuQvU//wsKTtB IrW8OHCN0QHUA8e2sCyPG1BBr1LtTNIkyU6wuSV0YfehIPAhIrK7V3bzdXrhrI9b/tYq 6YMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=AKdMxy6Loy5FB18w5nCoqOGBhJ8fJx1gjbDaNSCdo2E=; b=rLP0lxRL3y3tm8Pfj1okEwprak/32Yfa+GSRzV00bGOQNF2sjUyzYrM8xj/2kxKZTq Ja9QV6p6+Zk0Qe4mS8/WUlw+4busbiP+dFnIC8V69PUbytsGgpWwCu1iYKxSkz0ZmVJH MyZXjJlCPE4hPmjR1WlmCRrD+JDuSjZpNKAzCnA8DG08tbQa9FImbon9PqZZ+cESalCF cH4CZsqY/A8oArYcwIMVrEqTejnReqnkREDqPRyBVeY3lgH1tsQcQB1b1a/lA30BcKzH IHTDB1XpNy2H1bxzSxvZi72cv78rAAGaZcYXRsnQRdABnjwMYirPk1Js5CTRV051JGB3 pFhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j97si13661802plb.5.2019.08.20.18.24.19; Tue, 20 Aug 2019 18:24:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbfHUBVW (ORCPT + 99 others); Tue, 20 Aug 2019 21:21:22 -0400 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:56133 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbfHUBVW (ORCPT ); Tue, 20 Aug 2019 21:21:22 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0Ta0SZIU_1566350478; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Ta0SZIU_1566350478) by smtp.aliyun-inc.com(127.0.0.1); Wed, 21 Aug 2019 09:21:19 +0800 Subject: Re: [PATCH 00/14] per memcg lru_lock To: Hugh Dickins , Michal Hocko Cc: Cgroups , LKML , Linux MM , Andrew Morton , Mel Gorman , Tejun Heo , Shakeel Butt , Yu Zhao , Daniel Jordan References: <1566294517-86418-1-git-send-email-alex.shi@linux.alibaba.com> <20190820104532.GP3111@dhcp22.suse.cz> From: Alex Shi Message-ID: <319c7a6c-6f1a-64c5-4920-e8279eb1e80b@linux.alibaba.com> Date: Wed, 21 Aug 2019 09:21:18 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Thanks for the Cc Michal. As Shakeel says, Google prodkernel has been > using our per-memcg lru locks for 7 years or so. Yes, we did not come > up with supporting performance data at the time of posting, nor since: > I see Alex has done much better on that (though I haven't even glanced > to see if +s are persuasive). > > https://lkml.org/lkml/2012/2/20/434 > was how ours was back then; some parts of that went in, then attached > lrulock417.tar is how it was the last time I rebased, to v4.17. > > I'll set aside what I'm doing, and switch to rebasing ours to v5.3-rc > and/or mmotm. Then compare with what Alex has, to see if there's any > good reason to prefer one to the other: if no good reason to prefer ours, > I doubt we shall bother to repost, but just use it as basis for helping > to review or improve Alex's. > Thanks for you all! Very glad to see we are trying on same point. :) Not only on per memcg lru_lock, there are much room on lru and page replacement tunings. Anyway Hope to see your update and more review comments soon. Thanks Alex