Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp389658ybl; Tue, 20 Aug 2019 22:27:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqzokmioww/WxmwF8mQtFlt//TxZiIj1zktzqXl/UwuaoYEu+pwOnSAFPgPIRTeiZZjpigjy X-Received: by 2002:aa7:81d4:: with SMTP id c20mr34005453pfn.235.1566365246085; Tue, 20 Aug 2019 22:27:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566365246; cv=none; d=google.com; s=arc-20160816; b=B0w2gaSpmustbm6CmFJm6EQZshXaalj8H+BIi5LOQJq3z91hs9S/meSX8pAVgyqYMI 6V7fqInL6obMim/9wMtrO0Xy2aF7tL/XceNVU/cMZWxPUzOyd60rwsOrAwdid8+UHXI8 qcBPiPtFB6lVpb+IiX+EOqLsKF6ktpstY4x0VDocK0M7ViiE67rtc7u+k96cOu86z8pc f1j4dDSaXvGSTH/tSPMIxK/tEsgVDUfCqPqXO57OZ1XaDtG0uiXruqNk6p31CfvHNbI1 0cMcTOWi/aYR7i15ipQhVJtkiGM5MDOj5sIJwYf1fvnAJBk0flIdDrV02Usn/8Yk5f12 Pg4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=Zoh4s8m2xZF0UqV1yfEv32RGUoJZBLPatCcqWyoZ7kM=; b=HMNzhDnnWFoytKdrN5w3GawgKbd9rrIHHj5h4UYy4qMmkdDkONaYtTx1v9w7dF/LAZ kArBVDX/PFIyuG54Ju6TC4H5dhW5SBXlhn4pdvpYifpuARzdmTj2iS1OT9igWmSOER37 gJb8Db76d3854DE9QTCZ7NIcns/KcNG4M4WiGzdFhQuJthG1F0npVnKIuP/KnbwKHpdC YBZwsGoN/WGRyhRzrzlI4bDnFX5uoKG/toOCiCwnGtkd8nrYS+CiPkiwKOjE6Sx2es0i L8c65Huh7l34X9R9MqjojlE9Vw56hPzN1nDMT6KpXWIrZIJd5ibv0hVrPHMLc6FPtWhY Bqmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 38si6872603pla.352.2019.08.20.22.27.10; Tue, 20 Aug 2019 22:27:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbfHUEgB (ORCPT + 99 others); Wed, 21 Aug 2019 00:36:01 -0400 Received: from gate.crashing.org ([63.228.1.57]:53878 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbfHUEgB (ORCPT ); Wed, 21 Aug 2019 00:36:01 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x7L4Zr77013135; Tue, 20 Aug 2019 23:35:54 -0500 Message-ID: Subject: Re: [PATCH] fsi: scom: Don't abort operations for minor errors From: Benjamin Herrenschmidt To: Eddie James , linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org Date: Wed, 21 Aug 2019 14:35:53 +1000 In-Reply-To: <1565896134-22749-1-git-send-email-eajames@linux.ibm.com> References: <1565896134-22749-1-git-send-email-eajames@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-08-15 at 14:08 -0500, Eddie James wrote: > The scom driver currently fails out of operations if certain system > errors are flagged in the status register; system checkstop, special > attention, or recoverable error. These errors won't impact the ability > of the scom engine to perform operations, so the driver should continue > under these conditions. > Also, don't do a PIB reset for these conditions, since it won't help. > > Signed-off-by: Eddie James Acked-by: Benjamin Herrenschmidt > --- > drivers/fsi/fsi-scom.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c > index 343153d..004dc03 100644 > --- a/drivers/fsi/fsi-scom.c > +++ b/drivers/fsi/fsi-scom.c > @@ -38,8 +38,7 @@ > #define SCOM_STATUS_PIB_RESP_MASK 0x00007000 > #define SCOM_STATUS_PIB_RESP_SHIFT 12 > > -#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_ERR_SUMMARY | \ > - SCOM_STATUS_PROTECTION | \ > +#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_PROTECTION | \ > SCOM_STATUS_PARITY | \ > SCOM_STATUS_PIB_ABORT | \ > SCOM_STATUS_PIB_RESP_MASK) > @@ -251,11 +250,6 @@ static int handle_fsi2pib_status(struct scom_device *scom, uint32_t status) > /* Return -EBUSY on PIB abort to force a retry */ > if (status & SCOM_STATUS_PIB_ABORT) > return -EBUSY; > - if (status & SCOM_STATUS_ERR_SUMMARY) { > - fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG, &dummy, > - sizeof(uint32_t)); > - return -EIO; > - } > return 0; > } >