Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     kishon@ti.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com, peter.harliman.liem@intel.com
References: <20190820103133.53776-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20190820103133.53776-2-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20190820135602.GN30120@smile.fi.intel.com>
 <20190820135921.GO30120@smile.fi.intel.com>
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Message-ID: <d9a793ae-e66c-a6ae-ab05-d253b8eb27d7@linux.intel.com>
Date:   Wed, 21 Aug 2019 13:34:19 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190820135921.GO30120@smile.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20/8/2019 9:59 PM, Andy Shevchenko wrote:
> On Tue, Aug 20, 2019 at 04:56:02PM +0300, Andy Shevchenko wrote:
>> On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>>> +#define DR_TY_50OHM(x)		((~(x) << 28) & DR_TY_MASK)
>> For consistency it should be
>>
>> #define DR_TY_SHIFT(x)		(((x) << 28) & DR_TY_MASK)
>>
>> with explanation about 50 Ohm in the code below.
>>> +	/* Drive impedance: 50 Ohm */
>> Nice, you have already a comment here. Just use DR_TY_SHIFT(1)
> It should be DR_TY_SHIFT(6) now since I dropped the negation.

Thanks Andy, will update the review comments.

Best Regards
Vadivel