Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp424672ybl; Tue, 20 Aug 2019 23:11:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDqIJipQ5KwIUGk7lVvo/Ta0sBUeaGZ9ZbN+khdSbpJVM4ALnYrTaJ7gb2luUXknvD+bfU X-Received: by 2002:a63:8141:: with SMTP id t62mr9258050pgd.95.1566367862486; Tue, 20 Aug 2019 23:11:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566367862; cv=none; d=google.com; s=arc-20160816; b=c8BJWT7ZG0kfFGBT0XXbvW/cWBCIIB2uHaNwTAXDZwryUCUYsivJpU6KpI9unJI7pr xhvV/HcLtTINS5lr09oCgM45jMGsTq0+adsJUk66HunQ3vYfMwzNIz/YeAZocJtivKrh QO4DKj2HsgmgyaOKUYHyz0oDdV+RfiU/+hjdD9a+LicTgErUC4R6ilQU8p3WWHyRlDWE l4RXxe+FuJvHC8A232hWM+ufolev1K9M9UM9rfKynmRgDlAW6RF5KyO/BbB45/+HKEro onVo9uKyIM0H4oLwGnLyKkq9i4g2HV2u3UJ7vr/1jWvBjJ0+g57V5OfmfHd275t3+jum DPmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=u4vudB10NnGSSIVbFDIExmT5iLFJ1FBMO1Iq0ZB2aGA=; b=wRkz++QHCvrA/rNR2+NqknOtEWvaWJiAkTI6Pp1lECJxBE2bl87XkTe7zbWX3ELCEk j0E8gqrBAa6V19JdqZV3cMV7JeHRNya3jGiAhWNtnugDfe8bQCluzZz4p0l/uv/QF57b L7N5Em1j+WJkmA8ww1GPFzCbItkzWSEgQ3LL7P+vidnCiMS2ibHjK3EyWvO2aDBe8Pw1 ifr3qERf7KZ1qbxnhFSDfVMQ5ByV0pP1VOrzGDGzEdcBTSzP+xuBBbAntXpQM2WVmVr4 MYYP5LLx+NMcXaxn5rtQ+b19xrwkJX0/hTY+JwYfgLPO44QOdFcn4EqHsmiCLDD2CDvx n1bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@jms.id.au header.s=google header.b=WvF1ftlo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si1541106pjo.15.2019.08.20.23.10.46; Tue, 20 Aug 2019 23:11:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@jms.id.au header.s=google header.b=WvF1ftlo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbfHUGGL (ORCPT + 99 others); Wed, 21 Aug 2019 02:06:11 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:36823 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbfHUGGL (ORCPT ); Wed, 21 Aug 2019 02:06:11 -0400 Received: by mail-qk1-f193.google.com with SMTP id d23so869157qko.3 for ; Tue, 20 Aug 2019 23:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u4vudB10NnGSSIVbFDIExmT5iLFJ1FBMO1Iq0ZB2aGA=; b=WvF1ftloUdpfjtWcfdm6rO6AOAmWH7IfHxfZ9J1MNR+X4HhR7PYkVvciSnk70rUSMH VLutVcOTXVIf5zCbD199NfcVBcjyD+/2Lk5tibNQVP8qTUP/r7T5SVHm1u4loLn1ysDg u+DmbgmLvHhpA3m0V/XGYeh6/zRNVYQzNwANY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u4vudB10NnGSSIVbFDIExmT5iLFJ1FBMO1Iq0ZB2aGA=; b=s/LNn89s4P+JLNqds/agJTV5Ef9rBlvL/qeyuGPgsIIXKb2iwnQZC/J0uekELkUUKJ QBKX13v+QApSHmxI0FCtt+/IpkOgIGnMRG/u+4VizGo/nVxM+aPTWtq9P0gdiCJXmMBa l3Sn3ziUGRayClChnLo1kfzFjcSrhKZwSG6rF3wJ+TEK07c46w9NR64FIm285ehjLsEp ilZgV0hQjeGqiAFIhALws34eITfwYex3iyngjXWNYuilW9fKV3MyS6dyIwQl0ZRmM11N r/tpLKSql+ELRhPNzd//rUK/NR54v4zKMcZzK9mDRUxegNJa20m5+9TWMqD6rwQgX3CU SR8Q== X-Gm-Message-State: APjAAAUq/5gN53JHIhWZPUfFhWZOxmnSVCusNUAIzJNIa2fHsJCOLiMr EUraYFL/Bt8/zREQpB7CD6SpMOlwDe1cMYljZbg= X-Received: by 2002:a05:620a:705:: with SMTP id 5mr30258433qkc.330.1566367569477; Tue, 20 Aug 2019 23:06:09 -0700 (PDT) MIME-Version: 1.0 References: <1565896134-22749-1-git-send-email-eajames@linux.ibm.com> In-Reply-To: From: Joel Stanley Date: Wed, 21 Aug 2019 06:05:58 +0000 Message-ID: Subject: Re: [PATCH] fsi: scom: Don't abort operations for minor errors To: Benjamin Herrenschmidt Cc: Eddie James , Linux Kernel Mailing List , Greg KH , Jeremy Kerr Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Aug 2019 at 05:26, Benjamin Herrenschmidt wrote: > > On Thu, 2019-08-15 at 14:08 -0500, Eddie James wrote: > > The scom driver currently fails out of operations if certain system > > errors are flagged in the status register; system checkstop, special > > attention, or recoverable error. These errors won't impact the ability > > of the scom engine to perform operations, so the driver should continue > > under these conditions. > > Also, don't do a PIB reset for these conditions, since it won't help. > > > > Signed-off-by: Eddie James > > Acked-by: Benjamin Herrenschmidt Thanks Ben. We also have one from jk which was sent to the openbmc list: Acked-by: Jeremy Kerr And we can add: Fixes: 6b293258cded ("fsi: scom: Major overhaul") I'll stick this in the FSI tree. Cheers, Joel > > > --- > > drivers/fsi/fsi-scom.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c > > index 343153d..004dc03 100644 > > --- a/drivers/fsi/fsi-scom.c > > +++ b/drivers/fsi/fsi-scom.c > > @@ -38,8 +38,7 @@ > > #define SCOM_STATUS_PIB_RESP_MASK 0x00007000 > > #define SCOM_STATUS_PIB_RESP_SHIFT 12 > > > > -#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_ERR_SUMMARY | \ > > - SCOM_STATUS_PROTECTION | \ > > +#define SCOM_STATUS_ANY_ERR (SCOM_STATUS_PROTECTION | \ > > SCOM_STATUS_PARITY | \ > > SCOM_STATUS_PIB_ABORT | \ > > SCOM_STATUS_PIB_RESP_MASK) > > @@ -251,11 +250,6 @@ static int handle_fsi2pib_status(struct scom_device *scom, uint32_t status) > > /* Return -EBUSY on PIB abort to force a retry */ > > if (status & SCOM_STATUS_PIB_ABORT) > > return -EBUSY; > > - if (status & SCOM_STATUS_ERR_SUMMARY) { > > - fsi_device_write(scom->fsi_dev, SCOM_FSI2PIB_RESET_REG, &dummy, > > - sizeof(uint32_t)); > > - return -EIO; > > - } > > return 0; > > } > > >