Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp435981ybl; Tue, 20 Aug 2019 23:24:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyU20N4WpvUuICE8DV+RcLHeAFcB+l+dGh13TTJK9WOVZ0+O62Cg1iyqa63iRbCNUi5kAqh X-Received: by 2002:a17:902:1e8:: with SMTP id b95mr10504484plb.28.1566368665639; Tue, 20 Aug 2019 23:24:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566368665; cv=none; d=google.com; s=arc-20160816; b=JSp5D5bHpDzNkPfWFyeGpGiySYi3QKh2DQ5YBp9E7w93h3sR79gNSPKM9YG1EGQD3D c5cJ/t1V27R5Jtt9/zaeZQv/GbJ2ZJs94q3LE+L47bqn0eZa2WmJTBEzCb869QmkKvOa eKhN/jJf4Y/MrXD/qZb2zLOh9qU0j3BFH1WsIzn5AtWn/fZ+ZNE9X7fXvFiN8ulMbwqf K+BojGdFsk0D3N3PMXiyppRq9lIl3Sz0NTOwY5vrtrYN0cGTt0k3Cg2JVP+rxipMx05R giM1ghNCOKZaHWU71cLkzgVeYbFJfdj23Z74iVsCTuQp8vvkXf7/XTFBiXDP8Q85oqda aHUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id:date :references:subject:cc:to:from; bh=roZ+qCY+2zj1N1SMLD2bUC8g5urIW5pVpX32ELvchOk=; b=i2RCK7rX2umev6jlTVjVji6lipRldiFN1ikkdYEK3GRrz+D8vis2EA+UZPpj3ldAUB tTPAI0yHwrzCQyXuogkknT86r8vxr40BeaMPu7V5DIgsdIRAL5rcNH1bw57TCgG+gJDJ vEdZLhHkv+xv4VZlAzi5Iaf+uIr3l9pZCb94xhgXDRzXgeTizY4Zoimklmue+7S0vZq0 w2gjBC6wTYX+Zfr3j6SCL+uqKv7avrLzWv14GFf4nvXiT3JkWUNbm+GWcwPFM1d6eLIW TC4OeZvoQnU5MMuXY9RkMVQk7mOAB45eTebBxl6CLcLKuhNQzStOcn/FIDOu6LxLIQhM X4mQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si13958030pgk.594.2019.08.20.23.24.09; Tue, 20 Aug 2019 23:24:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727457AbfHUFsQ (ORCPT + 99 others); Wed, 21 Aug 2019 01:48:16 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:53746 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbfHUFsQ (ORCPT ); Wed, 21 Aug 2019 01:48:16 -0400 Received: from localhost ([127.0.0.1] helo=vostro.local) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1i0JTP-0003j5-CO; Wed, 21 Aug 2019 07:47:55 +0200 From: John Ogness To: Sergey Senozhatsky Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Petr Mladek , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , Sergey Senozhatsky , Brendan Higgins Subject: Re: [RFC PATCH v4 8/9] printk-rb: new functionality to support printk References: <20190807222634.1723-1-john.ogness@linutronix.de> <20190807222634.1723-9-john.ogness@linutronix.de> <20190820095918.GB14137@jagdpanzerIV> Date: Wed, 21 Aug 2019 07:47:51 +0200 Message-ID: <8736hvf4s8.fsf@linutronix.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-08-20, Sergey Senozhatsky wrote: > [..] >> +void prb_init(struct printk_ringbuffer *rb, char *data, int data_size_bits, >> + struct prb_desc *descs, int desc_count_bits, >> + struct wait_queue_head *waitq) >> +{ >> + struct dataring *dr = &rb->dr; >> + struct numlist *nl = &rb->nl; >> + >> + rb->desc_count_bits = desc_count_bits; >> + rb->descs = descs; >> + atomic_long_set(&descs[0].id, 0); >> + descs[0].desc.begin_lpos = 1; >> + descs[0].desc.next_lpos = 1; > > dataring_desc_init(), perhaps? Agreed.