Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: XdwFxE4X0dtt3FMfrfNAUEoYbpPxRtg4WV7S4gOuOchtcHKqjzlVMGy8Ll1CObwSv/hQPd92jQ
 cDu1XIgqLGLbkauNZVwrKtSWFP76AEfo4ceUBDtLF1OMV27Z4qFsprBFLNR89UFICntvyFL06I
 2INv9IBqa6og8DZkQODzsXcXJYRDzepwGVnyFEc8YhK7zDGVV4+YS99JClGyQwrtTrGMrAFlVf
 RGoKWWLt7+ZObb22HJ86F9U02ojNXjorw0NBqmOk2PN9EzpO0H6hJ/zEua1C+bEFOHUA0YHYE3
 acA=
IronPort-SDR: fdyBt+JXIhPG0CFWkemOCzKcguNRAK/kCDDZUQMRBdxP29JPqL7w2zjL3kdSkgeBPwhIWu6SoK
 WZP1Tn9xoYxj3CsJtm0FcSBMmftg5AD9NixDvUSt3MpxtV/jHnD+Ad8URKVEvPEcIC4F+iJid/
 JxVOpqtUredwhxxITJBMY8r9i8dsfk++4Mkg2oszOQ4Q8QiyQPUrVWkYv+L+qpy0x69fDhd+QA
 s/2aqpAdqdrYa7Ntjyj2nmb6191KSeTnDEBY2p+lfCAaa4o7kXhGNtKMBGffHdtrURWuLLI44q
 UKz1+ZXpF9b/+xhkWoUDf+6y
IronPort-SDR: dmeZ0vyILOeZoHueTqrGz6gav5i6/c/2WlZFGhpNvVBF0lLJ7zJuzV7VU6kV+viKNmcFbL6iH3
 4/QI/F0pxBR/XhmKYbsFMZV4u0hUGGk8BfF6aiQ2LruBlMgkA8CdFCXg2prkuKquQdCdJEerxx
 fAUTpi6nB5Ha+YG/3B1IVGuKebLiyEhTWYEFr/iotOc7u+0s+6Ys4q8fJ4XO/pILstf5LJ/Dij
 ONshQqI9zByCDi17MHB6/WqO9fIK7mI6Vb+AQDUKM5XHtpKmXnOEZNJFzIjIHYxzo7PU23DP91
 x9s=
WDCIronportException: Internal
From:   Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     axboe@kernel.dk, Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: [PATCH V2 0/3] block: set ioprio value
Date:   Tue, 20 Aug 2019 23:11:53 -0700
Message-Id: <20190821061156.3127-1-chaitanya.kulkarni@wdc.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

While experimenting with the ionice, I came across the scenario where
I cannot see the bio/request priority field being set when using
blkdiscard for REQ_OP_DISCARD, REQ_OP_WRITE_ZEROES and other operations
like REQ_OP_WRITE_SAME, REQ_OP_ZONE_RESET, and flush.

This is a small patch-series which sets the ioprio value at various
places for the zone-reset, flush, write-zeroes and discard operations.
This patch series uses get_current_ioprio() so that bio associated
with the respective operation can inherit the value from current
process.

In order to test this, I've modified the null_blk and enabled the 
write_zeroes through module param. Following are the results.

Without these patches:-  

# modprobe null_blk gb=5 nr_devices=1 write_zeroes=1
# for prio in `seq 0 3`; do ionice -c ${prio} blkdiscard -z -o 0 -l 4096 /dev/nullb0; done
# dmesg  -c 
[  402.958458] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 0
[  402.966024] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 0
[  402.973960] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 0
[  402.981373] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 0
# 

With these patches:-

# modprobe null_blk gb=5 nr_devices=1 write_zeroes=1
# for prio in `seq 0 3`; do ionice -c ${prio} blkdiscard -z -o 0 -l 4096 /dev/nullb0; done 
# dmesg  -c 
[ 1426.091772] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 0
[ 1426.100177] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 1
[ 1426.108035] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 2
[ 1426.115768] null_handle_cmd REQ_OP_WRITE_ZEROES priority class 3
# 

With the block trace extension support is being worked on [1] which has
the ability to report the I/O priority, now we can track the correct
priority values with this patch-series.

Regards,
Chaitanya

[1] https://www.spinics.net/lists/linux-btrace/msg00880.html

* Changes from V1:-
1. Adjust the code for new changes from linux-block/for-next.  

Chaitanya Kulkarni (3):
  block: set ioprio for zone-reset bio
  block: set ioprio for flush bio
  block: set ioprio for discard, write-zeroes etc

 block/blk-flush.c | 1 +
 block/blk-lib.c   | 4 ++++
 block/blk-zoned.c | 2 ++
 3 files changed, 7 insertions(+)

-- 
2.17.0