Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RESEND] i386/kvm: support guest access CORE cstate
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Eduardo Habkost <ehabkost@redhat.com>
References: <1563154124-18579-1-git-send-email-wanpengli@tencent.com>
 <ba3ae595-7f82-d17b-e8ed-6e86e9195ce5@redhat.com>
 <CANRm+Cx1bEOXBx50K9gv08UWEGadKOCtCbAwVo0CFC-g1gS+Xg@mail.gmail.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Openpgp: preference=signencrypt
Message-ID: <82a0eb75-5710-3b03-cf8e-a00b156ee275@redhat.com>
Date:   Wed, 21 Aug 2019 09:55:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <CANRm+Cx1bEOXBx50K9gv08UWEGadKOCtCbAwVo0CFC-g1gS+Xg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20/08/19 09:16, Wanpeng Li wrote:
> Kindly reminder, :)

It's already in my pull request from yesterday.

Palo

> On Mon, 15 Jul 2019 at 17:16, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 15/07/19 03:28, Wanpeng Li wrote:
>>> From: Wanpeng Li <wanpengli@tencent.com>
>>>
>>> Allow guest reads CORE cstate when exposing host CPU power management capabilities
>>> to the guest. PKG cstate is restricted to avoid a guest to get the whole package
>>> information in multi-tenant scenario.
>>>
>>> Cc: Eduardo Habkost <ehabkost@redhat.com>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> Cc: Radim Krčmář <rkrcmar@redhat.com>
>>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>>
>> Hi,
>>
>> QEMU is in hard freeze now.  This will be applied after the release.
>>
>> Thanks,
>>
>> Paolo
>>
>>> ---
>>>  linux-headers/linux/kvm.h | 4 +++-
>>>  target/i386/kvm.c         | 3 ++-
>>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
>>> index b53ee59..d648fde 100644
>>> --- a/linux-headers/linux/kvm.h
>>> +++ b/linux-headers/linux/kvm.h
>>> @@ -696,9 +696,11 @@ struct kvm_ioeventfd {
>>>  #define KVM_X86_DISABLE_EXITS_MWAIT          (1 << 0)
>>>  #define KVM_X86_DISABLE_EXITS_HLT            (1 << 1)
>>>  #define KVM_X86_DISABLE_EXITS_PAUSE          (1 << 2)
>>> +#define KVM_X86_DISABLE_EXITS_CSTATE         (1 << 3)
>>>  #define KVM_X86_DISABLE_VALID_EXITS          (KVM_X86_DISABLE_EXITS_MWAIT | \
>>>                                                KVM_X86_DISABLE_EXITS_HLT | \
>>> -                                              KVM_X86_DISABLE_EXITS_PAUSE)
>>> +                                              KVM_X86_DISABLE_EXITS_PAUSE | \
>>> +                                              KVM_X86_DISABLE_EXITS_CSTATE)
>>>
>>>  /* for KVM_ENABLE_CAP */
>>>  struct kvm_enable_cap {
>>> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
>>> index 3b29ce5..49a0cc1 100644
>>> --- a/target/i386/kvm.c
>>> +++ b/target/i386/kvm.c
>>> @@ -1645,7 +1645,8 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
>>>          if (disable_exits) {
>>>              disable_exits &= (KVM_X86_DISABLE_EXITS_MWAIT |
>>>                                KVM_X86_DISABLE_EXITS_HLT |
>>> -                              KVM_X86_DISABLE_EXITS_PAUSE);
>>> +                              KVM_X86_DISABLE_EXITS_PAUSE |
>>> +                              KVM_X86_DISABLE_EXITS_CSTATE);
>>>          }
>>>
>>>          ret = kvm_vm_enable_cap(s, KVM_CAP_X86_DISABLE_EXITS, 0,
>>>
>>