Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp792686ybl; Wed, 21 Aug 2019 05:44:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxBBt4AAT8vUBfE9pxULVZfmGBv9K0iTLEVx5kdJsocaxaDtlPD9DkoUzjsJ8p6nCFyppjE X-Received: by 2002:a62:1444:: with SMTP id 65mr34980579pfu.145.1566391448367; Wed, 21 Aug 2019 05:44:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566391448; cv=none; d=google.com; s=arc-20160816; b=zhg2+NYUmLt5Htk2saLFE3jg1gIlYO2JPRzS0q3edZ518Rastf0Ja+IbHaGVjnXCJe aJ7SNGkiJxmdy1pMDHNpn0ei+mNEGNQeUxmcA7MrCDgCrir0W78UsM0kvYY+yify/Hof XUEV0c3OUZD3ZSGtFXHZ5mqLRA1j198lbba5fhTgcUM9ZrpYp7lDiFcSl2Oov31Xk5hv N13MKCLYlVQN0KxEfTtziCbNTCE0l/EnLiDOlxPI4gFCAwit2G3JwYwzRlImCNvg5ZrG 6xFj09oQtzDay9sDv8pQjt9LDqs2rq/69SBQ2nxMjkudrKI/0eJBCXt202eCjOXmKcHQ rZew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=p7WIx5glbp3VPfriuQk3f2tXV+QlxDA2lma6sYT83O0=; b=eiODXDbKTSYy1LTIOS3UuXUU23KLjVArpkLXYASUH+P7zSNQEa+UAFPOqCNpPoQSvi CJtsImJxW6PYvwP3Un6El1xkqH0kPXxX68/AaX4tW4m1+1mJRbiki58pTwBdk48X5kRm lL6q8szBZOF9nzSFmTZWel1+KRaXKigMwwVYlAypt0UK0WhcJI8BnabL304xwcuIIQ/F WaL4aJ3yufj7aEXmaavrX0Cgb/e+fhIni5PH5JMkkVKz2gWeiv+5No8Q7gaXHeIBHd50 hCDGmMqPjfBv2t8vpu46iaUMOmgTV3fGgjyBWBY9xOhbAksUVIQkqKJ5ANLAF7IY/OHh HeUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65si14895581ple.240.2019.08.21.05.43.52; Wed, 21 Aug 2019 05:44:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728404AbfHUMfc (ORCPT + 99 others); Wed, 21 Aug 2019 08:35:32 -0400 Received: from www62.your-server.de ([213.133.104.62]:42416 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfHUMfc (ORCPT ); Wed, 21 Aug 2019 08:35:32 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1i0Ppg-0007MX-QA; Wed, 21 Aug 2019 14:35:20 +0200 Received: from [2a02:120b:2c12:c120:71a0:62dd:894c:fd0e] (helo=pc-66.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1i0Ppg-000PkR-Hr; Wed, 21 Aug 2019 14:35:20 +0200 Subject: Re: [PATCH bpf-next v2 0/3] xdpsock: allow mmap2 usage for 32bits To: Ivan Khoronzhuk , magnus.karlsson@intel.com, bjorn.topel@intel.com Cc: davem@davemloft.net, hawk@kernel.org, john.fastabend@gmail.com, jakub.kicinski@netronome.com, netdev@vger.kernel.org, bpf@vger.kernel.org, xdp-newbies@vger.kernel.org, linux-kernel@vger.kernel.org, jlemon@flugsvamp.com, yhs@fb.com, andrii.nakryiko@gmail.com References: <20190815121356.8848-1-ivan.khoronzhuk@linaro.org> From: Daniel Borkmann Message-ID: <95fb201c-1623-149b-a72e-ed4860f742e1@iogearbox.net> Date: Wed, 21 Aug 2019 14:35:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190815121356.8848-1-ivan.khoronzhuk@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.3/25548/Wed Aug 21 10:27:18 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/15/19 2:13 PM, Ivan Khoronzhuk wrote: > This patchset contains several improvements for af_xdp socket umem > mappings for 32bit systems. Also, there is one more patch outside of > this series that on linux-next tree and related to mmap2 af_xdp umem > offsets: "mm: mmap: increase sockets maximum memory size pgoff for 32bits" > https://lkml.org/lkml/2019/8/12/549 > > Based on bpf-next/master > > Prev: https://lkml.org/lkml/2019/8/13/437 > > v2..v1: > - replaced "libbpf: add asm/unistd.h to xsk to get __NR_mmap2" on > "libbpf: use LFS (_FILE_OFFSET_BITS) instead of direct mmap2 > syscall" > - use vmap along with page_address to avoid overkill > - define mmap syscall trace5 for mmap if defined > > Ivan Khoronzhuk (3): > libbpf: use LFS (_FILE_OFFSET_BITS) instead of direct mmap2 syscall > xdp: xdp_umem: replace kmap on vmap for umem map > samples: bpf: syscal_nrs: use mmap2 if defined > > net/xdp/xdp_umem.c | 36 +++++++++++++++++++++++----- > samples/bpf/syscall_nrs.c | 6 +++++ > samples/bpf/tracex5_kern.c | 13 ++++++++++ > tools/lib/bpf/Makefile | 1 + > tools/lib/bpf/xsk.c | 49 +++++++++++--------------------------- > 5 files changed, 64 insertions(+), 41 deletions(-) > Applied, and fixed up typo in last one's subject, thanks!