Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Aug 2019 15:25:54 +0200
From:   Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Alexander Dahl <ada@thorsis.com>, linux-rt-users@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [ANNOUNCE] v5.2.9-rt3
Message-ID: <20190821132553.gjvya5lu6j2dfyo5@linutronix.de>
References: <20190816153616.fbridfzjkmfg4dnr@linutronix.de>
 <2182739.9IRgZpf3R8@ada>
 <20190820154418.GM3545@piout.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190820154418.GM3545@piout.net>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-08-20 17:44:18 [+0200], Alexandre Belloni wrote:
> Hi,
Hi,

> On 19/08/2019 13:03:51+0200, Alexander Dahl wrote:
> > Hei hei,
> > 
> > just tried to compile this v5.2.9-rt3 for SAMA5D27-SOM1-EK1 based on 
> > arch/arm/configs/sama5_defconfig and with running oldconfig and selecting 
> > defaults, but that fails if CONFIG_ATMEL_TCB_CLKSRC_USE_SLOW_CLOCK is not set. 
> > 
> > I think this is due to changes for Atmel TCLIB in v5.2 and the not yet adapted 
> > RT patch "clocksource: TCLIB: Allow higher clock rates for clock events", 
> > right?
> 
> Patch clocksource-tclib-allow-higher-clockrates.patch needs to be
> changed so:
> 
> ret = setup_clkevents(tc, best_divisor_idx);
> 
> becomes
> 
> ret = setup_clkevents(&tc, best_divisor_idx);
> 

I will fix that locally.

> Also, I would think clocksource-tclib-add-proper-depend.patch could be
> dropped. Instead, setup_clkevents should use atmel_tcb_divisors. It
> would then be necessary to move its declaration before the function.
> 
> Sebastian, can you take care of that or do you expect a patch? In the
> latter case, do you want a patch for the patch?

For the second part I would appreciate a patch. I can then drop
clocksource-tclib-add-proper-depend.patch if it is not an issue.

Sebastian