Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7d3d50666ced8fb27d0964fa51e78fcbd0aec82e.camel@surriel.com>
Subject: Re: Pointer magic in mm_init_cpumask()
From:   Rik van Riel <riel@surriel.com>
To:     Siarhei Liakh <sliakh.lkml@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Wed, 21 Aug 2019 10:26:08 -0400
In-Reply-To: <CALBuU529+=+Xmsccc3AU2R0tSOCJtMQx=yMGDHopc3=tO3uM3Q@mail.gmail.com>
References: <CALBuU529+=+Xmsccc3AU2R0tSOCJtMQx=yMGDHopc3=tO3uM3Q@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-k3HbeHCDITjKCpsf2FRY"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-k3HbeHCDITjKCpsf2FRY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2019-08-21 at 09:13 -0400, Siarhei Liakh wrote:

> If mm_cpumask() is not safe, then at the very least the following has
> to be fixed:
> $ grep -rIn 'cpumask_clear(mm_cpumask(' *
> arch/powerpc/include/asm/tlb.h:69:    cpumask_clear(mm_cpumask(mm));
> arch/sparc/mm/init_64.c:857:        cpumask_clear(mm_cpumask(mm));
> arch/ia64/include/asm/mmu_context.h:92:        cpumask_clear(mm_cpuma
> sk(mm));
> arch/csky/mm/asid.c:126:    cpumask_clear(mm_cpumask(mm));
> arch/arm/mm/context.c:233:    cpumask_clear(mm_cpumask(mm));
>=20
> Otherwise, mm_init_cpumask() can be simplified down to
> cpumask_clear(mm_cpumask(mm)).
> What do you think?

That looks like a nice cleanup.

I do not see why it would not work, but I suppose
that should be tested :)

--=20
All Rights Reversed.

--=-k3HbeHCDITjKCpsf2FRY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl1dVIEACgkQznnekoTE
3oNGSQf/Xbkuz6NK2iPNQsSsPRCz2ie4Qkxq6sQYeD+pD4f6YHog0GOGWTFFrAIT
FShUqfjcu5OgYAAuhifsZn9k9WjYeME+HSQON8we3IjyeAP05r5yE25TrvQgVc6l
5CrEle71a7go8l+f5ZcCB/gUJHZdRjaD+aJ3RIEPPwZ/O2YYofcGpHb4kHeFOABX
sxI8y9waEIQJlUBzOdIHuUajxyCh6W2zr0s7aM590iqGsFBbvvrKxQMK5F8HUbhP
ahi8PNbsO9bz3vLvVpKN9jzkJd5CviMCLO1oFN8cYvOjLfdKDo8BAQ2ddMJhQXej
4+pdaB4mVtUuTReDC/hMDQaiBcqbxg==
=sAMJ
-----END PGP SIGNATURE-----

--=-k3HbeHCDITjKCpsf2FRY--