Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1007401ybl; Wed, 21 Aug 2019 08:44:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyvJHRJP1SxeB2cTQtfrims4G2kTZPX0NdtkIuPCXxHKCqlXthbRj/Y65k33HKJ/s9/CCQG X-Received: by 2002:a63:394:: with SMTP id 142mr29738288pgd.43.1566402287805; Wed, 21 Aug 2019 08:44:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566402287; cv=none; d=google.com; s=arc-20160816; b=YmxryTdW+bn0/2V55o0LpOS2RYUrzR6lV1GDjT4l9nbjW+ai49b5CewY3ZGVwfnlvQ tjmKHvGN61hGC9AkjQ7gMrr+4pYxZizkEwnYsXR72d8Zos9SXccKGGpD+3Ym4KvqxqjU 5P8X7+1YQm3hsWPbptFVQ+juCxZQPd7MuVb8O2Lb6CfTeZYU0Y/mCjh8AcQDf3v3JbZL pYueSsee61mV4wKdPP7tfntLm/IXca5Ub54mVCt7icBrSlnJ/2xxslFSl9xIwLAdTYbY depxm55rg5wCnWjYfISp5VT2laLUlNJvb3InACx0A3L0jh2QwY6Zoggyf6prKlJcEJLH 3xZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=UXyep5gmvR7gzJOTpOWksLGbdCjw2vu09aQuJ/K1NOc=; b=ml+Oa0Mar8Qyf3Az0RpaFxq08RkMy4/uSrwBLzWpg0+/ePZwK3qrps2QoqDurcXiCy rHulELi8F4CZ2DuHvBMMC4IPi5ha5Y25STnuTdFj3xuWJg0ZY3JIsAGHA3ZJch5oIuLk eApmlrC5/uTYiY0nRss7kXrQnV60WnPJeYrTbmtva7nViltPSrliVlT9nCuszMGNh/3B T3cbg4l0gY5YCOwZF22PrNCNt6ESEOEIYyRge+N5s99lvnW9SUlv0kF4S8xxwDJ6eVTr E8dQarPxFUST+C8foDAzKt05t5eF4c9SYs0P7iUz1poqS+vUIfmgDjn4E/eU5q1KCHIi ULyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm3 header.b=nbdXa8G4; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=FIjJL6Gl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 185si16384757pfv.39.2019.08.21.08.44.32; Wed, 21 Aug 2019 08:44:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm3 header.b=nbdXa8G4; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=FIjJL6Gl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729893AbfHUPNi (ORCPT + 99 others); Wed, 21 Aug 2019 11:13:38 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47845 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728579AbfHUPNi (ORCPT ); Wed, 21 Aug 2019 11:13:38 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B0EDB2104C; Wed, 21 Aug 2019 11:13:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 21 Aug 2019 11:13:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=UXyep5gmvR7gzJOTpOWksLGbdCj w2vu09aQuJ/K1NOc=; b=nbdXa8G4twyAo8+ISYJ66Col/oqbNPt6AVX9SSYbLWi uAgVpzJjqkxbKQG67or8LQCT+IPbcLdn0o3xfgdFA9HPCTyZg3rugtLjV4L2ZaXg XqvcVOKqHJXR2qQlWcsKdBtQCWFUw/Q5lYfqyk4i4DE4ePTxDTK+QSof2+6+hyP7 b/VyxgUN7aFVkUAaGgDOL1O4tPmaKyhUcdTOh4b+Bs2n5YmUTvIc0izCvPsmazeJ a3S8CIxpKnFQH8SA6HDd+gGal3X0dJuoZKtjO+HMOTMFcDxa6AOrjYIwq8hb0ZI9 yqcLljMFXOFgyLw4fS1/LS5tBMycYqDOwjLzFmUdbbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=UXyep5 gmvR7gzJOTpOWksLGbdCjw2vu09aQuJ/K1NOc=; b=FIjJL6Gl6VLEJEiAyJNGPb kW2mq+V+KmKF+EFY5EHxYvMsHlVsJvq53dWdCdvtfL2Eh4wjCV5So9sx/1BrGMap tISxO+6XcL+FN4JMLbxH1lCehzf9H8fGJvmNPVtdN61zNw3YRlHAKYwVKabo/rBR y1u1SaDZXs1F5iaikSwoF5fSUANzT/m7iuUzY3vtErbJPsM9CFjTRJ7MfY8+sKxH qLtMTT0JFg8Dva+7vbWdE9NBVyhHRqbqC+uMIK2lEwVRdnmp5bA/CJtrcC+dr6wX fzW1FWM26hkD384cKHf6aRilJ+BzF7UEjZMXuZGvGQZjkWvNVdgvutCFNnxY7psQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudegfedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgfofgesthdtredt ofervdenucfhrhhomhepfdfvohgsihhnucevrdcujfgrrhguihhnghdfuceomhgvsehtoh gsihhnrdgttgeqnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepjedtrddu ieeirdektddrudelgeenucfrrghrrghmpehmrghilhhfrhhomhepmhgvsehtohgsihhnrd gttgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (wsip-70-166-80-194.sd.sd.cox.net [70.166.80.194]) by mail.messagingengine.com (Postfix) with ESMTPA id 81450D6005A; Wed, 21 Aug 2019 11:13:36 -0400 (EDT) Date: Wed, 21 Aug 2019 08:13:35 -0700 From: "Tobin C. Harding" To: Gao Xiang Cc: Joe Perches , Caitlyn , Chao Yu , Greg Kroah-Hartman , linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging/erofs: Balanced braces around a few conditional statements. Message-ID: <20190821151241.GF12461@ares> References: <1566346700-28536-1-git-send-email-caitlynannefinn@gmail.com> <1566346700-28536-3-git-send-email-caitlynannefinn@gmail.com> <7aaca457a3d3feb951082d0659eec568a908971f.camel@perches.com> <20190821023122.GA159802@architecture4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821023122.GA159802@architecture4> X-Mailer: Mutt 1.9.4 (2018-02-28) User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote: > On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote: > > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote: > > > Balanced braces to fix some checkpath warnings in inode.c and > > > unzip_vle.c > > [] > > > diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c > > [] > > > @@ -915,21 +915,21 @@ static int z_erofs_vle_unzip(struct super_block *sb, > > > mutex_lock(&work->lock); > > > nr_pages = work->nr_pages; > > > > > > - if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES)) > > > + if (likely(nr_pages <= Z_EROFS_VLE_VMAP_ONSTACK_PAGES)) { > > > pages = pages_onstack; > > > - else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES && > > > - mutex_trylock(&z_pagemap_global_lock)) > > > + } else if (nr_pages <= Z_EROFS_VLE_VMAP_GLOBAL_PAGES && > > > + mutex_trylock(&z_pagemap_global_lock)) { > > > > Extra space after tab > > There is actually balanced braces in linux-next. > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/staging/erofs/zdata.c#n762 Which tree did these changes go in through please Gao? I believe Caitlyn was working off of the staging-next branch of Greg's staging tree. thanks, Tobin.