Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1062381ybl; Wed, 21 Aug 2019 09:32:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+8ts3lXqxAJFEnA/WOyu9wRNn4ErN/tEr8c5pYJ5Y51oJ3sLGhKcoFHOXBI/fnl4Sf9zm X-Received: by 2002:a17:90a:e983:: with SMTP id v3mr821188pjy.81.1566405146978; Wed, 21 Aug 2019 09:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566405146; cv=none; d=google.com; s=arc-20160816; b=F+nrb2Xcvt/gi0FFFyn03kvU58Z5urHEGp2Z4Gd339SrdkLMU/+satv8rgRFv+5UcT 8688mqpFNx/FwwvrnwsDjwgEUZo8ABPPQ9eVV9NfaLZpQUgqsGDd/mhZDAHFRwZMZ+gL DXKhsSb6J4eUThQFCQfneEjzxezYCxjBVrJonb4mNMVB4421hua3WokNvzY3Z2Y2Tm2G suIojq/uXnVSgawRbFK2Pb29tocfPMw8Q70yWbKCc0kJw02I+3Utc0s7nA9sYZphEUmZ ddie0oEv+TbTpgE1WNXf1Ag0eV3wlE8e6HOk6cDmp/iSZ1iy3gbhcslYDOwM0USAy5tr wtlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4KNmPMdMpRcaiopS/kqA4Z7BAa/Mxu6wFBCewhz0O5g=; b=CkGJWdi3qFaq9gb2lB1zXz4oAmWXgT3XwxXS8MI31DjJDt6/IkeYLUP3JA0OwgTyyZ 2nixMlc3euaB1V9NWQGbGMMBr5wPNrt2z+zA3ktKOZek6Nx+RGmU7a2yd5mtQ+h4UCNe nqMLWQDG6XX10nLO0ezZNLvG73uv5HZj6Yeub+xLSCyEezhq+JyQSCXO7IvmbQIw3t1P Sqh/rrAwRnE50siP7dHYS3yPEG39VvXjCa3tDDhpoyzaaZoO+BTKvGmmRKXEuGQhw6PR 5fFTN3p3ugkJxFg1ksy/d5gbJe6vwT9BjiWa6FmM8EhfdjJn2yV3FXMlH+Ekok9KQJjH +8Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="kV/oZ5n9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s21si15863239pfe.204.2019.08.21.09.32.11; Wed, 21 Aug 2019 09:32:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="kV/oZ5n9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729253AbfHUQal (ORCPT + 99 others); Wed, 21 Aug 2019 12:30:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:53964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726828AbfHUQal (ORCPT ); Wed, 21 Aug 2019 12:30:41 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7367216F4; Wed, 21 Aug 2019 16:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566405040; bh=gV2U9wxJ+o1VAHDvjn0nJpm8IHEuAW3n7lpukRD1/FE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kV/oZ5n9xXqyLF0Na9idXpoU8mK4hSSEEUmF6K82W6dFdai4zw6/w7E2ka1zOHleG Q6/BBUDxq8GiIaY+juXKmrYPRYHoShYKvVU5/D+EVtYLiGTPzjKNqmF+1Hy3iBuBNf 5DmnJoL4ZQZ4UpDvXbPQQzo0QyPujgv5r+HmhUqg= Date: Wed, 21 Aug 2019 09:30:38 -0700 From: Greg Kroah-Hartman To: Nayna Jain Cc: linuxppc-dev@ozlabs.org, linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Ard Biesheuvel , Jeremy Kerr , Matthew Garret , Mimi Zohar , Claudio Carvalho , George Wilson , Elaine Palmer , Eric Ricther , Oliver O'Halloran Subject: Re: [PATCH v2 3/4] x86/efi: move common keyring handler functions to new file Message-ID: <20190821163038.GB28571@kroah.com> References: <1566400103-18201-1-git-send-email-nayna@linux.ibm.com> <1566400103-18201-4-git-send-email-nayna@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566400103-18201-4-git-send-email-nayna@linux.ibm.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 21, 2019 at 11:08:22AM -0400, Nayna Jain wrote: > This patch moves the common code to keyring_handler.c That says _what_ you are doing, but not _why_ you are doing it. We have no idea :(