Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1192510ybl; Wed, 21 Aug 2019 11:28:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxip40efbPBnFR/zdA85ZkEY8I72wKyMt+8Lq945li8rXnfqqaEJv8Z7gTk2pZLjxVTlykj X-Received: by 2002:a17:902:246:: with SMTP id 64mr29563647plc.112.1566412129036; Wed, 21 Aug 2019 11:28:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566412129; cv=none; d=google.com; s=arc-20160816; b=WnqcfrKZtIMIkjrvEIKWsie8Aui9R0hlRD+MW+qsDnbHfufKiOBP3mk+KgoXTZerLF kHXu8dkq49CCfMLuv63HujyU7HFoz9g/is/mTL6TtzJ9XWLTeAuyui3Kl8UJ3T5202rB CgJZCw3VmcftWRq8cFHh3b8wCJNxBfDmwtjVuOrGV9hlh5FXaOKcsxsD3Q7p3Tj+BwR9 Ftve3WS5kC8tTR/V1NLii/67WI8i4fBpy1nP2oxpdHsIDLzyeNUUMTGjCo69Pw1xCuTP Nb2e7Tegmcnp8YpQ5KolIQPtdCX+i75IoeMIu2G5SeQNwTrecTMLbHoGsmUh94+fXaUK K3gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to :subject:cc:to:from:date; bh=uGw0Jng5ss7IIN3FpewYVxlUTmQpSE30qswKi1KeQzQ=; b=qrpN4pRGkoW+nKmbsWcJcw/ETN397GKbGkkeGCvATIW32G0JlhI7Nqa8kpandFt8Mb GYa1Olb7aYnKqHaPF4V4TlBTiRDLNo92gpFvlPHwb07v14XjNZxZQ8DvuUQzLh319Ms1 ZGgjHGU32ZZZgPtkcTht9uOnAYhzTNDo4InEWq7yGPjZwskb8Xzs9bvChUDclWMrqJVw OffX7kuNviMQ2MXxAHmA/SQ+QfGTL43fC52lfKUbaZL7tpijyMVo0+l6QThtO2ZUKVX1 gqrt4rtP3AZGF/FIVLK7fTN+lRgfBpo0c4Ni0euY+bnecOdkqDidYBsfC5deb2qj6w08 GZNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si15524091ply.347.2019.08.21.11.28.33; Wed, 21 Aug 2019 11:28:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728967AbfHUQTq (ORCPT + 99 others); Wed, 21 Aug 2019 12:19:46 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:53716 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727464AbfHUQTq (ORCPT ); Wed, 21 Aug 2019 12:19:46 -0400 Received: (qmail 5546 invoked by uid 2102); 21 Aug 2019 12:19:45 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 21 Aug 2019 12:19:45 -0400 Date: Wed, 21 Aug 2019 12:19:45 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: syzbot cc: andreyknvl@google.com, , , Subject: Re: KASAN: use-after-free Read in hidraw_ioctl In-Reply-To: <00000000000027b5750590a087dc@google.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org #syz test: https://github.com/google/kasan.git e96407b4 Index: usb-devel/drivers/hid/hidraw.c =================================================================== --- usb-devel.orig/drivers/hid/hidraw.c +++ usb-devel/drivers/hid/hidraw.c @@ -370,7 +370,7 @@ static long hidraw_ioctl(struct file *fi mutex_lock(&minors_lock); dev = hidraw_table[minor]; - if (!dev) { + if (!dev || !dev->exist) { ret = -ENODEV; goto out; }