Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1199748ybl; Wed, 21 Aug 2019 11:35:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQdW5QHoYTOzsm33v6iFqibw/xgPJePONRdFYjvCdBekhfEPOsxeYW1QXpWuKf+J57Beco X-Received: by 2002:a65:690b:: with SMTP id s11mr26325661pgq.10.1566412529725; Wed, 21 Aug 2019 11:35:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566412529; cv=none; d=google.com; s=arc-20160816; b=Xf9zpeneKYNitPZbm/NeWcInElG6nwkxOmoUm5dpDrJNJmKvM4/VMPjqboIIF62K1L 3Gxb6luRryh07fy/NIEExH4J0DIILaoZGjrJiM0YXzoXxe4OChYpENXatKO3MVdKZT2q l26NqwAxzfN/PXSh/ZRT2UUZ7JaOPneUHYZoX87EgeSVrXsZq6H1wBMooHzCF9t5A5uy PjvRnk6gMoFwCmDDyrBYTlPvpMWn8FEEb3WJ2Yg/00tgNUkFKS3DpJMqrOMFHEKwEfgW wQ2rrK2tmsBWEUYt8eyS4zn/ElCbqv20VL7WfQTaaoR3du1E7QbB3Dw4eDsflttF0u6z qp1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject:cc :to:autocrypt:openpgp:from; bh=Yt1HEl9b7azXjvl2yyKLViDSQInoX/IUuQDyOEutJzw=; b=mBrxEGcFuP4pNbAAEG895vWGCAoDijGhPFwBJ2pHIVwb48PwmaW8SmsIst/5KYy+WU cOi54RCq8cNfBkCVEuLIIn2wla8hQms6iQTgZvXFg6L8c+TY684+7aSajzGXC7X2mbtE n9fUAZ97Cm6f3jdS+CSMEJKJFV5HPQv2oY9F0NnDr+HIETPnaHIH1AXZqFmStrvDb/7W E41iZYynzSp0V0IJMWJEDc7dwBe6fS1pT3ktTSFBJrBH+LNYDnWj0Yy6p9I6AYeZHOm1 EQDTBGRrlS/ptyD4xkc6SFxsmDcoMMV9zNBVCncbdcPhtcNUIb+asnjUe3Gk79D71nXA M14Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si14732318pgn.56.2019.08.21.11.35.14; Wed, 21 Aug 2019 11:35:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728511AbfHUSSn (ORCPT + 99 others); Wed, 21 Aug 2019 14:18:43 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38404 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727041AbfHUSSn (ORCPT ); Wed, 21 Aug 2019 14:18:43 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1i0VBw-0002r5-5S; Wed, 21 Aug 2019 18:18:40 +0000 From: Colin Ian King Openpgp: preference=signencrypt Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= To: Greg Kroah-Hartman , Jerry Chuang , John Whitmore , devel@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org Subject: re: Added Realtek rtl8192u driver to staging - static analysis report. Message-ID: Date: Wed, 21 Aug 2019 19:18:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Static analysis of linux-next picked up an issue with the following commit: commit 8fc8598e61f6f384f3eaf1d9b09500c12af47b37 Author: Jerry Chuang Date: Tue Nov 3 07:17:11 2009 -0200 Staging: Added Realtek rtl8192u driver to staging In drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c we have: CID 48331 (#1 of 1): Unused value (UNUSED_VALUE) assigned_pointer Assigning value from ieee->crypt[ieee->tx_keyidx] to crypt here, but that stored value is not used. 746 crypt = ieee->crypt[ieee->tx_keyidx]; 747 if (encrypt) 748 beacon_buf->capability |= cpu_to_le16(WLAN_CAPABILITY_PRIVACY); Pointer crypt is being assigned but is never used afterwards. Now either this is a redundant assignment and can be removed OR maybe crypt should be checked and there is a typo, e.g.: crypt = ieee->crypt[ieee->tx_keyidx]; if (crypt) ... Either way, it's not clear to me and I think the code needs cleaning up. Any ideas? Colin