Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     David Hildenbrand <david@redhat.com>
CC:     "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm/balloon_compaction: Informative allocation warnings
Thread-Topic: [PATCH v2] mm/balloon_compaction: Informative allocation
 warnings
Thread-Index: AQHVWEJHWn7VmeZ5cEugJmetWObq/6cF9CyAgAAAcQCAAAHXgIAAATcAgAAAlgCAAAHhgA==
Date:   Wed, 21 Aug 2019 19:19:18 +0000
Message-ID: <9DDD9A0D-C88C-4EEF-A41B-E5646BDEF414@vmware.com>
References: <20190821094159.40795-1-namit@vmware.com>
 <75ff92c2-7ae2-c4a6-cd1f-44741e29d20e@redhat.com>
 <4E10A342-9A51-4C1F-8E5A-8005AACEF4CE@vmware.com>
 <497b1189-8e1d-2926-ee5e-9077fcceb04b@redhat.com>
 <36AC2460-9E88-4BAF-B793-A14A00E41617@vmware.com>
 <3873b6ab-de6d-cac2-90e8-541fe86e2005@redhat.com>
In-Reply-To: <3873b6ab-de6d-cac2-90e8-541fe86e2005@redhat.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F2EB266CFF731C4798729C491FC45D72@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 47b123e6-436a-4c10-2780-08d7266c76bc
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2019 19:19:18.4501
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OAGZTuLecOGKeJDRewSHIP3AZr9oyY7dPrnJ8qqBJSGY6gCjkVh+t+bWXPGbXS8gcB/cXJMnRGlXxiavVx/FWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB3925
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Aug 21, 2019, at 12:12 PM, David Hildenbrand <david@redhat.com> wrote:
>=20
> On 21.08.19 21:10, Nadav Amit wrote:
>>> On Aug 21, 2019, at 12:06 PM, David Hildenbrand <david@redhat.com> wrot=
e:
>>>=20
>>> On 21.08.19 20:59, Nadav Amit wrote:
>>>>> On Aug 21, 2019, at 11:57 AM, David Hildenbrand <david@redhat.com> wr=
ote:
>>>>>=20
>>>>> On 21.08.19 11:41, Nadav Amit wrote:
>>>>>> There is no reason to print generic warnings when balloon memory
>>>>>> allocation fails, as failures are expected and can be handled
>>>>>> gracefully. Since VMware balloon now uses balloon-compaction
>>>>>> infrastructure, and suppressed these warnings before, it is also
>>>>>> beneficial to suppress these warnings to keep the same behavior that=
 the
>>>>>> balloon had before.
>>>>>>=20
>>>>>> Since such warnings can still be useful to indicate that the balloon=
 is
>>>>>> over-inflated, print more informative and less frightening warning i=
f
>>>>>> allocation fails instead.
>>>>>>=20
>>>>>> Cc: David Hildenbrand <david@redhat.com>
>>>>>> Cc: Jason Wang <jasowang@redhat.com>
>>>>>> Signed-off-by: Nadav Amit <namit@vmware.com>
>>>>>>=20
>>>>>> ---
>>>>>>=20
>>>>>> v1->v2:
>>>>>> * Print informative warnings instead suppressing [David]
>>>>>> ---
>>>>>> mm/balloon_compaction.c | 7 ++++++-
>>>>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>>>>=20
>>>>>> diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c
>>>>>> index 798275a51887..0c1d1f7689f0 100644
>>>>>> --- a/mm/balloon_compaction.c
>>>>>> +++ b/mm/balloon_compaction.c
>>>>>> @@ -124,7 +124,12 @@ EXPORT_SYMBOL_GPL(balloon_page_list_dequeue);
>>>>>> struct page *balloon_page_alloc(void)
>>>>>> {
>>>>>> 	struct page *page =3D alloc_page(balloon_mapping_gfp_mask() |
>>>>>> -				       __GFP_NOMEMALLOC | __GFP_NORETRY);
>>>>>> +				       __GFP_NOMEMALLOC | __GFP_NORETRY |
>>>>>> +				       __GFP_NOWARN);
>>>>>> +
>>>>>> +	if (!page)
>>>>>> +		pr_warn_ratelimited("memory balloon: memory allocation failed");
>>>>>> +
>>>>>> 	return page;
>>>>>> }
>>>>>> EXPORT_SYMBOL_GPL(balloon_page_alloc);
>>>>>=20
>>>>> Not sure if "memory balloon" is the right wording. hmmm.
>>>>>=20
>>>>> Acked-by: David Hildenbrand <david@redhat.com>
>>>>=20
>>>> Do you have a better suggestion?
>>>=20
>>> Not really - that's why I ack'ed :)
>>>=20
>>> However, thinking about it - what about moving the check + print to the
>>> caller and then using dev_warn... or sth. like simple "virtio_balloon:
>>> ..." ? You can then drop the warning for vmware balloon if you feel lik=
e
>>> not needing it.
>>=20
>> Actually, there is already a warning that is printed by the virtue_ballo=
on
>> in fill_balloon():
>>=20
>>                struct page *page =3D balloon_page_alloc();
>>=20
>>                if (!page) {
>>                        dev_info_ratelimited(&vb->vdev->dev,
>>                                             "Out of puff! Can't get %u p=
ages\n",
>>                                             VIRTIO_BALLOON_PAGES_PER_PAG=
E);
>>                        /* Sleep for at least 1/5 of a second before retr=
y. */
>>                        msleep(200);
>>                        break;
>>                }
>>=20
>> So are you ok with going back to v1?
>=20
> Whoops, I missed that - sorry - usually the warnings scream louder at me =
:D
>=20
> Yes, v1 is fine with me!

Thanks, I missed this one too. This change should prevent making users
concerned for no good reason.