Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: J9Uq8DN2wkXveoU4cJjJ9RGytFb9e8wKvvanGk8deGDuUyzCsk9bC325fZcNGeWOwtXkBnLFEA
 elHfwJJBKsMWG+HRm76Dp6BSHsZpTYpJ17WCAu5t1LIrcjkukushh9kg6U1z/MqsOGTCDxOIjE
 XxuxhjEyZ/na/mGHpB0A4M9mD+duOyItpJhkvBxzf2CQvyYo+NYUowAK8YmQgfy1NPH9kaYcxG
 gE1Vcn8hWZbw7IvBAfb8Xstmcz3SzWe98Z7eAG/ooKON17L73GycxUKY0O3ymrwT0/8xoSpjT8
 EyU=
IronPort-PHdr: =?us-ascii?q?9a23=3AywLkjRU5XHwQethDbf2tw13kyoPV8LGtZVwlr6?=
 =?us-ascii?q?E/grcLSJyIuqrYYx2At8tkgFKBZ4jH8fUM07OQ7/m6HzVcut3Y7SFKWacPfi?=
 =?us-ascii?q?dNsd8RkQ0kDZzNImzAB9muURYHGt9fXkRu5XCxPBsdMs//Y1rPvi/6tmZKSV?=
 =?us-ascii?q?3wOgVvO+v6BJPZgdip2OCu4Z3TZBhDiCagbb9oIxi6sBvdutMLjYZtJKs9xQ?=
 =?us-ascii?q?bFr3tMdu9L2W5mOFWfkgrm6Myt5pBj6SNQu/wg985ET6r3erkzQKJbAjo7LW?=
 =?us-ascii?q?07/dXnuhbfQwSB4HscSXgWnQFTAwfZ9hH6X4z+vTX8u+FgxSSVJ8z2TbQzWT?=
 =?us-ascii?q?S/86dmTQLjhSkbOzIl9mzcl9d9h7xHrh2/uxN/wpbUYICLO/p4YqPdZs4RSW?=
 =?us-ascii?q?5YUspMSyBNHoawYo0KD+oAJuZYtIj9p10BrRCjGweiHf7kyjFJhnDo2a01zv?=
 =?us-ascii?q?kqHQXI0QA8Gt4DtmnfotfoO6cISe27zLfGwyjNYf1V3jnw85TEfgw7rP2QR7?=
 =?us-ascii?q?98bdbdxE8yHA3FlFWQronlMiuX2eQMsmmb7/dgVeWygGMgqwBwozivyd0tio?=
 =?us-ascii?q?XVmo4YxEvJ9Thlz4YvP9G3VlN0YcO9HZZWqiqUNJN2T9s8T210vCs20L4LtJ?=
 =?us-ascii?q?6hcCQU1ZgqyATTZ+Kbf4SU+h7vSeecLDNiiH57dr+yhwy+/Vahx+HmVMS531?=
 =?us-ascii?q?BHpTdfnNbWrHACzRnT59CCSvt640iuxy6C1xvW6uFYOUA0krfbK4I5zr4wiJ?=
 =?us-ascii?q?UTtUPDEzfzmErsja+Wclwo+vCs6+j6e7nmqIGQO5Nohg3kPaQuncu/Aes8Mg?=
 =?us-ascii?q?cQRWSU5eO81Lj78U34RrVFkOE2n7HHvJzGIckXvK20Dg9P3oo99hqyAC2q3M?=
 =?us-ascii?q?oEkXUbNF5FfQiIj4ntO1HAOvD4CvK/jkyskTZqx/DJJLzhDonRInXNi7rhYK?=
 =?us-ascii?q?py61RGxAUt0N9f+opYCqsdL/LrRk/xqNvYAwc9Mwy1xebnFdp82podWW2RGK?=
 =?us-ascii?q?+ZNr3dsVuT6+IxLOmDepUVtCz+K/c7/f7ui2E2mVsHcamux5sXZyPwMO5hJh?=
 =?us-ascii?q?CoYGjsn9BJRXYYvgM/FLSxoECJS3hea2vkDPF03S0yFI/zVdSLfYuqmrHUmX?=
 =?us-ascii?q?jjEw=3D=3D?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Mike Isely <isely@pobox.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code
Date:   Wed, 21 Aug 2019 14:09:31 -0700
Message-Id: <20190821210931.9621-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag
will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL.
However, it will be used in the later if statement, which is
potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index ad5b25b89699..1fa05971316a 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -793,6 +793,7 @@ static unsigned int ctrl_cx2341x_getv4lflags(struct pvr2_ctrl *cptr)
 	struct v4l2_queryctrl qctrl;
 	struct pvr2_ctl_info *info;
 	qctrl.id = cptr->info->v4l_id;
+	memset(&qctr, 0, sizeof(qctrl))
 	cx2341x_ctrl_query(&cptr->hdw->enc_ctl_state,&qctrl);
 	/* Strip out the const so we can adjust a function pointer.  It's
 	   OK to do this here because we know this is a dynamically created
-- 
2.17.1