Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp246003ybl; Wed, 21 Aug 2019 18:30:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHB8tsrhSdJW9i6Kmv7q/Ike0oHhCSJLunHFh6zFOnv3FTTNIk1XAZsiNzi/xewenma2Mq X-Received: by 2002:a63:4846:: with SMTP id x6mr31867041pgk.332.1566437423491; Wed, 21 Aug 2019 18:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566437423; cv=none; d=google.com; s=arc-20160816; b=jQk4fsEJFUqG1i9BoQBgfaqFyhvqTVsPjDq7S9VtiCG0eIKY/zKncKbw8vazrRk2ja pbFyZ7JKfijp4Oz/m2AbhVwqLGXTjai6MUfSDmROv8r/7qnwZXGHugJF4FGqOicOCzYx tOP2MVlswTcyPy1fuZ5RModlNuNXxAX1jzZb8AzH0mAcjQeFhXOsIXx4PN74g420ZIBe IkQqwp/nLgPyaH3dl50bomyFlZefpREU76u0M8EhKJSgFliZO/VoPYMNUctmOPw+w/pK TPGREtsfyfSWKq3daapd7/nkhOJiOuLYxz2Eh7Ylcf+drLoDAnQi6q/kwET3zZGiSVwm q7Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=tjmcHkDDb0u7HTtUUq1ahiqlmHmFStmFZVfSaL4Jko0=; b=fd8Mg4uBnBf4U2TbQvKqY95f0ygLIywNWW9IgfQHf2PuAyKbmDidyNyiz+EspPtzDJ MdKQ7baG11a/KSo5FnMJJ9Z2HmnaaTyDOSdYvC/K9HVQebY2+d9K5Bg44lb+sM2KMWn5 W/Epgu09TpiR2qQNNmuLivWzMSqMpK580zd6NnKSRckKtyEiEVcPFfcpKv48vNxMgD6j kfHr8Shcsvcatii4V8AhUxkIzpDa1XSOJ9C2bdxBlwb4yv9NVUzPjc1xDAKYLssdwgjk Eh3LMwKsEvDygg89bSOsKVN1vfrf7DIKG5Ilziw3wbYEfvrUWbgKQbiIqDj51lQXaPbZ PHRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v11si16013781plg.31.2019.08.21.18.29.32; Wed, 21 Aug 2019 18:30:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728470AbfHUVVO (ORCPT + 99 others); Wed, 21 Aug 2019 17:21:14 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:40273 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726513AbfHUVVN (ORCPT ); Wed, 21 Aug 2019 17:21:13 -0400 Received: by mail-oi1-f193.google.com with SMTP id h21so2745298oie.7; Wed, 21 Aug 2019 14:21:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tjmcHkDDb0u7HTtUUq1ahiqlmHmFStmFZVfSaL4Jko0=; b=V6SDqcyHbEjOwJYOM4M7DNCOXsmfEa1XQZzh9Ifgk+bgQlnpFcfsKmT2C/toBof9Q4 rDm4z9m+BNR+kPVMOK/+mqmoxDDWhD6e4jcaMP4Rm8qfctCJvOJ9SdGEHdM33K4/E48I 8D9GCBwsR6ysNyaDLawdiUtidbFDKhU54SFuLn72Kh+exTIa/3lze9NkOdllnzrAV032 twKC8fJ+ZmV5xVZBwkxdxFs+W3uqUlRcn683mcrvlYL1uW7OzZE3omtd8HAqPdlCNNau R1UPpY8w/yqalry5tazzr+XajpQiXZmcClYZzO0YZA7ycTKaB+J1hipDJagrvLWgTCNF 1MIg== X-Gm-Message-State: APjAAAUxjNi5MLt7j2OF6Br6OyCuECUaeUWtNgmdLCU5dFvggdiTiU1b ehPnQ9SU8TLeLPWSSHjovg== X-Received: by 2002:aca:37c5:: with SMTP id e188mr1438662oia.66.1566422472753; Wed, 21 Aug 2019 14:21:12 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id f21sm8423504otq.7.2019.08.21.14.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2019 14:21:12 -0700 (PDT) Date: Wed, 21 Aug 2019 16:21:11 -0500 From: Rob Herring To: Joe Burmeister Cc: Mark Rutland , Arnd Bergmann , Greg Kroah-Hartman , Srinivas Kandagatla , YueHaibing , Bartosz Golaszewski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add optional chip erase functionality to AT25 EEPROM driver. Message-ID: <20190821212111.GA26116@bogus> References: <20190809125358.24440-1-joe.burmeister@devtank.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190809125358.24440-1-joe.burmeister@devtank.co.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 09, 2019 at 01:53:55PM +0100, Joe Burmeister wrote: > Many, though not all, AT25s have an instruction for chip erase. > If there is one in the datasheet, it can be added to device tree. > Erase can then be done in userspace via the sysfs API with a new > "erase" device attribute. This matches the eeprom_93xx46 driver's > "erase". > > Signed-off-by: Joe Burmeister > --- > .../devicetree/bindings/eeprom/at25.txt | 2 + Please split bindings to a separate patch. > drivers/misc/eeprom/at25.c | 83 ++++++++++++++++++- > 2 files changed, 82 insertions(+), 3 deletions(-)