Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp280710ybl; Wed, 21 Aug 2019 19:13:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBCwhmI3z7XH20tEo6Fs/x/nuTLjYWWymVEQEFKT6vU4jmdDoBOQuPHK1TEq57GZW9n6uc X-Received: by 2002:a17:902:aa08:: with SMTP id be8mr406537plb.144.1566440039596; Wed, 21 Aug 2019 19:13:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1566440039; cv=pass; d=google.com; s=arc-20160816; b=hJKCWCbcOvxVt7ZOVg8EwEummJCKXjL9BSP/qoKg7DXMpAFznSWMV6bd58nX3ESUor Uav5lL6ghp3CJWUO/bnp1AmKfZ4Tv1x961ZbW6IGk0QZqAqBDz/elUPcMqMKx3zA/2tx zNCJhpgVqk+v7Ymjmckf3KKtigTGcS3mh57/kVyDrZmbcueq9SxJe69Ct1smMylmMBu5 anCF7b+sp/aucqPVxPulpr4Xe+MLp61uDmxG+aAGy4id8FrJGDs2p9ADiE0m5Qkgy3xz erioCm+8Mc6VN72iCPtKjzGXwQ5xtmGAGUxo53BE1/1xKitXwtncVZjsinDQwYX0n+Yr Jbkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=K6p3Ii3/R2/6F+qjk0FyJxibjg29ELjDMma7R5Romts=; b=bTpa4Z1z/EBFDSvTbJcv5Lc4OtWOSGag4qpmF95DfGZDFdC9h6tzuQ+cJZnxL/9+8w 1vhD09fY6dH0CaKQPsAyb5cyR22vP2O2wOyM0fR25uYsdtYHArdNiYQ+pw8udu4l+F+c h7S1axRRUOmp2g7vJ5JP7MCeVtgMSsAbrXnlHFr8Kff4nZxeUdGhvTw6ixnJ4muGlmTi 0WPji0Qql58P9Ciuaq8cu3J9SzEgj6y+AuLFWyRjqCXYWx758OuPFYKGa/pFAkgcNBMr gYc+EA4wSwCrsM1KLU6o4pYpOkpwPzYMe8zAnTTQYHE8QaIQzobIBSZiJj7TRI2Xgrak Fm0Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@brennan.io header.s=selector01 header.b=KFvuWT5s; arc=pass (i=1 spf=pass spfdomain=brennan.io dkim=pass dkdomain=brennan.io dmarc=pass fromdomain=brennan.io>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o132si16925221pfg.249.2019.08.21.19.13.44; Wed, 21 Aug 2019 19:13:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@brennan.io header.s=selector01 header.b=KFvuWT5s; arc=pass (i=1 spf=pass spfdomain=brennan.io dkim=pass dkdomain=brennan.io dmarc=pass fromdomain=brennan.io>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731030AbfHUV5D (ORCPT + 99 others); Wed, 21 Aug 2019 17:57:03 -0400 Received: from sender-of-o52.zoho.com ([135.84.80.217]:21408 "EHLO sender-of-o52.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728801AbfHUV5D (ORCPT ); Wed, 21 Aug 2019 17:57:03 -0400 X-Greylist: delayed 26469 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Aug 2019 17:57:02 EDT ARC-Seal: i=1; a=rsa-sha256; t=1566424615; cv=none; d=zoho.com; s=zohoarc; b=UvpBdk+fuAuGtPQhKcAnsqebddmhEzTWNzoCg4Ic8cl6e2L7+YGANoTQNMWwCmMzWrZJgyh04Wj6ZfzBUVxSq8gjZ0zdeHlPC/sTMZ1+1UzfExmBLqez4F93lXClYOa23+DaqWLH1R6sPikcvUSWEHwJIOi9qGyUvoLLRpHVP/g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566424615; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=K6p3Ii3/R2/6F+qjk0FyJxibjg29ELjDMma7R5Romts=; b=mvxN036wW0pVPX0RiDCv+VX/gb7OFxvHW+ZawQISxK3GEdiBWt5r8a2fHKJAiM4W2ruHQO+vLmNI/pj1DYqbNHayPERhwuMAahVsvLcsRX3wKzS24eUbkRcXElgBRqZuJhRvkXlouYutEOMEhh5DrCwBNr2qGKoMFAijQPRlt/Q= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=brennan.io; spf=pass smtp.mailfrom=stephen@brennan.io; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1566424615; s=selector01; d=brennan.io; i=stephen@brennan.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=429; bh=K6p3Ii3/R2/6F+qjk0FyJxibjg29ELjDMma7R5Romts=; b=KFvuWT5sOYWq1qZBxbJIqHdZrR4jtVpruSPFTvjn6qSuQLkY0myd7aS/5EmGMD9E dI2aUzhcL4Kl04L0mdOmBoASU7c4rWffS8Dp66b1v1znZnS6lNT3h/jLYgVFxQlnv8Z 2WQ1ZpSGBIoL2yS49rAv8/WxYbHdgWgzWUzC5aeU= Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) by mx.zohomail.com with SMTPS id 1566424614832454.3465790795368; Wed, 21 Aug 2019 14:56:54 -0700 (PDT) Date: Wed, 21 Aug 2019 14:56:53 -0700 From: stephen@brennan.io To: Greg Kroah-Hartman Cc: Colin Ian King , devel@driverdev.osuosl.org, Jerry Chuang , linux-kernel@vger.kernel.org, John Whitmore Subject: Re: Added Realtek rtl8192u driver to staging - static analysis report. Message-ID: <20190821215653.GA8199@pride> References: <20190821205531.GC17415@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821205531.GC17415@kroah.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-ZohoMailClient: External Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Either way, it's not clear to me and I think the code needs cleaning > > up. > > Any ideas? > > 10+ year old code, yeah!!! > > Just guess, who knows, no one seems to care :( I'm at least interested in helping with cleaning the code and learning about the driver, maybe fixing up logical errors like this at some point. But I have had some trouble finding the hardware to test on. Maybe that's part of the issue?