Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp692933ybl; Thu, 22 Aug 2019 03:27:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyY4kshcYWBLxhqsbEmm0Y0Y6Va4KntZgoGOtwF5MHeW78/iChYG5UWBdPdS6LlAqRXu4cp X-Received: by 2002:a17:90a:5803:: with SMTP id h3mr4672943pji.133.1566469663426; Thu, 22 Aug 2019 03:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566469663; cv=none; d=google.com; s=arc-20160816; b=f7hA40g9e4KyDm6BKV6PqRmFgRxDsZPgwaXsAXNXqApd3WucXJ7nF8hm+UUX1Gvi+M pHeXtoUuKAqgOcGL1HI5ype8SkEWYVXiQXgdGnfN2Z9OsuCCbjReQKunlRqg5GDNZXpJ mw3ZnV2C+0zMMuobCnbS5XLhh3bYSDbN/x3RPpRJ/5wUY5bH87xTzvBnoUgaZIDcwAC4 4yOqUvWfWRgVOzGklDywn30Mb4rdadMrG+YVmgqVgeDCGCjHzmHueDfHliGEJXwQrwS3 AfnmCRTR4K2mMcL8ifevTHGNee2WfvqX9Tzt+L2nE7zTlr8wsXFgdS+ZNLlZhbeaTCXH Gcaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=s6KN7n7wkiNHTz781fv1oKcr9eZQGtOISMDsPqy3ymQ=; b=Pq1e8Oyp8mpswznih7KhQQgQwR12EqBYnCluk0hjy0BFJg+rX76CUU3JqswT8yxqS6 RUrGBaeO/6OXkqgdBRxQ/Fwse+oNLXPZ4Rmxto4iEc4iUBS7gx8K7M+TM+xsO5tHiaGv sR9FBgBoZBdl9fLuhtC9109WJSkt4Az7iVanhsJLnEKEZ/EpmQiJ5UPN9WjVPXroLK4x iCaFAQjz+AcIbjeUcOR8OYj0HpFEOMSzggWILzymTfmt76fGuhB5T5u0B0hef1APsysz +frcrS+ghTMNlVTqRGoHTqxDdUFh/Co8P88jtH3q9TkWQoczhxY9zcPoQXJC10DW0lyk /h7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=ANhJW+v2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q135si18031197pfc.125.2019.08.22.03.27.28; Thu, 22 Aug 2019 03:27:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=ANhJW+v2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732122AbfHVIM1 (ORCPT + 99 others); Thu, 22 Aug 2019 04:12:27 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:59400 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732043AbfHVIM1 (ORCPT ); Thu, 22 Aug 2019 04:12:27 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7M89D3w092228; Thu, 22 Aug 2019 08:12:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=s6KN7n7wkiNHTz781fv1oKcr9eZQGtOISMDsPqy3ymQ=; b=ANhJW+v28SWzBNlNfDsbjycGnBonf7D7p/r/wJWQ1wvnMwnYCy5OCHIjxogBEY0+P6KR IlCOFKI2PBPstULr+daaouDQDz5JdrdpnaJtkiMOV+O06OSWLj5jjHXyS+p9d9JyirEC JAKK0U7BYTcL5891CU6dXOTExay5CsWRjyUoExGPKFR0EzFCRso/xg3rXnpaUsOxsNkl UXCtUuT/ontlARDj4qNGQApzlnHP9BW3/9SWwg8XIrcKkrZTGs/pFvG2T2rnBpePdtxe Sq9oWmpv5pn35QBWO7cjbycwdhpHKEE/d6S5S40MEeNoJac5zTqrk0qiYAukSvz93c+p dQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2ue9hpuhvs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Aug 2019 08:12:02 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7M88dgY148864; Thu, 22 Aug 2019 08:12:01 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2uh83pqfy5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Aug 2019 08:12:01 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7M8C0Ii007220; Thu, 22 Aug 2019 08:12:00 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 22 Aug 2019 08:11:59 +0000 Date: Thu, 22 Aug 2019 11:11:53 +0300 From: Dan Carpenter To: Austin Kim Cc: darrick.wong@oracle.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] xfs: Use BUG_ON rather than BUG() to remove unreachable code Message-ID: <20190822081153.GG4451@kadam> References: <20190822062320.GA35267@LGEARND20B15> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190822062320.GA35267@LGEARND20B15> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9355 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=844 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908220089 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9355 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=915 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908220089 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Depending on the config BUG() might be a no-op. Outside of filesystems everyone ignores that and crashes ungracefully, but in filesystems they don't want to risk corrupting your files. regards, dan carpenter