Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1523814ybl; Thu, 22 Aug 2019 16:23:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqz4/Gkg3+pENDi+oB6bvHysoHblBrcb/1RIM4fgDlbvMWYheBwLaiOELBh99E2HlZ/8MPiO X-Received: by 2002:a17:902:7842:: with SMTP id e2mr1375795pln.49.1566516232854; Thu, 22 Aug 2019 16:23:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566516232; cv=none; d=google.com; s=arc-20160816; b=R8LouUv8cX1PMy5rHRWs0xWTgEn9lJNAQ7h1WldCek0iWG44RNOZosq87Dt+ROW4z3 YP/PdEXxnCW1Dthhzoear7oLdVr3FsUT3LpQPCOtfAXzlOSuM6HGVXWyScQGoessZdHb kcfgra7BSmq+o+KjVOdsRN9Ad67h5lfX8xDY5za+7TX53kZUATXwMcJLw9hpcGru8qVP pK3ZC2O0PlR/3PmAmjy+uCdYjO/Qcjw1qkMq5wzt8omWQtsqZBp4ae0gwp3989w4tkBh FPk4a1/2w5cm3kuAXB0ey3qVOeseaYVptWYU4SJCdBkuf9v3GCUkuBCbUezmr8/5tYCt f14Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=58JDx9ejV7geFIJMe/HCuKNsZp4QRQqZ+y1qnUsxoVA=; b=AxSHsxebr8psRPDkX2IgcvTINvvsTtw3zhZJXhlXp683P15IJ95IKVW/fXLdd+5Eyd 80MJXfF0UeTXUJb7G/BOQn9j7CTaf1NWtt3Qi/7zKLJDp4VxQnenhiwul3egYISAe6MK aD7b2N76HL07f6zulbkStpwRK9cvMYEyYL965GR8oLetWaazFHTbtZFFRuHm77Uxw3Tl J6vR1QAJnfbDRT27qU4XmeGpcGsPVfXuRj9deMJHXaWNeUhqYgpuacNBiRKtO5Q6D3Pn +2sjZcx8LIX2cItUgr7keNWU679LvCnQ4WPuqDiuqlSk/HHdTUlREjHG7SLAeHqcPWBB msog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VpH9QfAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si890325pfo.131.2019.08.22.16.23.38; Thu, 22 Aug 2019 16:23:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VpH9QfAa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391195AbfHVRQB (ORCPT + 99 others); Thu, 22 Aug 2019 13:16:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:58190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390429AbfHVRIj (ORCPT ); Thu, 22 Aug 2019 13:08:39 -0400 Received: from sasha-vm.mshome.net (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A30823402; Thu, 22 Aug 2019 17:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566493719; bh=7PacgezBhWgl49FGiKUsGiEA921Ao2dsp7XTPPO661U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VpH9QfAaeq2dPs+EFjRNMN7x2y/PKOL7niCWlhC17ubWWrOfFTV2lkpIfTrCNbl2i xYEVCfJkWRCtRCQUxJGg8AtE41tog3bHeuNpd5l4JGKFUhzKJUa3htfAU+a6wAYkia 2rndjLzgeWdfwT5LqZt85jN+4S8/B6NqOWJyB4to= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nianyao Tang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Shaokun Zhang , Marc Zyngier , Sasha Levin Subject: [PATCH 5.2 047/135] irqchip/gic-v3-its: Free unused vpt_page when alloc vpe table fail Date: Thu, 22 Aug 2019 13:06:43 -0400 Message-Id: <20190822170811.13303-48-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190822170811.13303-1-sashal@kernel.org> References: <20190822170811.13303-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.2.10-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.2.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.2.10-rc1 X-KernelTest-Deadline: 2019-08-24T17:07+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nianyao Tang [ Upstream commit 34f8eb92ca053cbba2887bb7e4dbf2b2cd6eb733 ] In its_vpe_init, when its_alloc_vpe_table fails, we should free vpt_page allocated just before, instead of vpe->vpt_page. Let's fix it. Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Signed-off-by: Nianyao Tang Signed-off-by: Shaokun Zhang Signed-off-by: Marc Zyngier Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 35500801dc2b5..20e5482d91b94 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -3010,7 +3010,7 @@ static int its_vpe_init(struct its_vpe *vpe) if (!its_alloc_vpe_table(vpe_id)) { its_vpe_id_free(vpe_id); - its_free_pending_table(vpe->vpt_page); + its_free_pending_table(vpt_page); return -ENOMEM; } -- 2.20.1