Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp46692ybl; Thu, 22 Aug 2019 19:29:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQqPlGCULjtbMI1H9HHizMqN5zuj4RxTZDqvAeyQy6UiLi9/ZtRLTb83IGyDRinnvsjyRA X-Received: by 2002:a17:90a:c20f:: with SMTP id e15mr2736062pjt.123.1566527340452; Thu, 22 Aug 2019 19:29:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566527340; cv=none; d=google.com; s=arc-20160816; b=bJFM65tle1qYE3uGJo7fo3lewVXExAUgMVNG6PSu6jm3Lkbb9/P7iciqrEcm0VDQX9 jdFThAlLSbxbwGshubGAkHnK1H4q0GsL2KlJt6mnS6MQNAEZy07MTgS+JaqY33YZ7miE hSYY8wcDJ1PwQETGCRiHRHMDvmo0haggaDrT5vfcY+aX8x3I7fnzVSeugAdu/xcqv+Uj TZi2S/gnBZ+CM4mphvKY1DiQKkw9mGOPvH+E+Rp5c3hZVhT0No3Xj8PBJxb1IZRTOMqe klo2qJ5DKpzmHjqM16ae3a3tJSYyxSKr5UFNDXrHe68FVB9OJr9QAhdrqkfMme03Kr+A jz4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fnAZydPHPa75y+h3Wm3vVrE7SHYsElOBd4Rx39maMXI=; b=iyl0ei+u69sPu8ioNnaq3xMKgN8Pg9tXpnsffh+SDUuYp8RcvVSVCRwh20Vqr3HrQl 9c1tjKg7wMdlTJePYYkmukIbT9I84CN6MQtfEdH2O2SodqE41VrDSZMmbwNQRSlxlGSq sNmwDCyy1SEmpIpJI5K+mQ96f3INIObABL1XHrhZRrNvLRAVD782RekSJ6KcsWIJ6oEI oUTkqRxV38inve1mBcMh3yF5bXeAsBTTfpOc8eFg+puQyH481A8ZpwmrptWQQAhe+9zC YjZ0avizPpWXxsierFNmxXVxs9CDDi4BZ9EYeauR+0LV9/UtECBBV6zgSucNldUg5DWi 7qJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p+a+GWHK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c27si1259543pfp.269.2019.08.22.19.28.45; Thu, 22 Aug 2019 19:29:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=p+a+GWHK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391978AbfHVR1O (ORCPT + 99 others); Thu, 22 Aug 2019 13:27:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:50226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391881AbfHVRZv (ORCPT ); Thu, 22 Aug 2019 13:25:51 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE1CB2341A; Thu, 22 Aug 2019 17:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494750; bh=MiVH04AIbN27EQ0NGGAjtlwNJIXsIQ/6pXa1yHeFNAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p+a+GWHKomoXilAoXLFD1t0PNB6KjNJ28IluW9l1cI0hay5ZU69dfcGcWi7zRuDa6 t7S3ICsQxuG2v8q+JRHnBcCDTZk8wR7rPxafSb6xgFKVIeKGg6Jim/wcL5MhuXIgpV Prf4krzC1ZAnq2VsOjhPO0sAsfFuGtF1rxzJ2+4M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Sasha Levin Subject: [PATCH 4.19 41/85] kbuild: modpost: handle KBUILD_EXTRA_SYMBOLS only for external modules Date: Thu, 22 Aug 2019 10:19:14 -0700 Message-Id: <20190822171733.082057579@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171731.012687054@linuxfoundation.org> References: <20190822171731.012687054@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit cb4819934a7f9b87876f11ed05b8624c0114551b ] KBUILD_EXTRA_SYMBOLS makes sense only when building external modules. Moreover, the modpost sets 'external_module' if the -e option is given. I replaced $(patsubst %, -e %,...) with simpler $(addprefix -e,...) while I was here. Signed-off-by: Masahiro Yamada Signed-off-by: Sasha Levin --- scripts/Makefile.modpost | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index 7d4af0d0accb3..51884c7b80697 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -75,7 +75,7 @@ modpost = scripts/mod/modpost \ $(if $(CONFIG_MODULE_SRCVERSION_ALL),-a,) \ $(if $(KBUILD_EXTMOD),-i,-o) $(kernelsymfile) \ $(if $(KBUILD_EXTMOD),-I $(modulesymfile)) \ - $(if $(KBUILD_EXTRA_SYMBOLS), $(patsubst %, -e %,$(KBUILD_EXTRA_SYMBOLS))) \ + $(if $(KBUILD_EXTMOD),$(addprefix -e ,$(KBUILD_EXTRA_SYMBOLS))) \ $(if $(KBUILD_EXTMOD),-o $(modulesymfile)) \ $(if $(CONFIG_DEBUG_SECTION_MISMATCH),,-S) \ $(if $(CONFIG_SECTION_MISMATCH_WARN_ONLY),,-E) \ -- 2.20.1