Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp222028ybl; Thu, 22 Aug 2019 23:18:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzQRSzlOlHJriHbW9mYnayZXOBSkoutbNC6aoecRyr2ik35DGWCfXbfTGb5lKD7Jfuq1zy X-Received: by 2002:a17:90a:8083:: with SMTP id c3mr3519698pjn.50.1566541110326; Thu, 22 Aug 2019 23:18:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566541110; cv=none; d=google.com; s=arc-20160816; b=VcCfxMymFvpYaGlY1lZaL/Rmj1+ZaQWFMBi8gCK9PkwQU5lyHUh0sxkLsIQQFK78++ 5YCn7Jrivz4S+aCzHDRjfmCV1LCs0mCW/rPsSacHosuLYRNSmPO5lA8L6iuhaPCQB5z3 dXzDFvybRVkBRcZh8VRkPHgeJXCxLiQJvD9tM1HQ3dRR7kA6qe/MHgYtD8kViwvoHaNw 9vzttGHlTI5Wiw3sQXFhDv7xJc5iFMb2h4uuwnFptp+DvpEG+GhRN4v9DzpoR2nqYzvV osgly3+/8+/zEdOhkpBXpnm03RSvEsvy+zIqeQtftxC7+i7130qnbXh2cun58BsNIRC3 Xupw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mYQrbXxoJd8D89megbA+SOOnvs/O4NdVmx5RAOEhVI0=; b=KGPn9iD/K2s2Qt6l4oq+TXY/eLNfR+oiw9+Ft3XLOws2k5mQIgGb7FkSzBayBQ156d dkWS3v9qKIPX0wNfKREC88i9artFIU2qTb8UesHlRks21PiHo3kaa3Wo9u9mysl8smQu zp+yplMFXLhK9qzaUQ7CH6isbvTHqOOqTp9ZwWA9GqTsvxHXqMR65u1ftSFsX9NIXrQG tR3dKaq0JicCKgrbUdMlkHIB46x+RiyJJCNjfwgCkJSokaaXy3DksM7YyJs/huNO0iou hHATaFq9fsTMUTh1y4nboOVJIl4yYuVKkuSd9brpVFlXuvMmbNGNYd3mO4YIvqpYebiJ eYJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OQ5mGaOu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i18si1717798pfa.23.2019.08.22.23.18.15; Thu, 22 Aug 2019 23:18:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OQ5mGaOu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392565AbfHVRls (ORCPT + 99 others); Thu, 22 Aug 2019 13:41:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:44658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391751AbfHVRXz (ORCPT ); Thu, 22 Aug 2019 13:23:55 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB70C23402; Thu, 22 Aug 2019 17:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494635; bh=Hx/oTr1LiKPxSvknHAXUYWhatBWqSa8VofgNXmS2oX8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OQ5mGaOuiro7kvl4kP08gm/1HHmnc4+B4jzPJ89YXY5zX1PWxOO7yDxIgddEFDthy 55lHPQQC/IhLneIHw5tabM9lYJ+2ok3ptrGLwzjZwVKA52aTCKSjqcpBG4Tqfeqhtf crLyqVYj27+KMAzsBatdtBDWpXsZdobHOwcu9rVI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+3499a83b2d062ae409d4@syzkaller.appspotmail.com, Denis Kirjanov , "David S. Miller" Subject: [PATCH 4.9 067/103] net: usb: pegasus: fix improper read if get_registers() fail Date: Thu, 22 Aug 2019 10:18:55 -0700 Message-Id: <20190822171731.556979488@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171728.445189830@linuxfoundation.org> References: <20190822171728.445189830@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Kirjanov commit 224c04973db1125fcebefffd86115f99f50f8277 upstream. get_registers() may fail with -ENOMEM and in this case we can read a garbage from the status variable tmp. Reported-by: syzbot+3499a83b2d062ae409d4@syzkaller.appspotmail.com Signed-off-by: Denis Kirjanov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/pegasus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -285,7 +285,7 @@ static void mdio_write(struct net_device static int read_eprom_word(pegasus_t *pegasus, __u8 index, __u16 *retdata) { int i; - __u8 tmp; + __u8 tmp = 0; __le16 retdatai; int ret;