Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp274646ybl; Fri, 23 Aug 2019 00:17:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxWnMjRreMNnyhR+g4HmBzJkAnrQ6bn7BKwBj+bEALbNgaKLBgHb9p8NZ4bU3yprV834IW X-Received: by 2002:a65:43c2:: with SMTP id n2mr2745497pgp.110.1566544643176; Fri, 23 Aug 2019 00:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566544643; cv=none; d=google.com; s=arc-20160816; b=FI6htifcZVDSAcLyoP1QGAEzHfGl1DfL3HqQTJK5NPsDo+RNZ71UKxjcGwtlstan2S 90/Vn3ro405VM5u/sTV0L2quKV9r6vmOVwlYnyWSTa0NwXcmnBtYjYcugsD6FjJTUK0J Gh/wSVJfyZ52BxpAIaL1nTbxfUjhXeuX8NrM6rMsN6FO/LrvVrffCMLVUVF+txdPK/R7 FJSnE5vWoJXYkwfabneImhE9vt2kAP8+XqO6lVnrWWqZ6+0hbjyc2th2ot8gL4m7mQiq Tz9n8j4FPLjCNT+2V39sDiVycAfk53DJK8m6BIfjDHYjtoBkpFmreCK/sI04OEElzClk kcpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1zPMvLZjjeedqtoVLYcJ8H3LXTpubsb7g+u61JjqB5E=; b=W/FQnixc2NKM1+1xTRuEfbYH5GnMXz0kZTb2uqSMLw+1kqPysW6ldh+u/yWMGo+smr q6yZHhU26eO06ghuOv+qEAFeUJxge4xS1nUIi+7PtVTwSbeuDZZ/pPAc5M3KEZGdlTz+ WA/B4BLY1AlhdROVoPrM9LHEKM6L1WUtfICPOMC4c7CO0VKWTM+peezjtKTg9T5S8QBK JgMk7tFp6pP8w/FgKWP46zeF8381zOU0X0LX2fA00V+4M9949e4AI0aJBNt56OQT0wlg PpN6NbwyW8NOX/BKxilWFT546sSpRYU4Vc9r74QCaFgvnpalEbLQc90x0rFqtzTJeY/d IBtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q135si1795647pfc.125.2019.08.23.00.17.06; Fri, 23 Aug 2019 00:17:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388918AbfHVSRw (ORCPT + 99 others); Thu, 22 Aug 2019 14:17:52 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:38107 "EHLO mail-wr1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbfHVSRu (ORCPT ); Thu, 22 Aug 2019 14:17:50 -0400 Received: by mail-wr1-f42.google.com with SMTP id g17so6308706wrr.5; Thu, 22 Aug 2019 11:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1zPMvLZjjeedqtoVLYcJ8H3LXTpubsb7g+u61JjqB5E=; b=tGEEY7fUXQ86tpTVa8aYwPlG1uPbjmP/H9phL3cMBS34fkfozabNCwdcQlWbm1ym6q it/ULT+YARnQql/C5X0Ugs2lgT0P6mI8CbQFC4VNhx/XFqAUqIkB0ly6/qcPL+1J08Ls VVijwIhunGruVP1gyFM5dcdOauUVGy5JGGsR5MLv/xe8k/ZArIE2m5qMXIYO3HWtYl/W gyQoLYTUDJkv6mnhiuDkjvyOuXptYYQ3v2Q/qNeklMsDJCRkC1PYK4eewiuhcfzXqJB2 RbpF3gpT2Aq8JzbKqgLW2N8fFAC3hF/4Mv3CmCk5QtILNtrsx/iW7sTk0VHkJ8hWaFMH 6eqg== X-Gm-Message-State: APjAAAXP4N6Di2U/5j0VGEOw4mDNe+o/5tnorP+1takAvUUQ6p8sRM3M 8uozbK5e61Ezj5HhROK/Joc= X-Received: by 2002:adf:ea51:: with SMTP id j17mr339649wrn.184.1566497868440; Thu, 22 Aug 2019 11:17:48 -0700 (PDT) Received: from kozik-lap ([194.230.147.11]) by smtp.googlemail.com with ESMTPSA id a141sm13083871wmd.0.2019.08.22.11.17.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Aug 2019 11:17:47 -0700 (PDT) Date: Thu, 22 Aug 2019 20:17:45 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Cc: jonathanh@nvidia.com, kgene@kernel.org, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, m.szyprowski@samsung.com Subject: Re: [PATCH] soc: samsung: chipid: Remove the regmap lookup error log Message-ID: <20190822181745.GB10900@kozik-lap> References: <20190821150539.31207-1-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190821150539.31207-1-s.nawrocki@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 21, 2019 at 05:05:39PM +0200, Sylwester Nawrocki wrote: > In commit 40d8aff614f7 ("soc: samsung: chipid: Convert exynos-chipid > driver to use the regmap API") of_find_compatible_node() call was > substituted with syscon_regmap_lookup_by_compatible() but also an error > log was added for case where lookup fails. On multiplatform the lookup > will always fail on any non-samsung device so the log is incorrect. > Remove the error log and just return an error code from > syscon_regmap_lookup_by_compatible() which internally calls > of_find_compatible_node(). > > Reported-by: Jon Hunter Thanks, applied. Best regards, Krzysztof