Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp328609ybl; Fri, 23 Aug 2019 01:16:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqyBD/8N216VMU/5qS15l+G8OwySxU5HHNIP2g/OCzkVDpK1ttWa4b+jAvm1yNJEnhpwB+X0 X-Received: by 2002:a63:2364:: with SMTP id u36mr2744588pgm.449.1566548219004; Fri, 23 Aug 2019 01:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566548218; cv=none; d=google.com; s=arc-20160816; b=xwTfPCuq1tiHYq8BL0yFx0xBEyei1pRi5Exfk9XvM0LrEIMq3HE0y5EeWbKrbM/+w0 XLF4AAHY906YAq98WDF2VFS5T2fKqkgcubXCGsbtHgDwAfyqV/hjnTpV4W7/CtNqd1zL ugBaYI2x6osRc5Gt5q6cgDRbNlkJEkH3Ti47FhP6b7B5AmvYOwdYyp5P5yj2qF4s2DSy n5R/ikyZ1fP3wvhL7NX8FXJxErjJqN7uBhGQGA/mFwGZlzajR/4ibDSeKv0KNR6cLS3E WioxOVwxl1VEa4yLct/ZO9mTMnhuD3JpwuqueewOHRuPvQ+46HgWIwYOt2ALzAIj1mvP 2NVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=tVYGZF98cbwCuEnSEO1Hots0hv8R+WSge8zW0ooPbuk=; b=Y5Z9aoekY9sedLTgPtYL7+aJrQUz7B/Gz7xZysD03AXGiXo0rdIYLuPfmWKAnVLYoX dhhjhXI9WR4ACGwtMI7IQvCLZZ8CDRhXEGZnYWMJJm7QNZFeM+ew9fYGJ+b8LiZow6Ys FyBXMtR1p3uZ+LaGPE0lTgvpe02t6EkxMwWIxzslvPIPo8+xEfbVvHVeTaOSFs+3mS5S EnqfkMpCW51JacuYowevXyVn+/MQUvJSoEKNCrocoYx7PTKiHYq5tAtceHLKGjUR0MGg zN6ddnqFurvdGhA1UiFkAhY2I1r8j6ksninCMfU0oJz80kNjlyMbUtg1UR89Wg0gP9re u77Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O8leEuBY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si1762519pls.385.2019.08.23.01.16.43; Fri, 23 Aug 2019 01:16:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O8leEuBY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390106AbfHVVNW (ORCPT + 99 others); Thu, 22 Aug 2019 17:13:22 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44119 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729718AbfHVVNW (ORCPT ); Thu, 22 Aug 2019 17:13:22 -0400 Received: by mail-qt1-f194.google.com with SMTP id 44so9284286qtg.11; Thu, 22 Aug 2019 14:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tVYGZF98cbwCuEnSEO1Hots0hv8R+WSge8zW0ooPbuk=; b=O8leEuBYlqsOe/lClx0gekw2F1TuK5mIxCus51wwMx1g0I4yslglKjMsVWwhuis/R2 xJMkzHGBxGbvSRol1pOgOSxokHmAPmcbghciCuP00mBQxH+wGx7WpjanUSyVWm8PmLdV xBjyd/J3cindAzLQJosmkpaI4erGlBzGELqic9Y/h3slZgHd9wQIqnEFpNZnph2Zb0lW GnZ0zokq71rhJkwSdWfQ5iPkJ+4BDrklRBJG+QQ+VPWPz8HHJWCX/I6XTbvpGbpUpVNd 9nAKzfhvVosDtl3swmpYHHjXAMsFGES6cS/dQLjrnS/xXezmoW8z/axMpJZKsHEuppnt Nvow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tVYGZF98cbwCuEnSEO1Hots0hv8R+WSge8zW0ooPbuk=; b=fmxoB1DbPO4UslUStIGXCeWD8z9kjb6aWnMZUFW0rGuOHHtnl0X3FtV1ane85yb2F9 Gflt4YKtvpjO0cWYcDt5Vk9cef1KTaraQscngo4DQiyLuMp08pE2l8Jb7qqXdSFa4YDj T619QPOaWz8h4Qpo8d+cNauoFbhagQUbe53TgkG7tE4Xvo8TVNzz3ieYiwSTZIUz9Tsg oTL6jt4YaJNG79Yw2J6pIyLWm5hnt2e0ykB2HnaqSon7QIT+MhE8vC4+EAyvLUKTGRgv w+e64h2PcTTwGW2EwTWK7+cF003vfMd6P9idz4llIv3BmWIAZIPCJrLOvFaaFGRhb1n0 dttw== X-Gm-Message-State: APjAAAXvy+atzf16Zk7k2G4avjb7dIeqdCFhW9KfJt17euiKmu6oYJkt c0L/P/N5cMgRKfp96Wh/CtcHxnuIvHdRnn2tzW4= X-Received: by 2002:ac8:358e:: with SMTP id k14mr1675089qtb.83.1566508400887; Thu, 22 Aug 2019 14:13:20 -0700 (PDT) MIME-Version: 1.0 References: <2755f638-7846-91f2-74f4-61031f3e34c8@web.de> In-Reply-To: <2755f638-7846-91f2-74f4-61031f3e34c8@web.de> From: Song Liu Date: Thu, 22 Aug 2019 14:13:10 -0700 Message-ID: Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_net=2Fcore=2Fskmsg=3A_Delete_an_unnecessary_ch?= =?UTF-8?Q?eck_before_the_function_call_=E2=80=9Cconsume=5Fskb=E2=80=9D?= To: Markus Elfring Cc: Networking , bpf , Daniel Borkmann , "David S. Miller" , John Fastabend , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2019 at 10:18 AM Markus Elfring wrote: > > From: Markus Elfring > Date: Thu, 22 Aug 2019 18:00:40 +0200 > > The consume_skb() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Song Liu