Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp329112ybl; Fri, 23 Aug 2019 01:17:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxq2ADwPUCmUG+Qsjte5PMfD8FXVb+Txu5ryelUYj3BoqwiQomJmAtz+JzDXb8WjkFBT3CP X-Received: by 2002:a17:902:1a7:: with SMTP id b36mr3259653plb.115.1566548254187; Fri, 23 Aug 2019 01:17:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566548254; cv=none; d=google.com; s=arc-20160816; b=D8w90+XZQoKNLGKAtz3QQsQDnnGqNaEHvGjtxrPe4iz6Icv/kHs+6YCY1uAIuQND5C akKJ3bkzoxysQaNiWmezTq4Z5RSCsbEb2U27rkBQQz6Ykf6gBfO6DVYM/ZziwPTNo5mP lHRgRUM72DRqxeH4kyEtvjXLOmlR5XKuE9mrgwA1ONH6lE+m8dqoNJuQz8X9bxN0eyQG 9SJO4mCsohhsiBJvAj4pT5YEU0FRizn2QtgNjSdfYphX7P7PzmC/SC+6VQMyeIq7IVn2 E3M+lQpQEsz7hK/IlX5Lt00UrB54AOyo8Ldwmn+pyH6D6yguedziAjCZUEY/fim3Q5ep IIaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=orPyMCzXeHsYXHUl5miKDkVoD0ryzkBoiARAwCBXnx0=; b=L9LtVPmtx/IRSdoKk4Jv1BibIknPS4T+aL/7ESZTZEp6zgnd70pVVktUV+yI95Azt+ hU8mD5bobLg6LzU6QL7Q/jHd3xxYdQ4lqSne0Iq+fmuE59skm43b/q2Dly9o0qHlO2lY EPsglwrWtw0UDp82B2bQEGHb3urQ06Ze2EPaV6UqSfGTgto60OxD+AYMSFT4y8nRejRZ TxN2y9a/Lqb24jesxt4h1INeR27yuB/oXaxj8dVXkLvKqTkH1p0/17SJqompbkahlkJI Q32PsoRPtVTzCUZOlaUZZ6jCoVKrSiIFfh2kuTvj73pP+BYwjIQAzNtpYJhoippruHN/ lkQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AnjVGBlL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j17si1888890pfn.278.2019.08.23.01.17.18; Fri, 23 Aug 2019 01:17:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AnjVGBlL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389835AbfHVVMb (ORCPT + 99 others); Thu, 22 Aug 2019 17:12:31 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46496 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729718AbfHVVMb (ORCPT ); Thu, 22 Aug 2019 17:12:31 -0400 Received: by mail-qt1-f195.google.com with SMTP id j15so9259154qtl.13; Thu, 22 Aug 2019 14:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=orPyMCzXeHsYXHUl5miKDkVoD0ryzkBoiARAwCBXnx0=; b=AnjVGBlLdnEch8CV/RolTNuqf/mXbgnvEhoD1RyozoQ+TLSXEFbbgGhKiKIb49NZNS QvxnXb2JQDURKL7H/ZoGJiFYJpKz2k8E3FQwn1CP/SPyGothGlTsG0/iMgLrM4NtVQf3 fqgaBonqDMjvcwW2WL5SwlqWOOJjpfBm34EiX8WAI9g9gxg+GxvqWfulpmabb7N+JgSb Wl+4tUiJhEFARMQ2w6VPQO/bBg9BKvB9BUNM/E4ie/R+4r3pOrte/AWOdU/VxcA8WgSb iw3WW1yUkrBCFnTLntYMUUYLnzDBF5adjfAduDm1ihOFtxK8ve7WoxFCAziAtEKrAHho x1DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=orPyMCzXeHsYXHUl5miKDkVoD0ryzkBoiARAwCBXnx0=; b=roJaqHlhqgyIFJmhJo9weKw78oD3/6dcvl9TRgBMuSf7oKGxqpa+XI7759lgG9WgX+ cRNsOTEvPLlQBExmER2LRxpg3nrrasx+g3m20AIR8eAGRmTK9hSDQkXJbLToIV81w6nd U/ec+cZF33qcgMWQ8sX46Im1VU/ndARwy4SsCoi6qw1Pu2x0I+Ykjni3O0isIYY98SS/ 76qwYjfcjKb1Y1R9IB78MqTimte+GBCqXpYegwyyZy94Ek4+k6p4aIYdEpEqiwvtvqcR 6z4qCy8qvRqzZJsd2e/ufCYTIlH6vTGF1cI8LD2o9g0oi1vqzpSB6URa+NkWk0QydBy1 CKlw== X-Gm-Message-State: APjAAAVOgJpS3aPo/RsIUoI8nvs4r3PIVGh+xHyJUYed0BUgdod4oULL BQRGCkpSApTuI6Hr5hzvcba0hyJn8ZrjGDC9neE= X-Received: by 2002:a05:6214:13a1:: with SMTP id h1mr1319454qvz.190.1566508349936; Thu, 22 Aug 2019 14:12:29 -0700 (PDT) MIME-Version: 1.0 References: <25ca9c48-1ac9-daa1-8472-0a53e4beed6a@web.de> In-Reply-To: <25ca9c48-1ac9-daa1-8472-0a53e4beed6a@web.de> From: Song Liu Date: Thu, 22 Aug 2019 14:12:19 -0700 Message-ID: Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_net=2Fipv4=2Ftcp=5Fbpf=3A_Delete_an_unnecessary_?= =?UTF-8?Q?check_before_the_function_call_=E2=80=9Cconsume=5Fskb=E2=80=9D?= To: Markus Elfring Cc: Networking , bpf , Alexei Starovoitov , Alexey Kuznetsov , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Hideaki Yoshifuji , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2019 at 10:19 AM Markus Elfring wrote: > > From: Markus Elfring > Date: Thu, 22 Aug 2019 18:20:42 +0200 > > The consume_skb() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Song Liu