Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp362643ybl; Fri, 23 Aug 2019 01:56:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyB9GjZmUKs/YlzuUr7lshHkd9+RkNiyusqs6nf7qgd3XyJHj/3WBIeb0+ByOV57uVMZ4eT X-Received: by 2002:a05:6a00:c7:: with SMTP id e7mr3979569pfj.52.1566550585679; Fri, 23 Aug 2019 01:56:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566550585; cv=none; d=google.com; s=arc-20160816; b=XS2/P/Spy+peVGYDSShiLvs3OawuiT9s1gtqgT04GOyVI6Vd8+2ZJJNIt03JmSB/js CsKcoMxG+Opda95uDKp2vXirq17E2qxqKeaDDBN+m7zejiXtYp2UK7hstEJ2/OyPQ5+/ KV6yVfRQGdSD9onAiaw0igy5VJPMX7A5n4LvrWWiret/gs8sSNGuHqQivmL6dYNoDJdM Jcc3xU7pHXNPjbWE1tY0ppg5qwyroccrLt9EPhqO0qm4MVRe/N9cCtvmPFvV5n6EmJ56 LrQln/AyLFTRciZZ3DeNOG/nukQ3+N6rXLF0Eg2IEEn2IqXSg9Unv0uHXe+oj/TFOp7+ j5zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=33osEaEY4Fyytc30LBWwLNpvpeEwPbZWxdv3Uzt3FYw=; b=yuJDMCE1ggQHx2lkNYDbWY34rjcDDlQRGLon8KiKCsXoZwx2cyIlso0kRoIYPuaj2P aZeyJ+GxWD24YzQQRAsMBRdZuYM1VHRKbojKr/96W9+Q6Yf2MMmzh2FJ0yT8HN+PCSSe zvaubyCZkWiJTOVY+GvgYVe3z9iYhqCbbrHwXWivwY/ptrPnMCnAK9O7C0gIq7JNvyoe NOIZsj3bfum7K0kN8aoRqfG39l7OFheXIClzwmN3Q4hXGhLUiBJOUDh92QeEFXzGEKEE 1k04n1P/EjSUjjuR4U1L999GCl6CrcypzKO+NIqoTsj64jvtDZIygc3pnzywKaIgmL5Q +avQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i15si1981197pfd.259.2019.08.23.01.56.09; Fri, 23 Aug 2019 01:56:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394247AbfHVXLs (ORCPT + 99 others); Thu, 22 Aug 2019 19:11:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50352 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732372AbfHVXLr (ORCPT ); Thu, 22 Aug 2019 19:11:47 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5E12A1539AF01; Thu, 22 Aug 2019 16:11:47 -0700 (PDT) Date: Thu, 22 Aug 2019 16:11:47 -0700 (PDT) Message-Id: <20190822.161147.1083816539940454278.davem@davemloft.net> To: wenwen@cs.uga.edu Cc: skalluru@marvell.com, aelior@marvell.com, GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] qed: Add cleanup in qed_slowpath_start() From: David Miller In-Reply-To: <1566362796-5399-1-git-send-email-wenwen@cs.uga.edu> References: <1566362796-5399-1-git-send-email-wenwen@cs.uga.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Aug 2019 16:11:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenwen Wang Date: Tue, 20 Aug 2019 23:46:36 -0500 > If qed_mcp_send_drv_version() fails, no cleanup is executed, leading to > memory leaks. To fix this issue, introduce the label 'err4' to perform the > cleanup work before returning the error. > > Signed-off-by: Wenwen Wang Applied.