Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp364746ybl; Fri, 23 Aug 2019 01:59:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqwk+EpUiAmL/XenOPw/ud04Uz9xMT8E9tNx2eLWdPINGjAm+1pXTffj2H4rJztM8l7uETLK X-Received: by 2002:a17:90b:289:: with SMTP id az9mr4154905pjb.5.1566550756241; Fri, 23 Aug 2019 01:59:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566550756; cv=none; d=google.com; s=arc-20160816; b=v1p+zavPQMz9pYizXGCmJZNhDvxJu/c05X1i3+x80LoajQLZjNtkhFEWG+eNnvuNK+ iLbqUIZO5gB/pN7vbzy4DAHuKRHpsY5oVzrk6jYuqY5oh0SWKI9hPMMOd4sw8T5zFkml v45tEtCl0vF4LaQsEA6Et65RpYUUwkOOMTV5Crwbm7ZZPq25e/EKjrOtHyYuYAlIZ6+o gPzJgS7oirKXEJ7zM1f+d7fzkArETMawrScS1t0dgkG2rzPCqr3ztFZNR5nzEl/a/8ct Q3xo4MzSivlSWclooYcAQPW1q9I4ADdI1wR1h6mZgIfqkzSI5DRoNcq0OjLxHqPrG2BP iUXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=HT+G8mgQ3C2WKf9/Qwsma0vIDbgx6/RaFE9tc302ftk=; b=F0qGPSu1s2tJAAOtHYC/KiKA0Rrp501exLLYw6y48LlVQQ9mcMbZD0ylzZ6MqExB+K mLvsO2qsqv5E1msxKA6k/8w7DlXPj40nn5PuL8JkAORlkDKI/x4cHRScNcOwy9hpFkWU GKLkovQn/4xm/PoJwvLUEFoHSkpxixW6/mrMueX5Zgzs6rxjrRnfQyX1D3ZQP0bGH0p6 RPptXdlfvre/TtC5kKxXgT0reTytx9dqdWL0SufkZbrbsQSVaE6xy/Q2EIFWfYIqYG4r W3vZ1YD8HeoEuJ+H8sSVDLFoKeOp9bvZFwvrc2mZbv5WxNXFVbn25Kx233aMn4XaHfCi V5Dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r23si1499233pgv.451.2019.08.23.01.59.00; Fri, 23 Aug 2019 01:59:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389598AbfHVXXQ (ORCPT + 99 others); Thu, 22 Aug 2019 19:23:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50512 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394362AbfHVXXM (ORCPT ); Thu, 22 Aug 2019 19:23:12 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E1BAF1539D836; Thu, 22 Aug 2019 16:23:10 -0700 (PDT) Date: Thu, 22 Aug 2019 16:23:10 -0700 (PDT) Message-Id: <20190822.162310.1544602687585865172.davem@davemloft.net> To: Markus.Elfring@web.de Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, allison@lohutok.net, lkml@metux.net, gregkh@linuxfoundation.org, gustavo@embeddedor.com, lukas@wunner.de, mkl@pengutronix.de, sean@geanix.com, tglx@linutronix.de, houweitaoo@gmail.com, wg@grandegger.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] can: Delete unnecessary checks before the macro call =?iso-2022-jp?B?GyRCIUgbKEJkZXZfa2ZyZWVfc2tiGyRCIUkbKEI=?= From: David Miller In-Reply-To: <27674907-fd2a-7f0c-84fd-d8b5124739a9@web.de> References: <27674907-fd2a-7f0c-84fd-d8b5124739a9@web.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 22 Aug 2019 16:23:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 21 Aug 2019 21:30:11 +0200 > From: Markus Elfring > Date: Wed, 21 Aug 2019 21:16:15 +0200 > > The dev_kfree_skb() function performs also input parameter validation. > Thus the test around the shown calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.