Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 22 Aug 2019 17:24:44 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Christoph Hellwig <hch@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        =?iso-8859-1?B?Suly9G1l?= Glisse <jglisse@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 0/3] mm/gup: introduce vaddr_pin_pages_remote(),
 FOLL_PIN
Message-ID: <20190823002443.GA19517@iweiny-DESK2.sc.intel.com>
References: <20190821040727.19650-1-jhubbard@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190821040727.19650-1-jhubbard@nvidia.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 20, 2019 at 09:07:24PM -0700, John Hubbard wrote:
> Hi Ira,
> 
> This is for your tree. I'm dropping the RFC because this aspect is
> starting to firm up pretty well.
> 
> I've moved FOLL_PIN inside the vaddr_pin_*() routines, and moved
> FOLL_LONGTERM outside, based on our recent discussions. This is
> documented pretty well within the patches.
> 
> Note that there are a lot of references in comments and commit
> logs, to vaddr_pin_pages(). We'll want to catch all of those if
> we rename that. I am pushing pretty hard to rename it to
> vaddr_pin_user_pages().
> 
> v1 of this may be found here:
> https://lore.kernel.org/r/20190812015044.26176-1-jhubbard@nvidia.com

I am really sorry about this...

I think it is fine to pull these in...  There are some nits which are wrong but
I think with the XDP complication and Daves' objection I think the vaddr_pin
information is going to need reworking.  So the documentation there is probably
wrong.  But until we know what it is going to be we should just take this.

Do you have a branch with this on it?

The patches don't seem to apply.  Looks like they got corrupted somewhere...

:-/

Thanks,
Ira

> 
> John Hubbard (3):
>   For Ira: tiny formatting tweak to kerneldoc
>   mm/gup: introduce FOLL_PIN flag for get_user_pages()
>   mm/gup: introduce vaddr_pin_pages_remote(), and invoke it
> 
>  drivers/infiniband/core/umem.c |  1 +
>  include/linux/mm.h             | 61 ++++++++++++++++++++++++++++++----
>  mm/gup.c                       | 40 ++++++++++++++++++++--
>  mm/process_vm_access.c         | 23 +++++++------
>  4 files changed, 106 insertions(+), 19 deletions(-)
> 
> -- 
> 2.22.1
> 
>