Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp423573ybl; Fri, 23 Aug 2019 03:00:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/yLslM6Bw4iI7EC9FCvBEOcXHE3Ds40e+DOM1OX8nlhQkmlV59Nrc28g1R/6OzuwZbpPj X-Received: by 2002:a17:90a:ab01:: with SMTP id m1mr4139240pjq.69.1566554442170; Fri, 23 Aug 2019 03:00:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566554442; cv=none; d=google.com; s=arc-20160816; b=UoMHpHxzY62QYkWio/te4gcXxwhMS1Mkl1UGit9A9COpIxLi7LBEHqr2GfCm7fgWkY Tl522sL8qGPNBLPzleMPMO6EtzdnaOcbwRg7PIE8ekYv3NEx0VDxy94dA6Q5QkklOW3C Rm/0zq+xPvkKBdOz6SxsUTIaA6ACf/ncYiPxEuNQLNgeUfN4ccjpTkDm0RjiM+5X37Na /DXCAc6Vp5YrNG7tbTTEn1dnafRj+feMwNQHowsvLYGpuusqnNMEQZ3SBLsFDObtJlRC S8Tyeb3eh9aJ/MH59BVz/c7nMdn5NsBS/HRJvsMj3GF4kbZoa+g5aRIPaM1VS2JLMrEw RYHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0jZOuGomjvqGYTjnoHRQnEezUC30S/yYktb2hSFP7WE=; b=uw2+8waiyihqRa5nYby4yzdmzmUx+LTvMqyu7Bm2kkWyeUm1vOINtnf4SKXND/M3yi Ht/pBY+aqjbEpgNDnUOEaIKxJ65s/tVIwce3p9XbPcU8FsRFTkmPIvMlh4knxWZYqWpa KCYXtMHjp0P2aXuOA84VX0DvQw0jDqtUnmZVoatSG74WW5stEEI0IHlgTyP/zzJWiHo5 sHFStZn45nRaDzF3Bjh3UWwTpNzySc8W+zbIaDSXF12iwm2aIcJ82Bkil6Tl6xJ4kV1k 0IDl6BPRfS0NAW1zfbMfD6tARKJ0K/0PAFDEByiD7DaPNVLd3VI7GN+fuZIxvq+LKLUF MIEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZsZhZA5t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5si2041999pln.274.2019.08.23.03.00.26; Fri, 23 Aug 2019 03:00:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZsZhZA5t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392076AbfHWF2u (ORCPT + 99 others); Fri, 23 Aug 2019 01:28:50 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42517 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392067AbfHWF2t (ORCPT ); Fri, 23 Aug 2019 01:28:49 -0400 Received: by mail-wr1-f66.google.com with SMTP id b16so7402376wrq.9 for ; Thu, 22 Aug 2019 22:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0jZOuGomjvqGYTjnoHRQnEezUC30S/yYktb2hSFP7WE=; b=ZsZhZA5toWhhCMR8ORZnkeX18nS/RQ2ih4MGR5PbRXW4fGxvgYg41L5YkbhqfuMXAg mkAKeh3DAtZHZr2Hy8m1ZZEyMd0RYkpIVNOinUsUm9LSyeaZL5xjE5mDmFb6hBOgPoP4 x3XX/VTD9ZCimPxO3iHOWmMSWKM9ozmfQpa5ODTu03PSPfBQAxVrqHRR4i7tCTvrEuvD 8S4CM2B8GSezAVMEVwuJrKF8O2JJxynlNW2q3whLIqL8iKIymONrlRfa354T15nmpb9t YQQLUdqtjyw97shJg5StkamMN1OCVetEtqsQEjw5m9+DxyojtsUay/oeJ2Pz6F1jVb2r 84zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0jZOuGomjvqGYTjnoHRQnEezUC30S/yYktb2hSFP7WE=; b=EaNhgp6+IoX2Vg1t6sojoi6pbuwORAKl7ucg+2X30DkOK9nayDi6bIwWbtXBDNZCtr xwc9+NZ/EbcBSTdKxMTyI9mwtmU30US/ey2fz+n4ZJIIx6dhu1swjAPZc9vkGdjBHJbn za/to6yJ82IzBoE4SwSUM5k4lp9oWd4EtntJkBcvEL5iPkNcFD+RGTsHkU7x0VK5h6br omIIrL0t1XXTSP6TBJLZFT0z/4q++VtzZYzSzWB3OxM2G5BVkyiOBWymvVyu4a69Vpl3 gE41IeFXaMd7nkmXRUjhiSCRqYPsl3aYwsDVWyOM4N68Ge7HXeW3Fw5vydMPVFPy7D7U Ivyg== X-Gm-Message-State: APjAAAXZeOk5c7QoDogESwCJpVCSHbHRt6/VNjCrqXIQsjKOKP6yO370 u6ktUwd4eHLy9L7gS7nqKs0= X-Received: by 2002:a5d:50cb:: with SMTP id f11mr2663367wrt.277.1566538127201; Thu, 22 Aug 2019 22:28:47 -0700 (PDT) Received: from archlinux-threadripper ([2a01:4f8:222:2f1b::2]) by smtp.gmail.com with ESMTPSA id w5sm2377262wmm.43.2019.08.22.22.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2019 22:28:46 -0700 (PDT) Date: Thu, 22 Aug 2019 22:28:44 -0700 From: Nathan Chancellor To: Nick Desaulniers Cc: Nathan Huckleberry , Russell King , Linux ARM , LKML , clang-built-linux , Miles Chen =?utf-8?B?KOmZs+awkeaouik=?= , Tri Vo Subject: Re: [PATCH v3] ARM: UNWINDER_FRAME_POINTER implementation for Clang Message-ID: <20190823052844.GA70417@archlinux-threadripper> References: <20190822183022.130790-1-nhuck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2019 at 01:02:05PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > On Thu, Aug 22, 2019 at 11:30 AM Nathan Huckleberry wrote: > > > > The stackframe setup when compiled with clang is different. > > Since the stack unwinder expects the gcc stackframe setup it > > fails to print backtraces. This patch adds support for the > > clang stackframe setup. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/35 > > Cc: clang-built-linux@googlegroups.com > > Suggested-by: Tri Vo > > Signed-off-by: Nathan Huckleberry > > Tested-by: Nick Desaulniers > > Great, thanks for following up on the suggestions from code review. > Since this is going to go up via the arm tree, which has its own > process, please add my: > Reviewed-by: Nick Desaulniers > to the commit message, then submit the patch to the maintainer's patch > tracking system: > https://www.armlinux.org.uk/developer/patches/info.php > (create a login, sign in, then visit: > https://www.armlinux.org.uk/developer/patches/add.php . I think the > correct thing is to put the first line of the commit in the summary > field, next/master as the kernel version (I applied/tested off of > -next), then the rest of the commit message body in the Patch Notes > field. Make sure to attach the patch file. Finally, it should appear > at https://www.armlinux.org.uk/developer/patches/section.php?section=0 > I think within 24hrs). Also for the record, I came across this a couple of months ago, Catalin Marinas had a git config alias that could be used for sending one patch to the patches email address so that you don't have to muck around the web interface: https://lore.kernel.org/lkml/20190624144924.GE29120@arrakis.emea.arm.com/ Web interface works fine but I prefer everything via the command line :) Cheers, Nathan