Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp439443ybl; Fri, 23 Aug 2019 03:13:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFAxU/HBBDfo8Lg37P9Y133nrkpEqGEVk0C8v7a2/xiKCuzG8RVYvLbjyVN+6nHbzj4ADl X-Received: by 2002:a63:6686:: with SMTP id a128mr3201288pgc.361.1566555222196; Fri, 23 Aug 2019 03:13:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566555222; cv=none; d=google.com; s=arc-20160816; b=OSG9sgHFxRQTF8lssN5wyPOJb/oRfdQcsYlaumsE/sDp6hJW24IFLzSHTlTa0ayVec iprPkF2s95aPkEJMqLvCCwNbR6rP1cwu7z942MdfBmlezfteDM7q7wtzYPTZNOw7i5r5 sscFPJE37sCj4IElroUO+T0NepIIFC3jEC5N5fqX++RCPHG5fM1s4J64eyBEZd0EHQZT itT1E1XnB9uDiNv0axzz7b0dycoDq0QECJaLZLf7H6fleBnQ0WeIQgc0OWfUIT/n7zpC 4imge32BsfMCurFAqmkrY7P8hTb4MB7sAw15VfhIYwQJxWG8a2g8G0SkFOLT6MpKWF7s QvTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lx6IeNTEfqJ26mnJ/uVfPNg6tsbVUMgnWx46wF6WE4o=; b=Bgp3x5HZgoGxm403xDGGsijO61BtiG6Rq/jXnlqz3C61no7Gb3hr7QvYMLl7khvNmz afIJbvkaEwxKWMhAlUR4lSjWeQ1baTA6DJo5ySSX+rcpCI00Q2Dh+UWTDdV25Dvt4KWK ZReIZtJZLFkB9Rtm8qYxab/t0FL/bvqWTQLwWv0PlXS5jAZzC4U7DQ8W4wj/kAHTqwe+ acR4uwPOb5UxTC2P7qZQzBDTg9/T8XCB55OJHY/HXCcidrW4Eia8sPjL3yOdZi0FQ8uM lQfFTy2ry1aJjyfE/VY3U8kZdA7k7HvVONUsdgYk6rZdxQBRB+v/zx/5aTOKq1DAhjxC ygDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si1684056pgb.595.2019.08.23.03.13.26; Fri, 23 Aug 2019 03:13:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390347AbfHWHKn (ORCPT + 99 others); Fri, 23 Aug 2019 03:10:43 -0400 Received: from mga06.intel.com ([134.134.136.31]:6425 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728332AbfHWHKn (ORCPT ); Fri, 23 Aug 2019 03:10:43 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 00:10:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,420,1559545200"; d="scan'208";a="196419917" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 23 Aug 2019 00:10:38 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 23 Aug 2019 10:10:37 +0300 Date: Fri, 23 Aug 2019 10:10:37 +0300 From: Mika Westerberg To: Matthias Andree Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , Lukas Wunner , Keith Busch , Alex Williamson , Alexandru Gagniuc , Kai-Heng Feng , Paul Menzel , Nicholas Johnson , Justin Forbes , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: Add missing link delays required by the PCIe spec Message-ID: <20190823071037.GP19908@lahna.fi.intel.com> References: <20190821124519.71594-1-mika.westerberg@linux.intel.com> <9f741e3a-0878-b914-39d8-a64a02484cb5@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f741e3a-0878-b914-39d8-a64a02484cb5@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2019 at 08:29:09PM +0200, Matthias Andree wrote: > Am 21.08.19 um 14:45 schrieb Mika Westerberg: > > Hi all, > > > > As the changelog says this is reworked version that tries to avoid reported > > issues while at the same time fix the missing delays so we can get ICL > > systems and at least the one system with Titan Ridge controller working > > properly. > > > > @Matthias, @Paul and @Nicholas: it would be great if you could try the > > patch on top of v5.4-rc5+ and verify that it does not cause any issues on > > your systems. > > > > drivers/pci/pci-driver.c | 19 ++++++ > > drivers/pci/pci.c | 127 ++++++++++++++++++++++++++++++++++++--- > > drivers/pci/pci.h | 1 + > > 3 files changed, 137 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c > > index a8124e47bf6e..9aec78ed8907 100644 > > ... > > Mika, Bjorn, Rafael, > > quick smoke test, this test applied with git-am on top > v5.3-rc5-149-gbb7ba8069de9, reboot, suspend, wake, suspend, wake, > hibernate, wake, looks good to me. The top of git log --pretty-short is > shown below. Thanks for testing! > Couldn't test on v5.4-rc5 though as I've handed off my time machine for > repairs, > I seem to recall they said something about the flux compensator. :)