Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dragan Cvetic <draganc@xilinx.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Derek Kiernan <dkiernan@xilinx.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michal Simek <michals@xilinx.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information
 leaks
Thread-Topic: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information
 leaks
Thread-Index: AQHVV+76IySGJCWDyUaqUkp57fbBeqcHcz0A
Date:   Thu, 22 Aug 2019 17:47:15 +0000
Message-ID: <CH2PR02MB63599214D1FC937E256FCBC4CBA50@CH2PR02MB6359.namprd02.prod.outlook.com>
References: <20190821070606.GA26957@mwanda>
In-Reply-To: <20190821070606.GA26957@mwanda>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a2c1b4d6-1523-4bc0-629b-08d72728c55f
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2019 17:47:15.8982
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MSc6oXetkG+P6R1fVG+GeBl4YnNdUcju01zgYkLCNwChSYPv4xjjqx+mt4E/vJZavDT/+o0OeDSOlK8b+BEr1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6789
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Wednesday 21 August 2019 08:06
> To: Derek Kiernan <dkiernan@xilinx.com>; Dragan Cvetic <draganc@xilinx.co=
m>
> Cc: Arnd Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfounda=
tion.org>; Michal Simek <michals@xilinx.com>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; kerne=
l-janitors@vger.kernel.org
> Subject: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information l=
eaks
>=20
> These structs have holes in them so we end up disclosing a few bytes of
> uninitialized stack data.
>=20
> drivers/misc/xilinx_sdfec.c:305 xsdfec_get_status() warn: check that 'sta=
tus' doesn't leak information (struct has a hole after 'activity')
> drivers/misc/xilinx_sdfec.c:449 xsdfec_get_turbo() warn: check that 'turb=
o_params' doesn't leak information (struct has a hole after
> 'scale')
>=20
> We need to zero out the holes with memset().
>=20
> Fixes: 6bd6a690c2e7 ("misc: xilinx_sdfec: Add stats & status ioctls")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/misc/xilinx_sdfec.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 912e939dec62..dc1b8b412712 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -295,6 +295,7 @@ static int xsdfec_get_status(struct xsdfec_dev *xsdfe=
c, void __user *arg)
>  	struct xsdfec_status status;
>  	int err;
>=20
> +	memset(&status, 0, sizeof(status));
>  	spin_lock_irqsave(&xsdfec->error_data_lock, xsdfec->flags);
>  	status.state =3D xsdfec->state;
>  	xsdfec->state_updated =3D false;
> @@ -440,6 +441,7 @@ static int xsdfec_get_turbo(struct xsdfec_dev *xsdfec=
, void __user *arg)
>  	if (xsdfec->config.code =3D=3D XSDFEC_LDPC_CODE)
>  		return -EIO;
>=20
> +	memset(&turbo_params, 0, sizeof(turbo_params));
>  	reg_value =3D xsdfec_regread(xsdfec, XSDFEC_TURBO_ADDR);
>=20
>  	turbo_params.scale =3D (reg_value & XSDFEC_TURBO_SCALE_MASK) >>
> --
> 2.20.1

Reviewed-by: Dragan Cvetic <dragan.cvetic@xilinx.com>

Thanks,
Dragan