Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp582924ybl; Fri, 23 Aug 2019 05:30:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzO3N7QWc2DUJyn07vczIw2nX4qQ3Hpzgx+eukZmCQcsGA8izAR1scMLmTIVaxjiIMVjltO X-Received: by 2002:a17:902:ac86:: with SMTP id h6mr4571315plr.79.1566563421627; Fri, 23 Aug 2019 05:30:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566563421; cv=none; d=google.com; s=arc-20160816; b=Gqua5I5KAd37WRv61X0gnAM2/ZwB7g4/1RympQUfgKxuj+MqOS7FKbaBDp50Qgse5J QckxZjJCzjzS3qNCE6J/zbOO3ia6MOQEKANPPvViL+FxcfUJpjfVMpTQRWd1TtZQGfIU ylescpKjJLZLLGHDx/gddbY36Utw70FD/NKHJr3a0HJ0MZept3EXv2+LlhGl+XhNomEp i7WCKZ7Yh6892NVKJBtVmeBpqlq/sGSc1L84IrubRLAtWLyrxg1fz/MH5vV600hWc/2u TwKt8XTFzIgnZlREWdq3kzov9o+l3d+qbxVorU10J/7WwBxGDq550uPKa5RX1m1k0/Zv zKBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ouh1hyA4cnUUtU66BbaszA14lgEbgI+hW7TPxZskfjA=; b=YoY3t7RO1g2icsbwyEzSDIVN4T45hwPvvsNZr4JYzckrrBGFRtIqUPlMW7WUUV1aqi abr3xtoQSJd2y2ig377aOKq/eoPNRf9utU36B3xypiNxQLZFo1EjdW7PagYH+8kqGt6U xm21c9fhspRVFDOTn6vLm9xG2hOBdvfxqM6Usmi9w6jB/KVXoQX2b1JG/vqpP4kU3Okj gZCWH4uD66dvoa24i/F49HCIE+ablzFxApMMZT2PYtAtmRo41Shem8Jr69eMp0ycdU6b 0U/z8OAucRfCbf+0yjDf4eO3icSLBbAsXqYEkdm5MlBN8Ew2Gn2wJh5s+9HYDw65V2/l n58g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=2YBLfaiS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si1890988pgq.119.2019.08.23.05.29.51; Fri, 23 Aug 2019 05:30:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=2YBLfaiS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392689AbfHVUI0 (ORCPT + 99 others); Thu, 22 Aug 2019 16:08:26 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52874 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731461AbfHVUIZ (ORCPT ); Thu, 22 Aug 2019 16:08:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ouh1hyA4cnUUtU66BbaszA14lgEbgI+hW7TPxZskfjA=; b=2YBLfaiSJjF9YvxwEJ63tFNfLf NgaAM1cajy0G+MKXV0ek0VyWAA2A2jdYFKagzeAznZj+f1uhGOamR9xPHUmjNRKRI4NEn774Y6oog pQlCVkQA/uY9HkHC7rtBXUbBi13ZDESxVdM4S/9OOKhAMjzpFLWZeDaaKqoJ3UxH5oH4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i0tNZ-0007Bu-Ol; Thu, 22 Aug 2019 22:08:17 +0200 Date: Thu, 22 Aug 2019 22:08:17 +0200 From: Andrew Lunn To: Horatiu Vultur Cc: roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, davem@davemloft.net, UNGLinuxDriver@microchip.com, alexandre.belloni@bootlin.com, allan.nielsen@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH 1/3] net: Add HW_BRIDGE offload feature Message-ID: <20190822200817.GD21295@lunn.ch> References: <1566500850-6247-1-git-send-email-horatiu.vultur@microchip.com> <1566500850-6247-2-git-send-email-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566500850-6247-2-git-send-email-horatiu.vultur@microchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +/* Determin if the SW bridge can be offloaded to HW. Return true if all > + * the interfaces of the bridge have the feature NETIF_F_HW_SWITCHDEV set > + * and have the same netdev_ops. > + */ Hi Horatiu Why do you need these restrictions. The HW bridge should be able to learn that a destination MAC address can be reached via the SW bridge. The software bridge can then forward it out the correct interface. Or are you saying your hardware cannot learn from frames which come from the CPU? Andrew