Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 23 Aug 2019 11:41:08 +0100
From:   Mark Rutland <mark.rutland@arm.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org,
        Alexander Potapenko <glider@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCHv2] lib/test_kasan: add roundtrip tests
Message-ID: <20190823104107.GA55480@lakrids.cambridge.arm.com>
References: <20190819161449.30248-1-mark.rutland@arm.com>
 <20190822164857.460353a8195bfd5ddb3d5f50@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190822164857.460353a8195bfd5ddb3d5f50@linux-foundation.org>
User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andrew,

On Thu, Aug 22, 2019 at 04:48:57PM -0700, Andrew Morton wrote:
> On Mon, 19 Aug 2019 17:14:49 +0100 Mark Rutland <mark.rutland@arm.com> wrote:
> 
> > In several places we need to be able to operate on pointers which have
> > gone via a roundtrip:
> > 
> > 	virt -> {phys,page} -> virt
> > 
> > With KASAN_SW_TAGS, we can't preserve the tag for SLUB objects, and the
> > {phys,page} -> virt conversion will use KASAN_TAG_KERNEL.
> > 
> > This patch adds tests to ensure that this works as expected, without
> > false positives which have recently been spotted [1,2] in testing.
> > 
> > [1] https://lore.kernel.org/linux-arm-kernel/20190819114420.2535-1-walter-zh.wu@mediatek.com/
> > [2] https://lore.kernel.org/linux-arm-kernel/20190819132347.GB9927@lakrids.cambridge.arm.com/
> > 
> >
> > ...
> >
> 
> The only change I'm seeing from v1 is:
> 
> --- a/lib/test_kasan.c~lib-test_kasan-add-roundtrip-tests-v2
> +++ a/lib/test_kasan.c
> @@ -19,7 +19,6 @@
>  #include <linux/string.h>
>  #include <linux/uaccess.h>
>  
> -#include <asm/io.h>
>  #include <asm/page.h>

I think you've confused v1 with v3 (which was the first version to
include <asm/io.h>).

v1: https://lore.kernel.org/linux-arm-kernel/20190819150341.GC9927@lakrids.cambridge.arm.com/
v3: https://lore.kernel.org/linux-arm-kernel/20190819150341.GC9927@lakrids.cambridge.arm.com/

I guess as v1 was part of a reply (without the mail subject matching)
that might have confused things? Sorry about that if so!

>  
>  /*
> 
> which is really kinda wrong.  We should strictly include linux/io.h for
> things like virt_to_phys().
> 
> So I think I'll stick with v1 plus my fixlet:
> 
> --- a/lib/test_kasan.c~lib-test_kasan-add-roundtrip-tests-checkpatch-fixes
> +++ a/lib/test_kasan.c
> @@ -18,8 +18,8 @@
>  #include <linux/slab.h>
>  #include <linux/string.h>
>  #include <linux/uaccess.h>
> +#include <linux/io.h>
>  
> -#include <asm/io.h>
>  #include <asm/page.h>
>  
>  /*
> 

Assuming that you mean *v3* with that fix, that looks good to me!

Thanks,
Mark.