Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1262794ybl; Fri, 23 Aug 2019 16:27:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqyTjMZzJEm7NllCXih02IVj6Hw2qms9ohEqAGLXj89uTdoPVlVBdXZqsgeWiPEtz++PiJPA X-Received: by 2002:a17:90a:e38e:: with SMTP id b14mr7683246pjz.125.1566602869160; Fri, 23 Aug 2019 16:27:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566602869; cv=none; d=google.com; s=arc-20160816; b=WzzZ3dus8eEef0Cviesc2Odx4fjw5gQ8QOLHAh+Y+exE6Lfn6o7XYGh/+ViC7zeFIZ iSFQTCZbyfuoW0M2/1ZlBw1q0DcLBbOhWbZGTTAH7oDpap6jS128ti8yMiPD7Mkfiefr wtgZCCHLzIZE2xQbzTHZd+Lpd1zk1NvISgOJ7mUDO7LT7SmgsqyRd7F1A5RWp79TX7yy eC/SsXil0YMYC97cp2wlkCbraPbtwKY/RmXSGXW7TZFtN0ntQoZBQXm1PgPJuW0FKAvF TQIQFMo+Y7VNf3gfCnPWPFgAjksDkKaP2BuEtSWUvVcwDnjhVPFNpqfPfG41IPGFdAht r9SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sHvSmoSmDvSNNSbRGXLQshanw3+uRXJ2ONHrn0tkDQw=; b=nT2Iq05WJ8IPCVfSnLQfQioBnzID6tWNwWWtSNCaU5NrzeoUZDcQwERCBxUbZw2YFJ pOO/yXUOyJ1NpVotRzcWuUVNJ74O8m2OwOzcdNEgpjv1cTWJpjG392N2mKIQ/bRwUwMm Vzrr0g1I1cpOavvQMxZEoWgX/HopYwm/UVoPnSjswYplHX3dEuw0LuoAhstQXzanVakw 6bW5BR3HvgT4IuFHUlqRfutKYY7Jq2cjRH+VjhtcxxvFrwMz+Koq7HDqUhsLU9SeGfTy nl7Tgr5m3lM7ZlTo8hsv4KI/J2noM0VsqeAi6MKiL+s0S4wodiKJ1xju3Vl12VWrRYh3 PJ/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FbM8IWYZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8si4008902pfr.280.2019.08.23.16.27.34; Fri, 23 Aug 2019 16:27:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FbM8IWYZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393771AbfHWO1X (ORCPT + 99 others); Fri, 23 Aug 2019 10:27:23 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40625 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730899AbfHWO1X (ORCPT ); Fri, 23 Aug 2019 10:27:23 -0400 Received: by mail-wr1-f66.google.com with SMTP id c3so8811463wrd.7 for ; Fri, 23 Aug 2019 07:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sHvSmoSmDvSNNSbRGXLQshanw3+uRXJ2ONHrn0tkDQw=; b=FbM8IWYZ48uigQRt74quaG0kgIsk63LbOofdZ7aZ/X3GPHw9i9wE8vAFm+8UOr4HTH inTl5+HR2mSHUBimT06Tj+Votem5Mnyi3Rg+n4wVW0XAiM7kBBkCvW+UPqG/6t2YXfNz Lqajld73G2hYvdl4tBzYPY0czexNPhw6iOPiy9dlydQJD4C5gBh3jaZxkHkB770BEk7A 0zyspsIsNB3Uw93jTqgWRG9Q+3tP2Cd18IfmuZKtRkPWp6c6BzCeuVgppDQzkrlqzqJV ZhT+Yltq0PJl5dShimADgOXbcirLgeLpp5wjDN7ZhczER0MaVTE2NFNvVJvTHQn4dZUr c7Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sHvSmoSmDvSNNSbRGXLQshanw3+uRXJ2ONHrn0tkDQw=; b=dZhwsFZFGnsGdP6XFelIBV7x2VsDi5FIxasThjjFCeT7cJ5hKSDWjKKcMR0Ib/nVnr BrtmT5xlm5tVQDnpNiCWLWd8htAAyBDk73FMknmUmT+uliPINF3DbIQLHbK0nuN7eYn0 0/BwqnDpqiu9ANT3COKb1RHDJpy+Prn2voTJiOQ4wYSbKgNwl7rK0mwHql2ub5oSYeYt NGezBA7TMI4cCAXL5QrRyKw9D5TFmoIxZvfaTcw+Yc8TZN8vScM0PKb4GXxBjXWx/6KY aoU3BuQnO64wEMm6r2J30jXu9JDrn6Vs6uAY3FrJ0TXVv0zQmzVBUDpZ/oMwc7fCFw0r d0JA== X-Gm-Message-State: APjAAAUxZ5RzS7SkNt/WSC/h7PFy0sMde96p2Z87wxtuuNBiaUknvdGj 9dMipZS3wTEcUZAabu9qHb8= X-Received: by 2002:adf:f206:: with SMTP id p6mr5788787wro.216.1566570440610; Fri, 23 Aug 2019 07:27:20 -0700 (PDT) Received: from andrea ([167.220.196.36]) by smtp.gmail.com with ESMTPSA id h23sm4368017wml.43.2019.08.23.07.27.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Aug 2019 07:27:19 -0700 (PDT) Date: Fri, 23 Aug 2019 16:27:08 +0200 From: Andrea Parri To: Petr Mladek Cc: Andrea Parri , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Brendan Higgins , Peter Zijlstra , John Ogness , Thomas Gleixner , Linus Torvalds , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation Message-ID: <20190823142708.GA2068@andrea> References: <20190807222634.1723-1-john.ogness@linutronix.de> <20190807222634.1723-2-john.ogness@linutronix.de> <20190820085554.deuejmxn4kbqnq7n@pathway.suse.cz> <20190820092731.GA14137@jagdpanzerIV> <87a7c3f4uj.fsf@linutronix.de> <20190822135052.dp4dvav6fy2ajzkx@pathway.suse.cz> <20190822173801.GA2218@andrea> <20190823104713.mtxarc3ywtnryd2d@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190823104713.mtxarc3ywtnryd2d@pathway.suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I am not suggesting to remove all comments. Some human readable > explanation is important as long as the code is developed by humans. > > I think that I'll have to accept also the extra comments if you are > really going to use them to check the consistency by a tool. Or > if they are really used for review by some people. Glad to hear this. Thank you, Petr. > Do all this manuals, tools, people use any common syntax, please? > Would it be usable in our case as well? > > I would like to avoid reinventing the wheel. Also I do not want > to create a dialect for few people that other potentially interested > parties will not understand. Right; I think that terms such as "(barrier) matching", "reads-from" and "overwrites" are commonly used to refer to litmus tests. (The various primitives/instructions are of course specific to the given context: the language, the memory model, etc. ) IOW, I'd say that that wheel _and a common denominator here can be represented by the notion of "litmus test". I'm not suggesting to reinvent this wheel of course; my point was more along the lines of "let's use the wheel, it'll be helpful..." ;-) Andrea