Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 23 Aug 2019 10:43:57 -0700
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Adam Zerella <adam.zerella@gmail.com>
Cc:     Dominik Brodowski <linux@dominikbrodowski.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcmcia/i82092: Refactored dprintk macro for pr_debug().
Message-ID: <20190823174357.GA8052@kroah.com>
References: <20190823062951.1168-1-adam.zerella@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190823062951.1168-1-adam.zerella@gmail.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 23, 2019 at 04:29:49PM +1000, Adam Zerella wrote:
> As pointed out in https://kernelnewbies.org/KernelJanitors/Todo
> this patch replaces the outdated macro of DPRINTK for pr_debug()
> 
> To: Dominik Brodowski <linux@dominikbrodowski.net>
> To: Thomas Gleixner <tglx@linutronix.de>
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> To: Adam Zerella <adam.zerella@gmail.com>
> To: linux-kernel@vger.kernel.org
> Signed-off-by: Adam Zerella <adam.zerella@gmail.com>
> ---
>  drivers/pcmcia/i82092.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pcmcia/i82092.c b/drivers/pcmcia/i82092.c
> index ec54a2aa5cb8..e1929520c20e 100644
> --- a/drivers/pcmcia/i82092.c
> +++ b/drivers/pcmcia/i82092.c
> @@ -117,9 +117,9 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i
>  		
>  		if (card_present(i)) {
>  			sockets[i].card_state = 3;
> -			dprintk(KERN_DEBUG "i82092aa: slot %i is occupied\n",i);
> +			pr_debug("i82092aa: slot %i is occupied\n", i);
>  		} else {
> -			dprintk(KERN_DEBUG "i82092aa: slot %i is vacant\n",i);
> +			pr_debug("i82092aa: slot %i is vacant\n", i);

These really should use dev_dbg() instead, as this is a driver and you
have access to a real device here.


>  		}
>  	}
>  		
> @@ -128,7 +128,7 @@ static int i82092aa_pci_probe(struct pci_dev *dev, const struct pci_device_id *i
>  	pci_write_config_byte(dev, 0x50, configbyte); /* PCI Interrupt Routing Register */
>  
>  	/* Register the interrupt handler */
> -	dprintk(KERN_DEBUG "Requesting interrupt %i \n",dev->irq);
> +	pr_debug("Requesting interrupt %i\n", dev->irq);

Same here.

thanks,

greg k-h