Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1272680ybl; Fri, 23 Aug 2019 16:40:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQfNgp89hDM2OqpjctYEyDNKAWGi7pC4jufUn9ZqblWxDlAPX6dGJgE/bwSKseuofIPkv/ X-Received: by 2002:a62:7a0f:: with SMTP id v15mr8046008pfc.35.1566603604047; Fri, 23 Aug 2019 16:40:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566603604; cv=none; d=google.com; s=arc-20160816; b=fLJq6dXGIv7428D25tOVzZUasenL5YUQG9QyTD3VxjGIicuYKnP3aWHhyTEXrIHxZG wQL0shsv0l7HKLv5oZCogB+RhMG6aKSVMXYywms0FCRfW7gNuiG2EsxsDWNGxVEsHBee umzyfvR1IIRXAATPUwcl7O5kJ3it+D06Nf+PKo385yQPnTQOZU9Fu+5c+Ien382yoZDA 6BlpBEvLHpmtLZ3Cg/EwiAAn9KkzgZ9/Nf6wC7JiR1TaZa1VfVW3ZygTGSMPSr2ZTT1x ErdIKyhOPKUwBW0yy47WqAxD4fRv63pMJy7L/SmuZ3k3zjaQBPzYFIhvqGx9+sOMipkR YRcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=XvMS+dCLycWMBedX+9U4RI45vbffAWsDDoh2GWOwZuY=; b=JD48dAeyp0zmSyEx0WHd6aUQ1G5WhcF++pht+Qw0p0066N5c5hXIqE8C3wmRDUfmtH DXHfVHR907v6Upvynv/9fzMG5lEpr4mJnTfay/636HTJJMBJAzjh2diiiVJoR7K3uTq9 ByoJc3FB38r2ioCQkSUwdCd3ZD9jr+3aNRnMa8VMOWmpLTRsfJHdM86PiOpaUan6EKWN XEw0lkJCDmkowwy0/QOyRrcaClJL3n6GESDORwx5jgbJ+XpW4IX07CXHieUCVucM0/l2 MoslR4I4IWU4Ifw8feK9unM/hPvIqSWcLpeogAw61mD9WZvXYTXuc9OfNCbWwsGR+HxQ oWxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc10si3614734plb.171.2019.08.23.16.39.49; Fri, 23 Aug 2019 16:40:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436943AbfHWVbi (ORCPT + 99 others); Fri, 23 Aug 2019 17:31:38 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38136 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387547AbfHWVbi (ORCPT ); Fri, 23 Aug 2019 17:31:38 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A7B981543B28F; Fri, 23 Aug 2019 14:31:37 -0700 (PDT) Date: Fri, 23 Aug 2019 14:31:37 -0700 (PDT) Message-Id: <20190823.143137.1666289020578814960.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 0/2] r8152: save EEE From: David Miller In-Reply-To: <1394712342-15778-311-Taiwan-albertk@realtek.com> References: <1394712342-15778-304-Taiwan-albertk@realtek.com> <1394712342-15778-311-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 23 Aug 2019 14:31:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Fri, 23 Aug 2019 15:33:39 +0800 > v4: > For patch #2, remove redundant calling of "ocp_reg_write(tp, OCP_EEE_ADV, 0)". > > v3: > For patch #2, fix the mistake caused by copying and pasting. > > v2: > Adjust patch #1. The EEE has been disabled in the beginning of > r8153_hw_phy_cfg() and r8153b_hw_phy_cfg(), so only check if > it is necessary to enable EEE. > > Add the patch #2 for the helper function. > > v1: > Saving the settings of EEE to avoid they become the default settings > after reset_resume(). Series applied.