Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1753473ybl; Sat, 24 Aug 2019 03:48:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqytB+a/7Ls8LHeJLhrTxNEyHMOzihyYPNJNMD2THmMZJa8WtRRxJnERHIjRl+imWqDakVzy X-Received: by 2002:a17:90a:bb89:: with SMTP id v9mr9968014pjr.88.1566643730832; Sat, 24 Aug 2019 03:48:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566643730; cv=none; d=google.com; s=arc-20160816; b=kzNBOlTUp1a8TPxuIB6+TnzCWC4z7N3c3tCBTwPH6QoKqX/kgTtUZpHu4h637vyPRC htQ5CKdvhShD9z1pP0PFgz2rF9ezIGpfXi4Rvg0tgjkpEGvZSk3TpHp/kggA31f6bhiN pyREw45HGwqTKFu+tYnI6bSUrsQft8tczO9M87gvbxWj/W7u1lzsuX1byItEHgSMZ5Np sXvEmW/mw3DJFkQl8TENOTO9th049dBLNKKATY7jkv5cOlkeEuOMXKuSdJCWT+iaDGyk BERtQH0KzMYfhvkDkdecYbzwiVjeuYdBMurbhf7lYtsguVklIfEGHjTMEdySaSn1Dkm7 nThg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6Xe8d4/Qc67NKEUdvz915wuZpclJkk7CNF5g6iXqF5Q=; b=elYQXeg6NUCjaVXhh/pdSeAiOqd84Z9K9nYD78jfYZZFG/FN4SWOcxKnVUP3ZsTrMp BnvnYitSE5m+fnBsl8udqI55z7RB9rL4QMv+GhD4+7hb8/u3aaKDpWocwk7oa/kZu05P SYjS4v6LGYZHzMVWbqRzznLaHhyjaVRNS3ZsYgbll6F+eYa5XL4a12Yh2EJgXrIPT1sI 5Zu9cWMm+FngO9oSorWI4vVzd9uyh0c6XEIt/z9g37uAkQW9zpaec0KT/jDToBs61msm rH281atSFkOMMMNeei4CIBTbQ7Gg8A44lEtnm3zGfRwie/hp+O/G8/uEWeVwW0EGRXrF gKtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=TxxVAkKo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q18si4072760pgk.31.2019.08.24.03.48.23; Sat, 24 Aug 2019 03:48:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=TxxVAkKo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727604AbfHXKqq (ORCPT + 99 others); Sat, 24 Aug 2019 06:46:46 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:38428 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbfHXKqq (ORCPT ); Sat, 24 Aug 2019 06:46:46 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7OAhg6A001982; Sat, 24 Aug 2019 10:46:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=6Xe8d4/Qc67NKEUdvz915wuZpclJkk7CNF5g6iXqF5Q=; b=TxxVAkKor0C492SSz9eUNsWgdO7WiVZGpqc89E/qjzLXRT8C6XdsdwM44hfIBf1ZHX2l YTZ1MILMW6ZdZqRQUfkD7TIQnZAbB9q3QvhpwLf6w6njntnO27Z9Uicat2KZNBB3EWMu KBorrXzmbqdZuMIaZDfJxRVhvwIdRh5+AuQ5L5NYIaUY+A+BgjaHH7yIb++pH1/7MxAZ iC+ETyIB2NFoaignvx86k4a5Jk6oMaKhts9NcK8ktGkOGDIZmzcytPMIeMGLUPjaY4sf AK+5UiJLCIieMGFrDmD8fQt1NtHneSZoG9ybEkhaCRtcyjcLDEmkCpPDUd/HFgRzolZd BQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2ujw6yrwb0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 10:46:36 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7OAhXrv145624; Sat, 24 Aug 2019 10:46:36 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2ujw6t78pu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Aug 2019 10:46:36 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7OAkUYd007167; Sat, 24 Aug 2019 10:46:30 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 24 Aug 2019 03:46:29 -0700 Date: Sat, 24 Aug 2019 13:46:20 +0300 From: Dan Carpenter To: Quentin Deslandes Cc: Markus Elfring , "devel@driverdev.osuosl.org" , Greg Kroah-Hartman , "kernel-janitors@vger.kernel.org" , Forest Bond , LKML Subject: Re: [PATCH] staging: vt6656: Use common error handling code in vnt_alloc_bufs() Message-ID: <20190824104620.GC23408@kadam> References: <91e8a9b7-e79d-dafc-10b8-dd79eb59eff9@web.de> <20190823145540.GA2536@qd-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190823145540.GA2536@qd-ubuntu> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=943 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240119 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9358 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908240120 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The original code is fine. There was no chance we were going to apply the patch so there is no need for any discussion. I don't know why Markus sent it when he knows. regards, dan carpenter