Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 24 Aug 2019 13:30:53 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Mark Rutland <mark.rutland@arm.com>
Cc:     linux-kernel@vger.kernel.org,
        Alexander Potapenko <glider@google.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCHv2] lib/test_kasan: add roundtrip tests
Message-Id: <20190824133053.aa5c6393815a5cb55dbdb8a4@linux-foundation.org>
In-Reply-To: <20190823104107.GA55480@lakrids.cambridge.arm.com>
References: <20190819161449.30248-1-mark.rutland@arm.com>
        <20190822164857.460353a8195bfd5ddb3d5f50@linux-foundation.org>
        <20190823104107.GA55480@lakrids.cambridge.arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 23 Aug 2019 11:41:08 +0100 Mark Rutland <mark.rutland@arm.com> wrote:

> >  
> >  /*
> > 
> > which is really kinda wrong.  We should strictly include linux/io.h for
> > things like virt_to_phys().
> > 
> > So I think I'll stick with v1 plus my fixlet:
> > 
> > --- a/lib/test_kasan.c~lib-test_kasan-add-roundtrip-tests-checkpatch-fixes
> > +++ a/lib/test_kasan.c
> > @@ -18,8 +18,8 @@
> >  #include <linux/slab.h>
> >  #include <linux/string.h>
> >  #include <linux/uaccess.h>
> > +#include <linux/io.h>
> >  
> > -#include <asm/io.h>
> >  #include <asm/page.h>
> >  
> >  /*
> > 
> 
> Assuming that you mean *v3* with that fix, that looks good to me!

Yes, that's what we have.