Date: Sat, 17 Dec 2005 19:14:17 -0800
From: Andrew Morton <akpm@osdl.org>
To: Robert Walsh <rjwalsh@pathscale.com>
Cc: rolandd@cisco.com, linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH 01/13]  [RFC] ipath basic headers
Message-Id: <20051217191417.f16011bb.akpm@osdl.org>
In-Reply-To: <1134859158.20575.82.camel@phosphene.durables.org>
References: <200512161548.jRuyTS0HPMLd7V81@cisco.com>
	<200512161548.aLjaDpGm5aqk0k0p@cisco.com>
	<20051217123827.32f119da.akpm@osdl.org>
	<1134859158.20575.82.camel@phosphene.durables.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 570
Lines: 20

Robert Walsh <rjwalsh@pathscale.com> wrote:
>
> > I'd be inclined to stick BITS_PER_BYTE into include/linux/types.h.
> 
> Really?  I was just going to suggest removing it, but if sticking it in
> types.h works for you, then fine.
> 

I think it's a readbility thing.

	x += 8;			/* wtf? */

vs

	x += BITS_PER_BYTE;	/* ah! */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/