Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2640582ybl; Sat, 24 Aug 2019 22:56:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqzV+OwntkP2qmwRmvskBbhVQ6gjim5dDsyhgN0aaT2MccOOD7W5qyoCmp3B4apv/kDc8Oex X-Received: by 2002:a17:902:aa91:: with SMTP id d17mr12557659plr.74.1566712578206; Sat, 24 Aug 2019 22:56:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566712578; cv=none; d=google.com; s=arc-20160816; b=tFo5nwgSzdqwO499MVKzlwXgZUM5Km0XsTgDOsSCFJUJ3kgXS95CSyeKONuW5R+gl0 9KI+tVqXFTm1WEGfjlFx351VRycKMGWLe2mmmYAO+BNF3mvTrltbAe9HA2CtYaxsYFTW ndnSuOAsfXs020p0qqbwdlwdQtOQ/uow+aAmoO6u09Ms3UvclVq41gENJV/1csQKfZM2 O8M8DewOcmkx+wcBg9WtAkqpou3r7ey1gw+2AuUsCCD9nAvhQWcTGwYjVE+/xEmiEKb7 HGejj1CksYqivWKcDXs0d6N8KHOG2E2Hb7nCI4TLM4uirhnz/CdJ4vdN5j21uradAI59 Ko/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EE6s9rowpqNXdfKqKIpfGICXwT7EosdR3sQhJlDr2gQ=; b=JjxG2V2mb+7NFhD3wAk5EM4+T9aIL6uIIbxuM4PPldBHo9N6acLK/jWarn4FWsuJN6 Z+hWnnx9m63X3QXJqAnMFm05pNR9ULcw3YrVbZqmFfpyNwuOy/NyOExdhsiP3mMyZ+k+ uYg64AmFFbf8PBSTvblwNGVgsLZaZgKekbzHVUrNKQbrnoBkXdJiSqan3xp4AImYDMfu EumUGYYYQ8c7nmYmvH7Q0PEFtHk6ZZMqVXq0bnbtXX7KrxA6FTPnMH5uAMshsPj7yJIJ egQmKLdnu7sFBV8cWlcQD2+wUoRMomPxZlFOTH7jNDTHhhR06dQGhSdjEEmcz9KQPsNR olMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DTzyttXB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11si4971648plo.150.2019.08.24.22.56.03; Sat, 24 Aug 2019 22:56:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DTzyttXB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727051AbfHYFzE (ORCPT + 99 others); Sun, 25 Aug 2019 01:55:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:33424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfHYFzE (ORCPT ); Sun, 25 Aug 2019 01:55:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41B6B21848; Sun, 25 Aug 2019 05:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566712503; bh=6SR9gaVqFwRvUhukFwgkAst5fu/Qlhy9PQMt1ZCkCq0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DTzyttXBMaPw8mWA6JcmQOcb8GmlqoiNg4gYZ1r+rDro3NE5sVFica4VxC7SyID27 /k2aF6QbcuM4wzhVAHwOcF+VE4jBKeMTsItwQj5jesWSg3lmn+xRhHEivbUqZxGDPy 7mO6VarNROPO3bRqBBnMIoS0onRiFTBh1XoiEdk4= From: Greg Kroah-Hartman To: devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, elder@kernel.org, johan@kernel.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH 4/9] staging: greybus: manifest: Fix up some alignment checkpatch issues Date: Sun, 25 Aug 2019 07:54:24 +0200 Message-Id: <20190825055429.18547-5-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190825055429.18547-1-gregkh@linuxfoundation.org> References: <20190825055429.18547-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some function prototypes do not match the expected alignment formatting so fix that up so that checkpatch is happy. Cc: Johan Hovold Cc: Alex Elder Cc: greybus-dev@lists.linaro.org Cc: devel@driverdev.osuosl.org Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/manifest.c | 39 +++++++++++++++--------------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/staging/greybus/manifest.c b/drivers/staging/greybus/manifest.c index 08db49264f2b..4ebbba52b07c 100644 --- a/drivers/staging/greybus/manifest.c +++ b/drivers/staging/greybus/manifest.c @@ -104,15 +104,15 @@ static int identify_descriptor(struct gb_interface *intf, size_t expected_size; if (size < sizeof(*desc_header)) { - dev_err(&intf->dev, "manifest too small (%zu < %zu)\n", - size, sizeof(*desc_header)); + dev_err(&intf->dev, "manifest too small (%zu < %zu)\n", size, + sizeof(*desc_header)); return -EINVAL; /* Must at least have header */ } desc_size = le16_to_cpu(desc_header->size); if (desc_size > size) { dev_err(&intf->dev, "descriptor too big (%zu > %zu)\n", - desc_size, size); + desc_size, size); return -EINVAL; } @@ -139,22 +139,22 @@ static int identify_descriptor(struct gb_interface *intf, case GREYBUS_TYPE_INVALID: default: dev_err(&intf->dev, "invalid descriptor type (%u)\n", - desc_header->type); + desc_header->type); return -EINVAL; } if (desc_size < expected_size) { dev_err(&intf->dev, "%s descriptor too small (%zu < %zu)\n", - get_descriptor_type_string(desc_header->type), - desc_size, expected_size); + get_descriptor_type_string(desc_header->type), + desc_size, expected_size); return -EINVAL; } /* Descriptor bigger than what we expect */ if (desc_size > expected_size) { dev_warn(&intf->dev, "%s descriptor size mismatch (want %zu got %zu)\n", - get_descriptor_type_string(desc_header->type), - expected_size, desc_size); + get_descriptor_type_string(desc_header->type), + expected_size, desc_size); } descriptor = kzalloc(sizeof(*descriptor), GFP_KERNEL); @@ -208,7 +208,7 @@ static char *gb_string_get(struct gb_interface *intf, u8 string_id) /* Allocate an extra byte so we can guarantee it's NUL-terminated */ string = kmemdup(&desc_string->string, desc_string->length + 1, - GFP_KERNEL); + GFP_KERNEL); if (!string) return ERR_PTR(-ENOMEM); string[desc_string->length] = '\0'; @@ -264,8 +264,7 @@ static u32 gb_manifest_parse_cports(struct gb_bundle *bundle) desc_cport = tmp->data; if (cport_id == le16_to_cpu(desc_cport->id)) { dev_err(&bundle->dev, - "duplicate CPort %u found\n", - cport_id); + "duplicate CPort %u found\n", cport_id); goto exit; } } @@ -277,7 +276,7 @@ static u32 gb_manifest_parse_cports(struct gb_bundle *bundle) return 0; bundle->cport_desc = kcalloc(count, sizeof(*bundle->cport_desc), - GFP_KERNEL); + GFP_KERNEL); if (!bundle->cport_desc) goto exit; @@ -287,7 +286,7 @@ static u32 gb_manifest_parse_cports(struct gb_bundle *bundle) list_for_each_entry_safe(desc, next, &list, links) { desc_cport = desc->data; memcpy(&bundle->cport_desc[i++], desc_cport, - sizeof(*desc_cport)); + sizeof(*desc_cport)); /* Release the cport descriptor */ release_manifest_descriptor(desc); @@ -333,9 +332,9 @@ static u32 gb_manifest_parse_bundles(struct gb_interface *intf) /* Ignore any legacy control bundles */ if (bundle_id == GB_CONTROL_BUNDLE_ID) { dev_dbg(&intf->dev, "%s - ignoring control bundle\n", - __func__); + __func__); release_cport_descriptors(&intf->manifest_descs, - bundle_id); + bundle_id); continue; } @@ -468,7 +467,7 @@ bool gb_manifest_parse(struct gb_interface *intf, void *data, size_t size) /* we have to have at _least_ the manifest header */ if (size < sizeof(*header)) { dev_err(&intf->dev, "short manifest (%zu < %zu)\n", - size, sizeof(*header)); + size, sizeof(*header)); return false; } @@ -478,15 +477,15 @@ bool gb_manifest_parse(struct gb_interface *intf, void *data, size_t size) manifest_size = le16_to_cpu(header->size); if (manifest_size != size) { dev_err(&intf->dev, "manifest size mismatch (%zu != %u)\n", - size, manifest_size); + size, manifest_size); return false; } /* Validate major/minor number */ if (header->version_major > GREYBUS_VERSION_MAJOR) { dev_err(&intf->dev, "manifest version too new (%u.%u > %u.%u)\n", - header->version_major, header->version_minor, - GREYBUS_VERSION_MAJOR, GREYBUS_VERSION_MINOR); + header->version_major, header->version_minor, + GREYBUS_VERSION_MAJOR, GREYBUS_VERSION_MINOR); return false; } @@ -513,7 +512,7 @@ bool gb_manifest_parse(struct gb_interface *intf, void *data, size_t size) } if (found != 1) { dev_err(&intf->dev, "manifest must have 1 interface descriptor (%u found)\n", - found); + found); result = false; goto out; } -- 2.23.0