Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <98427b15d2a5cc93c72867bb7800df6c38f1f7bf.camel@perches.com>
Subject: Re: [PATCH] cdrom: make debug logging rely on pr_debug and debugfs
 only.
From:   Joe Perches <joe@perches.com>
To:     Diego Elio =?ISO-8859-1?Q?Petten=F2?= <flameeyes@flameeyes.com>,
        Jens Axboe <axboe@kernel.dk>
Cc:     linux-kernel@vger.kernel.org
Date:   Sun, 25 Aug 2019 15:13:09 -0700
In-Reply-To: <20190825215833.25817-1-flameeyes@flameeyes.com>
References: <20190825215833.25817-1-flameeyes@flameeyes.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.32.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2019-08-25 at 22:58 +0100, Diego Elio Petten? wrote:
> The cdrom driver predates debugfs and most of the modern debugging
> facilities, so instead it has been includings a module parameter and an
> ioctl to enable debug messages.
> 
> In 2019, debugfs and dynamic debug makes most of that redundant, and even
> confusing when trying to trace things in the dept of the driver.
[]
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
[]
> @@ -591,7 +556,7 @@ int register_cdrom(struct cdrom_device_info *cdi)
>  	static char banner_printed;
>  	const struct cdrom_device_ops *cdo = cdi->ops;
>  
> -	cd_dbg(CD_OPEN, "entering register_cdrom\n");
> +	pr_debug("entering register_cdrom\n");

debut output for function tracing can also be removed
and ftrace used instead.

> @@ -643,7 +608,7 @@ int register_cdrom(struct cdrom_device_info *cdi)
>  
>  void unregister_cdrom(struct cdrom_device_info *cdi)
>  {
> -	cd_dbg(CD_OPEN, "entering unregister_cdrom\n");
> +	pr_debug("entering unregister_cdrom\n");

etc...