Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3814540ybl; Mon, 26 Aug 2019 00:36:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQY5c9e25svg3bdvfvVQnsg9kZeu4iiLAq3ldJiTuipMxDiXQnQ/bWOjkryRpyHpXLHKgv X-Received: by 2002:a63:d04e:: with SMTP id s14mr14501670pgi.189.1566805013379; Mon, 26 Aug 2019 00:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566805013; cv=none; d=google.com; s=arc-20160816; b=OE+e3lWJL83azPIxCdA0wXJC6QGEUaglxghc3LqM7vUYJ2fBGvFA1zkydvFRdwHnEW kXWcgV5l+DTnkdEZc9WOm6IIkwUeTTdk02+bwE4DxqPjPzp8YFSdA1qSsXX174a1sN9Z YM3E4aNCkez28yzr0gYURV7diZcphvnUHpdmTOsFtgIF7wPOPBTx8DCKJCIKPItaKTmg PFqIOgELzTjR/m+OOigCmdzrqh43U2t/VbI1oAGHstctP/DAG8upSCw8bMvKhHPgPVns ticMTC7sayYAcTx8aQQxSO1RCwsyILDDpGpVve2NjSiasYRbtidmeGTYebbY6eHty7Y5 GStA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=mwWr3g2Aquo7lO1ZpNGfWr1cyISMAoOdZ84A49XquWc=; b=jg1JI+jxj02Th+UZefkKnCm+MeTMlJzWMytyyR9uHz3tVnXENHEL0zFnPPF3qwJ6lu fYN1l/EmTzwb4Iga5wSKQRYu3acwuwr52U7PaUcmXUTGDskeXgr2R6jguKT0uZ/voJjM xer7sL277/HNAWTEV8zn4pbd99ksx9L/TJsW3ffZv9+WrTp2UQM6IYjS6XfyHwxUb93z AfIwK8vHGsgGVoGsRNGKaS3AFiBtZpsQg01ScqMVQLaj809TQ/VguYtK6LMlkPYrr3J2 NowoT2DJtoD5k0bT3QuJZ2M1r1OSEmquNiLIJUB8Mnfi4xeQ9mN3Z8sIDAF7DfC5dAN3 DgBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t21si8230463pga.294.2019.08.26.00.36.37; Mon, 26 Aug 2019 00:36:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730058AbfHZHeT (ORCPT + 99 others); Mon, 26 Aug 2019 03:34:19 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42827 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728168AbfHZHeT (ORCPT ); Mon, 26 Aug 2019 03:34:19 -0400 X-Originating-IP: 81.250.144.103 Received: from [10.30.1.20] (lneuilly-657-1-5-103.w81-250.abo.wanadoo.fr [81.250.144.103]) (Authenticated sender: alex@ghiti.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 49BD560003; Mon, 26 Aug 2019 07:34:12 +0000 (UTC) Subject: Re: [PATCH RESEND 0/8] Fix mmap base in bottom-up mmap To: Andrew Morton Cc: "James E . J . Bottomley" , Helge Deller , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org References: <20190620050328.8942-1-alex@ghiti.fr> From: Alexandre Ghiti Message-ID: Date: Mon, 26 Aug 2019 09:34:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190620050328.8942-1-alex@ghiti.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: fr Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/20/19 7:03 AM, Alexandre Ghiti wrote: > This series fixes the fallback of the top-down mmap: in case of > failure, a bottom-up scheme can be tried as a last resort between > the top-down mmap base and the stack, hoping for a large unused stack > limit. > > Lots of architectures and even mm code start this fallback > at TASK_UNMAPPED_BASE, which is useless since the top-down scheme > already failed on the whole address space: instead, simply use > mmap_base. > > Along the way, it allows to get rid of of mmap_legacy_base and > mmap_compat_legacy_base from mm_struct. > > Note that arm and mips already implement this behaviour. > > Alexandre Ghiti (8): > s390: Start fallback of top-down mmap at mm->mmap_base > sh: Start fallback of top-down mmap at mm->mmap_base > sparc: Start fallback of top-down mmap at mm->mmap_base > x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base > mm: Start fallback top-down mmap at mm->mmap_base > parisc: Use mmap_base, not mmap_legacy_base, as low_limit for > bottom-up mmap > x86: Use mmap_*base, not mmap_*legacy_base, as low_limit for bottom-up > mmap > mm: Remove mmap_legacy_base and mmap_compat_legacy_code fields from > mm_struct > > arch/parisc/kernel/sys_parisc.c | 8 +++----- > arch/s390/mm/mmap.c | 2 +- > arch/sh/mm/mmap.c | 2 +- > arch/sparc/kernel/sys_sparc_64.c | 2 +- > arch/sparc/mm/hugetlbpage.c | 2 +- > arch/x86/include/asm/elf.h | 2 +- > arch/x86/kernel/sys_x86_64.c | 4 ++-- > arch/x86/mm/hugetlbpage.c | 7 ++++--- > arch/x86/mm/mmap.c | 20 +++++++++----------- > include/linux/mm_types.h | 2 -- > mm/debug.c | 4 ++-- > mm/mmap.c | 2 +- > 12 files changed, 26 insertions(+), 31 deletions(-) > Hi everyone, Any thoughts about that series ? As said before, this is just a preparatory patchset in order to merge x86 mmap top down code with the generic version. Thanks for taking a look, Alex