Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1566808307.3089.2.camel@linux.ibm.com>
Subject: Re: [PATCH] scsi: aic7xxx: Remove dead code
From:   James Bottomley <jejb@linux.ibm.com>
To:     Souptick Joarder <jrdr.linux@gmail.com>, hare@suse.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 26 Aug 2019 09:31:47 +0100
In-Reply-To: <1566659302-3514-1-git-send-email-jrdr.linux@gmail.com>
References: <1566659302-3514-1-git-send-email-jrdr.linux@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2019-08-24 at 20:38 +0530, Souptick Joarder wrote:
> These are dead code since 2.6.13. If there is no plan
> to use it further, these can be removed forever.

Unless you can articulate a clear useful reason for the removal I'd
rather keep this and the other code.  Most of the documentation for
this chip is lost in the mists of time, so code fragments like this are
the only way we know how it was supposed to work.

A clear reason might be that it's impossible for aic7xxx ever to make
use of IU and QAS because they're LVD parameters and it's a SE/HVD
card, so the documentation in the code is actively wrong, but you'd
need to research that.

James