Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4016658ybl; Mon, 26 Aug 2019 04:16:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwL0C2kTPiYZDQ9yB53Sc4sj2zbjNFW1bNk3Kt+82oIeEfjhA7XYoZc/Nk5Y68UDrNeIALB X-Received: by 2002:a63:b555:: with SMTP id u21mr5757377pgo.222.1566818219170; Mon, 26 Aug 2019 04:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566818219; cv=none; d=google.com; s=arc-20160816; b=qfyYbKHRD3LXNv8hdR0e4h1W93cVH6T8f1noi6YomiBwCbj5wQF0y0AK8KzJiN50ed GXCLMoXlXgDbkdARezK4iRkpmP4LFmEQ2zhF7GM3/D6top+Tc54MuMxR1691/IVu769+ LBoXGCfltMPBWItRUb4ktqtxiFmYv+hi1dF18ez78dZENnvjqkVD3XqpL3W6dRGxOh6e jmDFqg9OWsnm8myBzEzv2Wh9uGwfV/UyziCAI1QcN4z2yLnQDgQpbMLo/1EOyRity1vj XIvaWK6tXGqjgpOlH3Ky2FfeUDYxFKRUasHFbxH6cUfFWReiXZbLODv7JOy5gMLDoyRg 0m4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=NqreR8zfB5JMLrVzLVEfp6bgp/fDdPqAvp15p3JTH08=; b=IRnF4GJXN0DvTsaOX2OsNzmrTWVqG1WjWvf3NQ4W9nGKh7oHGgnGOnBvwo6OyDwogQ 3G/2NycaOHsglo4Dz4hxGz1tBvWinDaBc2iHQrz4euAZZFSLDmB3L/s6vY9BxzKc8VcQ KpMm2zQuef1xYh33m1ttJ4Ofv0T2qqNTejO2M1iNb3LsCM5fjagrTg509Y4IW0pzaPpP m6oGFwf32ANaMBXOhfWAVbD0yCeqNSocghbmve3sI9Jcr59jN5GKwf5wJVdoTI6ghvDI S1IZ5QQCZpBnr1f38p2Ef2K5QQuEpGtJfodB5S5HpJbNi+BTGtf1g3F2B5C8bYRNJYuN 1KMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13si9295409plq.359.2019.08.26.04.16.44; Mon, 26 Aug 2019 04:16:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730082AbfHZIze (ORCPT + 99 others); Mon, 26 Aug 2019 04:55:34 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50684 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfHZIzd (ORCPT ); Mon, 26 Aug 2019 04:55:33 -0400 Received: by mail-wm1-f68.google.com with SMTP id v15so14657268wml.0; Mon, 26 Aug 2019 01:55:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NqreR8zfB5JMLrVzLVEfp6bgp/fDdPqAvp15p3JTH08=; b=sZA9QtOdNAsfqX0PwI+jiIyABKAfS5OZ3DqDewxDtsszLflmwpVICei1ay2pBCxwom yeR006O4Li54miPJlDRGChUryRwVwnKLpA73QvOOgXXgJTWP8W7eOvLRGgLEJ+pHQqBr WOBnYwvc43CTaZ56NeD9CxfBJJeIxfDQplPG1jX59tuY149DXbS7PAub8/dKnvA6Gmgm RuUr6cedXPq7U6Eyih3RUIBDB0FD326eqkesN6PFO3HKTeoHmZF27V6YxmLZgCIMfmya sosH8R3LxN4W2fcTc3O2eMM9r3pJg52rMyjNEKI6XXI4T5hU9USALvcMAGfD/M8ZJyCl vCnw== X-Gm-Message-State: APjAAAUl5lBYaPrKe6kNPKPA9BXYlORf3hW4zJ2TxXK4zg8hc6PImaDI jqGdUuL3PfwRyTjbmRt8M+E+0IYb X-Received: by 2002:a7b:c947:: with SMTP id i7mr20945723wml.77.1566809731531; Mon, 26 Aug 2019 01:55:31 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id g14sm18831366wrb.38.2019.08.26.01.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2019 01:55:31 -0700 (PDT) Subject: Re: [PATCH net v2 1/2] Revert "r8152: napi hangup fix after disconnect" To: Hayes Wang , netdev@vger.kernel.org Cc: nic_swsd@realtek.com, linux-kernel@vger.kernel.org References: <1394712342-15778-317-Taiwan-albertk@realtek.com> <1394712342-15778-318-Taiwan-albertk@realtek.com> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: <1f707377-7b61-4ba1-62bf-f275d0360749@suse.cz> Date: Mon, 26 Aug 2019 10:55:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1394712342-15778-318-Taiwan-albertk@realtek.com> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26. 08. 19, 10:41, Hayes Wang wrote: > This reverts commit 0ee1f4734967af8321ecebaf9c74221ace34f2d5. > > This conflicts with commit ffa9fec30ca0 ("r8152: set > RTL8152_UNPLUG only for real disconnection"). Could you clarify *why* it conflicts? And how is the problem fixed by 0ee1f473496 avoided now? > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index eee0f5007ee3..ad3abe26b51b 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -4021,8 +4021,7 @@ static int rtl8152_close(struct net_device *netdev) > #ifdef CONFIG_PM_SLEEP > unregister_pm_notifier(&tp->pm_notifier); > #endif > - if (!test_bit(RTL8152_UNPLUG, &tp->flags)) > - napi_disable(&tp->napi); > + napi_disable(&tp->napi); > clear_bit(WORK_ENABLE, &tp->flags); > usb_kill_urb(tp->intr_urb); > cancel_delayed_work_sync(&tp->schedule); > thanks, -- js suse labs