Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4037443ybl; Mon, 26 Aug 2019 04:37:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLGT5LzuOxYDNiOPKSdv5MQNFP0kNj24QjwykoUZngWyYxFvgOb2E1UNS65bmyAbqwwwsu X-Received: by 2002:a62:8648:: with SMTP id x69mr19720101pfd.92.1566819436004; Mon, 26 Aug 2019 04:37:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566819435; cv=none; d=google.com; s=arc-20160816; b=pd7HjEF0JDWB6OWJARjXP2t6BspW5MBsYfWFZPReO3r+2cT/bAzlcV0BNn5/6W3slH HwctXxH7499Cyh4pQy4eh8OpPUwb5Ewl1Mf3q3ZNG7OB9b8I03xb7pR8n6yWlJT2XFKr YsAT8+OeKcONeVaE9+rWSEjHvDyPfeuV2Z1H/HpuqaHq1mKpZfJ//h8O8yVW7TBA4Gp0 CpN88jl9ZoyC6YqNIj7Ww6LAqIK43enSNJfEjvAhGE48q2sDiMlInjk6+PLFZGD7p+jL oDqu0A8MpLGcXK7nbbPzOZK1Syr0Hl2o72mWSnSEsb0EtAiRl2u5423zJ42bNikrb5bh O7vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject; bh=mZphHv38P4j4TRvKbfCCdrKAQnccwrBrO1vZ+EMo8Ns=; b=I5BKn+zMSkOgYkfMSmCI1H5v/u25hUMNy/Dpvr3EggU4w9bk0rn8d5TRPYQd8Fa/lS jzKkL1XDxBzRp439WgTkLQ6bTa2Br1zoIAC+a2tEyHTSAeS2qv40ejM7twkfo+mXZ7ye OobLLVWXam+Czq0QMtrMiL3OuhmG93hedVuknEkqr8wNgU8HkMlI7iUWy8s1pv1A0Txi mziS3J/2LSZTFaGz/vDI7LL+uT2MrJqOKjv5F2f0ar7H4Qn/j+5DkpjDnt4dPmOMQ8/U 6qdSDK4SSkA2kcyiPqtWTLCRN1ktWA6FknCvNp4mUWZodkbDGyZwyHWJB/mvVAfhfbp4 LX6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p187si10336798pfp.5.2019.08.26.04.37.00; Mon, 26 Aug 2019 04:37:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731173AbfHZLQ3 (ORCPT + 99 others); Mon, 26 Aug 2019 07:16:29 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56148 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727125AbfHZLQ3 (ORCPT ); Mon, 26 Aug 2019 07:16:29 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7QB92Ii141158 for ; Mon, 26 Aug 2019 07:16:27 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2umdkut01x-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Aug 2019 07:16:27 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Aug 2019 12:16:25 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 26 Aug 2019 12:16:22 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7QBGLQg54067414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Aug 2019 11:16:21 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8095B4204D; Mon, 26 Aug 2019 11:16:21 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ADB2F4204C; Mon, 26 Aug 2019 11:16:19 +0000 (GMT) Received: from [9.85.90.31] (unknown [9.85.90.31]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 26 Aug 2019 11:16:19 +0000 (GMT) Subject: Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation To: Sourabh Jain , mpe@ellerman.id.au Cc: mahesh@linux.vnet.ibm.com, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, corbet@lwn.net References: <20190810175905.7761-1-sourabhjain@linux.ibm.com> <53311fa4-2cce-1eb6-1aae-0c835e06eb24@linux.ibm.com> From: Hari Bathini Date: Mon, 26 Aug 2019 16:46:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19082611-0020-0000-0000-0000036415AB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19082611-0021-0000-0000-000021B95D01 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-26_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908260124 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/08/19 4:14 PM, Sourabh Jain wrote: > > > On 8/26/19 3:46 PM, Sourabh Jain wrote: >> >> >> On 8/26/19 3:29 PM, Hari Bathini wrote: >>> >>> >>> On 10/08/19 11:29 PM, Sourabh Jain wrote: >>>> Add a sys interface to allow querying the memory reserved by >>>> fadump for saving the crash dump. >>>> >>>> Add an ABI doc entry for new sysfs interface. >>>> - /sys/kernel/fadump_mem_reserved >>>> >>>> Signed-off-by: Sourabh Jain >>>> --- >>>> Changelog: >>>> v1 -> v2: >>>> - Added ABI doc for new sysfs interface. >>>> >>>> v2 -> v3: >>>> - Updated the ABI documentation. >>>> --- >>>> >>>> Documentation/ABI/testing/sysfs-kernel-fadump | 6 ++++++ >>> >>> Shouldn't this be Documentation/ABI/testing/sysfs-kernel-fadump_mem_reserved? > > How about documenting fadump_mem_reserved and other sysfs attributes suggested > by you in a single file Documentation/ABI/testing/sysfs-kernel-fadump? I wouldn't mind that but please do check if it is breaking a convention.. - Hari