Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1566659302-3514-1-git-send-email-jrdr.linux@gmail.com> <1566808307.3089.2.camel@linux.ibm.com>
In-Reply-To: <1566808307.3089.2.camel@linux.ibm.com>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Mon, 26 Aug 2019 17:40:57 +0530
Message-ID: <CAFqt6zaCBEXVmyD8ZEA8x537CLeeNriSoSST3NqhPTbR8fg7Hw@mail.gmail.com>
Subject: Re: [PATCH] scsi: aic7xxx: Remove dead code
To:     James Bottomley <jejb@linux.ibm.com>
Cc:     hare@suse.com, "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 26, 2019 at 2:03 PM James Bottomley <jejb@linux.ibm.com> wrote:
>
> On Sat, 2019-08-24 at 20:38 +0530, Souptick Joarder wrote:
> > These are dead code since 2.6.13. If there is no plan
> > to use it further, these can be removed forever.
>
> Unless you can articulate a clear useful reason for the removal I'd
> rather keep this and the other code.  Most of the documentation for
> this chip is lost in the mists of time, so code fragments like this are
> the only way we know how it was supposed to work.

Considering your feedback, let's keep this code :)
>
> A clear reason might be that it's impossible for aic7xxx ever to make
> use of IU and QAS because they're LVD parameters and it's a SE/HVD
> card, so the documentation in the code is actively wrong, but you'd
> need to research that.

I need to look further to come up with a clear reason.