Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190825215833.25817-1-flameeyes@flameeyes.com> <98427b15d2a5cc93c72867bb7800df6c38f1f7bf.camel@perches.com>
In-Reply-To: <98427b15d2a5cc93c72867bb7800df6c38f1f7bf.camel@perches.com>
From:   =?UTF-8?Q?Diego_Elio_Petten=C3=B2?= <flameeyes@flameeyes.com>
Date:   Mon, 26 Aug 2019 15:51:53 +0100
Message-ID: <CAHcsgXTDoVGPhGg+wkcu4CYDxyRMc8+wzUZ_qbJ-L6EomkRN6g@mail.gmail.com>
Subject: Re: [PATCH] cdrom: make debug logging rely on pr_debug and debugfs only.
To:     Joe Perches <joe@perches.com>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Aug 25, 2019 at 11:13 PM Joe Perches <joe@perches.com> wrote:
> > -     cd_dbg(CD_OPEN, "entering register_cdrom\n");
> > +     pr_debug("entering register_cdrom\n");
>
> debut output for function tracing can also be removed
> and ftrace used instead.

Oh, nice! I have never had to go this deep into a driver before, so
I'm pretty much an ftrace noob, but that pointer actually made the
whole debugging _much_ easier, too!

I'll send an updated patch series now that (thanks to that!) I managed
to make the device I'm fighting with work.