Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Aug 2019 18:12:32 +0200
Message-ID: <s5himqjkirz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Sudo Kamikaze" <pulshencode@outlook.com>
Cc:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        ManuelReinhardt <manuel.rhdt@gmail.com>,
        Tony Das <tdas444@gmail.com>,
        Olek Poplavsky <woodenbits@gmail.com>,
        Sasha Levin <sashal@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jaroslav Kysela <perex@perex.cz>,
        Sudokamikaze <sudokamikaze@protonmail.com>,
        Jussi Laako <jussi@sonarnerd.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Add Hiby R3 to quirks for native DSD support
In-Reply-To: <DB6PR07MB4296BE759CEDC6F0A6D4E5E3A8A10@DB6PR07MB4296.eurprd07.prod.outlook.com>
References: <DB6PR07MB4296BE759CEDC6F0A6D4E5E3A8A10@DB6PR07MB4296.eurprd07.prod.outlook.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 26 Aug 2019 18:05:05 +0200,
Sudo Kamikaze wrote:
> 
> From: Sudokamikaze <sudokamikaze@protonmail.com>
> 
> This patch adds quirk VID/PID IDs for Hiby R3 portable DSD player DSD support
> 
> Signed-off-by: Sudokamikaze <sudokamikaze@protonmail.com>
> ---
>  sound/usb/quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 78858918cbc1..f90418149e4e 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1588,6 +1588,12 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
>  		if (fp->altsetting == 2)
>  			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
>  		break;
> +	
> +	/* ESS Sabre based USB DACs */
> +	case USB_ID(0xc502, 0x0051): /* Hiby R3 */
> +		if (fp->altsetting == 4)
> +			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
> +		break;

Is fp->dsd_raw set for your device?  IOW, instead of adding an
individual entry here, adding the vendor 0xc502 with fp->dsd_raw check
like below would work?


thanks,

Takashi

--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1658,6 +1658,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
 	case 0x152a:  /* Thesycon devices */
 	case 0x25ce:  /* Mytek devices */
 	case 0x2ab6:  /* T+A devices */
+	case 0xc502:  /* ESS Sabre */
 		if (fp->dsd_raw)
 			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
 		break;