Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <e2cf315d21394ca2c994a2499d9816cd4922197d.camel@linux.ibm.com>
Subject: Re: [PATCH 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if
 IPv6 is disabled on boot
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Florian Westphal <fw@strlen.de>,
        Pablo Neira Ayuso <pablo@netfilter.org>
Cc:     netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        "David S. Miller" <davem@davemloft.net>
Date:   Mon, 26 Aug 2019 13:47:55 -0300
In-Reply-To: <20190821095844.me6kscvnfruinseu@salvia>
References: <20190820005821.2644-1-leonardo@linux.ibm.com>
         <20190820053607.GL2588@breakpoint.cc>
         <793ce2e9b6200a033d44716749acc837aaf5e4e7.camel@linux.ibm.com>
         <20190821095844.me6kscvnfruinseu@salvia>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-zBDRiKK8xztrGjRvBz3a"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-zBDRiKK8xztrGjRvBz3a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Pablo, Florian,

I implemented a V2 of this patch with the changes you proposed.
Could you please give your feedback on that patch?
https://lkml.org/lkml/2019/8/21/527

Thanks!

On Wed, 2019-08-21 at 11:58 +0200, Pablo Neira Ayuso wrote:
> On Tue, Aug 20, 2019 at 01:15:58PM -0300, Leonardo Bras wrote:
> > On Tue, 2019-08-20 at 07:36 +0200, Florian Westphal wrote:
> > > Wouldn't fib_netdev.c have the same problem?
> > Probably, but I haven't hit this issue yet.
> >=20
> > > If so, might be better to place this test in both
> > > nft_fib6_eval_type and nft_fib6_eval.
> >=20
> > I think that is possible, and not very hard to do.
> >=20
> > But in my humble viewpoint, it looks like it's nft_fib_inet_eval() and
> > nft_fib_netdev_eval() have the responsibility to choose a valid
> > protocol or drop the package.=20
> > I am not sure if it would be a good move to transfer this
> > responsibility to nft_fib6_eval_type() and nft_fib6_eval(), so I would
> > rather add the same test to nft_fib_netdev_eval().
> >=20
> > Does it make sense?
>=20
> Please, update common code to netdev and ip6 extensions as Florian
> suggests.
>=20
> Thanks.

--=-zBDRiKK8xztrGjRvBz3a
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl1kDTsACgkQlQYWtz9S
ttTuhA//cuSNReLpNT7MtnSrTh/NMHak2UJhClO5A5q6dWLRuhjag+AG0ik7S0MD
+PN4NFCymRxsrWjBuRPfxBiNskm7Xg+EA55ZSelxwHZhzMIUR/aEANqYBYj/YE+Q
fhOTXq88MRjYHSYycGoIUviGaLgEQx3wTfaK4aR7F5MfnaUuqqwz7Rnc6E9F740C
HcnbeoqakAY9SXsNke0NYjM+AnvV5FuGcU3Qcz26cZkRCBMS0QkvE2CR17EOq779
mmj+nvpdD5h3teEGAznG9yADdwkpgXRDEkg6JHVYSlMC69H9qcvMeXYPbTw4cOkV
bX4abUrC3pS3LupHMRB8BGKLn2PyZjZHE8xUmKSkC7BH3ZL5A47teNdH9725Geld
tVA+OIxmujQIU4vWgnQq96auj/ukO/QCzZgE4/7i5m5Sp5lN5IDasVgwTgXkSJQ9
5KPKGAul8xGiHaYkhjCJd7iZYuhtWq7oer9fF/AC8eTz4v45Kryg0lmmtb0hA4Oc
9LD9WaI+yg5vCh188b3hLS28jC/yktx/T+6+7lHJqI0jyCHp9vAMl6O5VxUfX/eZ
PmwQADsZKBzMAgwiuWdPVdogUzhua7pxfpuZ3VS519nPHSybGdiYw6iHYq04+x6E
i+9y/Zx57p3D03com/Bwurivkd2HnBB+KBbcbqPMDIB/k5cNTIM=
=hUXu
-----END PGP SIGNATURE-----

--=-zBDRiKK8xztrGjRvBz3a--