Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4515402ybl; Mon, 26 Aug 2019 11:33:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRiGdHUPslu51ycfTOYEkVLrjHFAqNek+VWGzg9vlaZoxU4v3NaF/tx3kNK93QSZd0s2Yt X-Received: by 2002:a17:90a:24cc:: with SMTP id i70mr22051341pje.12.1566844384650; Mon, 26 Aug 2019 11:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566844384; cv=none; d=google.com; s=arc-20160816; b=z9GdnWgHiZL14gNkz+f2lHrQPcy8+f1vNQ8bZdhVUEQJ4HApiF8UOiI37gkLSnGnmd 7RgjXi10VFwDXjlAAI8waR/WwAwLT4LaqMWJ4gul1/3Y2Pkw88R3N4gOUKfLU9U9epQ/ Ny+PnHcLszV7DAQgtJPr2976ixEQVXwxryu68QbcIbhDbFPyMhOgxmbMxEzoMID8Dk3U xbE1j1vXdUoQkjQqABA+gNVM1tDxrH43bu1pukbGMbph+DtQj0CHRXdW8/3oID6szpCg Sp0MJ5NEHJY9mDQCY9UfdSwedmJsy4hpB7ZcmLn6qqyNByKEpmVKMXX0pTXbJqTpBwIZ VNAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Q3xiFZ2HkA5ScIJ98h57XT9QNlYTEuEKJ22ZvSjaM40=; b=rs8I7QGMcgx0N1loaEzs6K0C5/qy+G/AF+6tnDvb8cCrP/H2Vp243QQThofrbzEsNt hTeTwKVvmFjMigXCFBPwuPlYPBTP6ixUK8yrbyh5eG4ygWAkWl+Wraw8s8VB2/jriSK0 qS+/gmebMYpB++b11bKoKpSfcxhrUIrkskZfxR/Ie1EzJ1kDgVtiNz4BozEQE0saljYf e2tW1/rTGKVznElQ33/o+6u4NQSPSZskL42dLnVUwHo/YSGBGhrH75A3AWCDZSwn77yx Fcnpp8YmY5mRu2gffRqlNObGK2OC+pyLkB831Rt91lX5MGr5SToL3HQlquU76rKV4nGt Ur4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=W1ThBxZ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h34si10393961pld.78.2019.08.26.11.32.48; Mon, 26 Aug 2019 11:33:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=W1ThBxZ2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732614AbfHZRbX (ORCPT + 99 others); Mon, 26 Aug 2019 13:31:23 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41442 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727211AbfHZRbW (ORCPT ); Mon, 26 Aug 2019 13:31:22 -0400 Received: by mail-pg1-f196.google.com with SMTP id x15so11018996pgg.8 for ; Mon, 26 Aug 2019 10:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q3xiFZ2HkA5ScIJ98h57XT9QNlYTEuEKJ22ZvSjaM40=; b=W1ThBxZ2ULnw8wV8rQg1L3El9s0wK00VOmaEsGsImpIPXIn1KF9TIXouDdGAS2494U Ln5MsCmf2BCNQBcec2cm0FE4g1R00CGWTiOtLL0C0guajRLNy+eQMRUsPPsYGktFx+4D Yi2HGK7OSwFlwQm2QgQgkWFuW/YkbY7FAEScriQ1rUoziDQLATISbN/yFTOEHO/56cgr AjQoOboGivycl+rixm0sW0HJ4JCqplkDYsx2rs+D99X/qO9K0Ck9PVGglRw4XGNyyxAx zhzYaGIUCbm0qV19s7h/T3wdg10yB5I2p8Dh+6VXBUOQS/AzUhZovRKOHBAV5k9UjPAk aydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q3xiFZ2HkA5ScIJ98h57XT9QNlYTEuEKJ22ZvSjaM40=; b=QWgrXT+JGwD+JNVbVNqwNZIIWHLy8EqFinakURUG7uzXGMFF1HzAimYZywjjSdgC6T FjovUqTv9zvlRgwlpsqhaT0NYORrC08fHT1Swfa+CTYJdPBGx0y7rneH1HJhk4BTpxmg yKEu7+o4AtkWMn/c12Q1drSdyFObiEP1dcECX8xEpq/Ita98tk1OeHp6xUsGhQ9hsZ2I TjqZhl2/OmfRuVmdIpJWVQ36jS2p1EdLOVrpiDJtNxBXJDzJZYnIY9NXOxR9SeCtgBra TKVU9s+Syei1hCHX2bNvbSP31OfJqf2Zr5U6pJBp44ySmvkOGUHWb6V7YPX2Ar4bHb1B FPbg== X-Gm-Message-State: APjAAAUZ9L0IvrEpjYjNfLv1RtiBoN1KonFPBhjzki1miH22w+le/2I2 NY/N/MRA46kxDJ2ru9jORxYEIly5Rk0H9jo7eByHPQ== X-Received: by 2002:a63:60a:: with SMTP id 10mr17262703pgg.381.1566840680814; Mon, 26 Aug 2019 10:31:20 -0700 (PDT) MIME-Version: 1.0 References: <20190729211014.39333-1-ndesaulniers@google.com> <20190824141213.svzmdr3pxdaqssuj@pburton-laptop> In-Reply-To: <20190824141213.svzmdr3pxdaqssuj@pburton-laptop> From: Nick Desaulniers Date: Mon, 26 Aug 2019 10:31:09 -0700 Message-ID: Subject: Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base To: Paul Burton Cc: Ralf Baechle , James Hogan , Nathan Chancellor , Eli Friedman , Hassan Naveed , Stephen Kitt , Serge Semin , Mike Rapoport , Andrew Morton , Michal Hocko , "linux-mips@vger.kernel.org" , LKML , clang-built-linux , "regehr@cs.utah.edu" , Philip Reames , Alexander Potapenko , Alistair Delva , "Maciej W. Rozycki" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 24, 2019 at 7:12 AM Paul Burton wrote: > > Hi Nick, > > On Fri, Aug 23, 2019 at 10:16:04AM -0700, Nick Desaulniers wrote: > > On Tue, Aug 20, 2019 at 10:15 AM Nick Desaulniers > > wrote: > > > Hi Paul, > > > Bumping this thread; we'd really like to be able to boot test another > > > ISA in our CI. This lone patch is affecting our ability to boot. Can > > > you please pick it up? > > > https://lore.kernel.org/lkml/20190729211014.39333-1-ndesaulniers@google.com/ > > > > Hi Paul, > > Following up with this link that explains the undefined behavior issue more: > > https://wiki.sei.cmu.edu/confluence/display/c/EXP05-C.+Do+not+cast+away+a+const+qualification > > Please reconsider accepting this patch. > > Sorry, it's been a crazy few months & I'm currently away awaiting my > father's funeral so I'm working through a backlog & catching up on > things. That's an extremely tough hand to be dealt. Got it myself a week before I turned 20. Technically, (spoiler) everyone is eventually dealt it; not that that or really anything else can ever truly provide solace despite the common refrain "time heals all wounds" (Narrator: it doesn't). Depending on where you are in life it can really really destabilize things. I wrote this blog post (https://nickdesaulniers.github.io/blog/2013/04/29/the-persistence-of-memory/) that I'm not too proud of at a time I now realize that I was still kind of a state of shock (even years later). I also found it very difficult to accept advice from others who didn't share the experience of losing a parent. No one would fault you for asking your co-maintainers to handle more maintainer responsibilities for a while. I hope you can find a friend to commiserate with over beers. I owe you one. > > It will be a shame to lose the optimization opportunities const offers > us, but it is an ugly hack & so I'm OK with applying this. It's likely > to affect older machines more than newer ones (which tend to use less or > no I/O port access) so I'm not too worried about the impact, but if we > find it matters we can always try the fixmap approach I suggested > previously. > > Thanks, > Paul -- Thanks, ~Nick Desaulniers